🐛 Fix phpstan errors

🐛 Fix phpstan errors

🐛 Fix phpstan errors

Author: rahimi

src/FileCache.php

@@ -2,6 +2,8 @@
 
 namespace CachingProxy;
 
+use RuntimeException;
+
 class FileCache
 {
     public function __construct()
@@ -14,13 +16,22 @@ public function getCacheKey(string $url): string
         return md5($url);
     }
 
+    /**
+     * @return array<mixed>|null
+     */
     public function get(string $url): ?array
     {
         $fileName = $this->getCacheKey($url);
         $cacheFile = cache_path($fileName);
 
-        if (file_exists($cacheFile)) {
-            $data = unserialize(file_get_contents($cacheFile));
+        if (file_exists($cacheFile) && is_readable($cacheFile)) {
+            $cacheFileContent = file_get_contents($cacheFile);
+
+            if ($cacheFileContent === false) {
+                throw new RuntimeException("Failed to read Cache file `{$cacheFile}`");
+            }
+
+            $data = unserialize($cacheFileContent);
 
             // Check cache time to live
             if (time() - filemtime($cacheFile) < config('cache', 'ttl')) {
@@ -34,6 +45,9 @@ public function get(string $url): ?array
         return null;
     }
 
+    /**
+     * @param array<mixed> $content
+     */
     public function set(string $url, array $content): bool
     {
         $fileName = $this->getCacheKey($url);

src/ProxyServer.php

@@ -2,14 +2,16 @@
 
 namespace CachingProxy;
 
+use RuntimeException;
+
 class ProxyServer
 {
     public function __construct(
         private FileCache $cache = new FileCache()
     ) {
     }
 
-    public function handleRequest()
+    public function handleRequest(): void
     {
         header('Access-Control-Allow-Origin: *');
         header('Access-Control-Allow-Methods: GET, POST, OPTIONS');
@@ -63,7 +65,13 @@ private function getTargetUrl(): ?string
             return urldecode($_GET['url']);
         }
 
-        $input = json_decode(file_get_contents('php://input'), true);
+        $requestBody = file_get_contents('php://input');
+
+        if ($requestBody === false) {
+            throw new RuntimeException("Failed to read `POST` request body");
+        }
+
+        $input = json_decode($requestBody, true);
 
         if ($input['url'] !== null) {
             return $input['url'];
@@ -88,7 +96,10 @@ private function checkFilterUrl(string $url): bool
         return true;
     }
 
-    private function makeRequest(string $url)
+    /**
+     * @return array<mixed>
+     */
+    private function makeRequest(string $url): array
     {
         $ch = curl_init();
 
@@ -107,7 +118,14 @@ private function makeRequest(string $url)
         // Handle POST requests
         if ($_SERVER['REQUEST_METHOD'] === 'POST') {
             curl_setopt($ch, CURLOPT_POST, true);
-            curl_setopt($ch, CURLOPT_POSTFIELDS, file_get_contents('php://input'));
+
+            $requestBody = file_get_contents('php://input');
+
+            if ($requestBody === false) {
+                throw new RuntimeException("Failed to read `POST` request body");
+            }
+
+            curl_setopt($ch, CURLOPT_POSTFIELDS, $requestBody);
         }
 
         // Forward headers (excluding some sensitive headers)
@@ -159,7 +177,10 @@ private function makeRequest(string $url)
         ];
     }
 
-    private function cacheResponse($url, $response)
+    /**
+     * @param array<mixed> $response
+     */
+    private function cacheResponse(string $url, array $response): void
     {
         if ($response['status_code'] === 200) {
             header('X-Proxy-Cache: MISS');
@@ -168,13 +189,19 @@ private function cacheResponse($url, $response)
         }
     }
 
-    private function sendCachedResponse($cachedResponse)
+    /**
+     * @param array<mixed> $cachedResponse
+     */
+    private function sendCachedResponse(array $cachedResponse): void
     {
         header('X-Proxy-Cache: HIT');
         $this->sendResponse($cachedResponse);
     }
 
-    private function sendResponse(array $response)
+    /**
+     * @param array<mixed> $response
+     */
+    private function sendResponse(array $response): void
     {
         http_response_code($response['status_code']);
 
@@ -190,7 +217,7 @@ private function sendResponse(array $response)
         echo $response['body'];
     }
 
-    private function sendError($message, $statusCode = 500)
+    private function sendError(string $message, int $statusCode = 500): void
     {
         http_response_code($statusCode);
         header('Content-Type: application/json');

src/helpers/functions.php

@@ -22,7 +22,7 @@ function config_path(string $file): string
 }
 
 if (! function_exists('dd')) {
-    function dd(...$vars): void
+    function dd(mixed ...$vars): void
     {
         echo '<pre>';
         var_dump(...$vars);
@@ -32,7 +32,7 @@ function dd(...$vars): void
 }
 
 if (! function_exists('config')) {
-    function config(string $fileName, string $index)
+    function config(string $fileName, string $index): mixed
     {
         $fileName = $fileName . '.php';