Refactor test parameters: centralize common values in setUp methods

Author: Mohammedcha

.github/workflows/test.yml

@@ -28,13 +28,9 @@ jobs:
         pip install -r requirements.txt
         pip install pytest pytest-cov
     
-    - name: Run package functionality test
+    - name: Run package and basic functionality tests
       run: |
-        python test_package.py
-    
-    - name: Run basic unit tests
-      run: |
-        python -m unittest tests.test_basic -v
+        python -m unittest tests.test_package tests.test_basic -v
     
     - name: Run network-dependent tests (optional)
       continue-on-error: true

test_package.py

@@ -9,10 +9,10 @@ class TestAppMethods(unittest.TestCase):
 
     @classmethod
     def setUpClass(cls):
-        cls.scraper = GPlayScraper()
-        cls.app_id = "com.whatsapp"
-        cls.lang = "en"
-        cls.country = "us"
+        cls.scraper = GPlayScraper()  # Initialize scraper
+        cls.app_id = "com.whatsapp"  # WhatsApp app ID for testing
+        cls.lang = "en"  # Language
+        cls.country = "us"  # Country
 
     def test_app_analyze(self):
         """Test app_analyze returns dictionary with data or handles errors gracefully"""
@@ -22,6 +22,12 @@ def test_app_analyze(self):
             self.assertIsInstance(result, dict)
             if result:  # Only check if we got data
                 self.assertIn('title', result)
+                print(f"\n✅ App data retrieved for {self.app_id}:")
+                print(f"Title: {result.get('title', 'N/A')}")
+                print(f"Score: {result.get('score', 'N/A')}")
+                print(f"Installs: {result.get('installs', 'N/A')}")
+                print(f"Developer: {result.get('developer', 'N/A')}")
+                print(f"Total fields: {len(result)}")
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_app_analyze: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -34,6 +40,7 @@ def test_app_get_field(self):
             if result is not None:
                 self.assertIsInstance(result, str)
                 self.assertTrue(len(result) > 0)
+                print(f"\n✅ Single field 'title': {result}")
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_app_get_field: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -46,6 +53,9 @@ def test_app_get_fields(self):
             result = self.scraper.app_get_fields(self.app_id, fields, lang=self.lang, country=self.country)
             if result:
                 self.assertIsInstance(result, dict)
+                print(f"\n✅ Multiple fields retrieved:")
+                for field, value in result.items():
+                    print(f"  {field}: {value}")
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_app_get_fields: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -54,6 +64,7 @@ def test_app_print_field(self):
         """Test app_print_field executes without error or handles errors gracefully"""
         time.sleep(2)  # Wait 2 seconds before request
         try:
+            print(f"\n✅ app_print_field output:")
             self.scraper.app_print_field(self.app_id, "title", lang=self.lang, country=self.country)
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_app_print_field: {e}")
@@ -65,6 +76,7 @@ def test_app_print_fields(self):
         """Test app_print_fields executes without error or handles errors gracefully"""
         time.sleep(2)  # Wait 2 seconds before request
         try:
+            print(f"\n✅ app_print_fields output:")
             self.scraper.app_print_fields(self.app_id, ["title", "score"], lang=self.lang, country=self.country)
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_app_print_fields: {e}")
@@ -76,6 +88,7 @@ def test_app_print_all(self):
         """Test app_print_all executes without error or handles errors gracefully"""
         time.sleep(2)  # Wait 2 seconds before request
         try:
+            print(f"\n✅ app_print_all output:")
             self.scraper.app_print_all(self.app_id, lang=self.lang, country=self.country)
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_app_print_all: {e}")

tests/test_app_methods.py

@@ -14,17 +14,23 @@ class TestDeveloperMethods(unittest.TestCase):
 
     def setUp(self):
         """Set up test fixtures before each test method."""
-        self.scraper = GPlayScraper()
-        self.dev_id = "5700313618786177705"  # WhatsApp Inc. developer ID
+        self.scraper = GPlayScraper()  # Initialize scraper
+        self.dev_id = "5700313618786177705"  # Google Inc. developer ID
+        self.count = 10  # Number of items to fetch
+        self.lang = "en"  # Language
+        self.country = "us"  # Country
 
     def test_developer_analyze(self):
         """Test developer_analyze returns list of apps."""
         time.sleep(2)
         try:
-            result = self.scraper.developer_analyze(self.dev_id, count=10)
+            result = self.scraper.developer_analyze(self.dev_id, count=self.count, lang=self.lang, country=self.country)
             self.assertIsInstance(result, list)
             if result:
                 self.assertGreater(len(result), 0)
+                print(f"\n✅ Developer apps ({len(result)} apps):")
+                for i, app in enumerate(result[:3]):  # Show first 3 apps
+                    print(f"  {i+1}. {app.get('title', 'N/A')} - {app.get('score', 'N/A')} stars")
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_developer_analyze: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -33,8 +39,12 @@ def test_developer_get_field(self):
         """Test developer_get_field returns list of field values."""
         time.sleep(2)
         try:
-            result = self.scraper.developer_get_field(self.dev_id, "title", count=5)
+            result = self.scraper.developer_get_field(self.dev_id, "title", count=self.count, lang=self.lang, country=self.country)
             self.assertIsInstance(result, list)
+            if result:
+                print(f"\n✅ Developer app titles ({len(result)} apps):")
+                for i, title in enumerate(result[:3]):
+                    print(f"  {i+1}. {title}")
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_developer_get_field: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -43,8 +53,12 @@ def test_developer_get_fields(self):
         """Test developer_get_fields returns list of dictionaries."""
         time.sleep(2)
         try:
-            result = self.scraper.developer_get_fields(self.dev_id, ["title", "score"], count=5)
+            result = self.scraper.developer_get_fields(self.dev_id, ["title", "score"], count=self.count, lang=self.lang, country=self.country)
             self.assertIsInstance(result, list)
+            if result:
+                print(f"\n✅ Developer app fields ({len(result)} apps):")
+                for i, app in enumerate(result[:3]):
+                    print(f"  {i+1}. {app.get('title', 'N/A')} - {app.get('score', 'N/A')} stars")
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_developer_get_fields: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -53,7 +67,8 @@ def test_developer_print_field(self):
         """Test developer_print_field executes without error."""
         time.sleep(2)
         try:
-            self.scraper.developer_print_field(self.dev_id, "title", count=5)
+            print(f"\n✅ developer_print_field output:")
+            self.scraper.developer_print_field(self.dev_id, "title", count=self.count, lang=self.lang, country=self.country)
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_developer_print_field: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -64,7 +79,8 @@ def test_developer_print_fields(self):
         """Test developer_print_fields executes without error."""
         time.sleep(2)
         try:
-            self.scraper.developer_print_fields(self.dev_id, ["title", "score"], count=5)
+            print(f"\n✅ developer_print_fields output:")
+            self.scraper.developer_print_fields(self.dev_id, ["title", "score"], count=self.count, lang=self.lang, country=self.country)
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_developer_print_fields: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -75,7 +91,8 @@ def test_developer_print_all(self):
         """Test developer_print_all executes without error."""
         time.sleep(2)
         try:
-            self.scraper.developer_print_all(self.dev_id, count=5)
+            print(f"\n✅ developer_print_all output:")
+            self.scraper.developer_print_all(self.dev_id, count=self.count, lang=self.lang, country=self.country)
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_developer_print_all: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")

tests/test_developer_methods.py

@@ -14,18 +14,24 @@ class TestListMethods(unittest.TestCase):
 
     def setUp(self):
         """Set up test fixtures before each test method."""
-        self.scraper = GPlayScraper()
+        self.scraper = GPlayScraper()  # Initialize scraper
         self.collection = "TOP_FREE"  # Top free apps collection
         self.category = "GAME"  # Game category
+        self.count = 10  # Number of items to fetch
+        self.lang = "en"  # Language
+        self.country = "us"  # Country
 
     def test_list_analyze(self):
         """Test list_analyze returns list of top apps."""
         time.sleep(2)
         try:
-            result = self.scraper.list_analyze(self.collection, self.category, count=10)
+            result = self.scraper.list_analyze(self.collection, self.category, count=self.count, lang=self.lang, country=self.country)
             self.assertIsInstance(result, list)
             if result:
                 self.assertGreater(len(result), 0)
+                print(f"\n✅ Top {self.collection} {self.category} apps ({len(result)} apps):")
+                for i, app in enumerate(result[:3]):  # Show first 3 apps
+                    print(f"  {i+1}. {app.get('title', 'N/A')} - {app.get('developer', 'N/A')}")
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_list_analyze: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -34,8 +40,12 @@ def test_list_get_field(self):
         """Test list_get_field returns list of field values."""
         time.sleep(2)
         try:
-            result = self.scraper.list_get_field(self.collection, self.category, "title", count=5)
+            result = self.scraper.list_get_field(self.collection, self.category, "title", count=self.count, lang=self.lang, country=self.country)
             self.assertIsInstance(result, list)
+            if result:
+                print(f"\n✅ Top chart app titles ({len(result)} apps):")
+                for i, title in enumerate(result[:3]):
+                    print(f"  {i+1}. {title}")
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_list_get_field: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -44,8 +54,12 @@ def test_list_get_fields(self):
         """Test list_get_fields returns list of dictionaries."""
         time.sleep(2)
         try:
-            result = self.scraper.list_get_fields(self.collection, self.category, ["title", "score"], count=5)
+            result = self.scraper.list_get_fields(self.collection, self.category, ["title", "score"], count=self.count, lang=self.lang, country=self.country)
             self.assertIsInstance(result, list)
+            if result:
+                print(f"\n✅ Top chart app fields ({len(result)} apps):")
+                for i, app in enumerate(result[:3]):
+                    print(f"  {i+1}. {app.get('title', 'N/A')} - {app.get('score', 'N/A')} stars")
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_list_get_fields: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -54,7 +68,8 @@ def test_list_print_field(self):
         """Test list_print_field executes without error."""
         time.sleep(2)
         try:
-            self.scraper.list_print_field(self.collection, self.category, "title", count=5)
+            print(f"\n✅ list_print_field output:")
+            self.scraper.list_print_field(self.collection, self.category, "title", count=self.count, lang=self.lang, country=self.country)
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_list_print_field: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -65,7 +80,8 @@ def test_list_print_fields(self):
         """Test list_print_fields executes without error."""
         time.sleep(2)
         try:
-            self.scraper.list_print_fields(self.collection, self.category, ["title", "score"], count=5)
+            print(f"\n✅ list_print_fields output:")
+            self.scraper.list_print_fields(self.collection, self.category, ["title", "score"], count=self.count, lang=self.lang, country=self.country)
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_list_print_fields: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")
@@ -76,7 +92,8 @@ def test_list_print_all(self):
         """Test list_print_all executes without error."""
         time.sleep(2)
         try:
-            self.scraper.list_print_all(self.collection, self.category, count=5)
+            print(f"\n✅ list_print_all output:")
+            self.scraper.list_print_all(self.collection, self.category, count=self.count, lang=self.lang, country=self.country)
         except (NetworkError, RateLimitError, GPlayScraperError) as e:
             warnings.warn(f"Network/Rate limit error in test_list_print_all: {e}")
             self.skipTest(f"Skipping due to network/rate limit: {e}")