Tests (where relevant) don't actually make sure that an exception was thrown.

[SoniEx2]

Tests like these:

brigadier/src/test/java/com/mojang/brigadier/StringReaderTest.java

Lines 239 to 247 in cf754c4

	@Test
	public void readQuotedString_noOpen() throws Exception {
	try {
	new StringReader("hello world\"").readQuotedString();
	} catch (final CommandSyntaxException ex) {
	assertThat(ex.getType(), is(CommandSyntaxException.BUILT_IN_EXCEPTIONS.readerExpectedStartOfQuote()));
	assertThat(ex.getCursor(), is(0));
	}
	}

will actually pass if no exception is thrown.

[Pokechu22]

According to this random article I found, JUnit 5 has an assertThrows that returns the exception if a matching one is found (and fails otherwise), which is probably the ideal thing for this kind of test. JUnit 4 has the ExpectedException rule, but I don't think that it would be usable for this purpose.

The easiest approach, and one that already seems to be used by some of the existing tests, is to call fail() after the code that should throw the exception. That's easy enough that I'll look into making a PR for it.

[Marcono1234]

JUnit 4 also has an assertThrows method since version 4.13, see https://github.com/junit-team/junit4/wiki/Exception-testing#using-assertthrows-method

Also Brigadier uses the old Maven artifact coordinates for JUnit: junit:junit-dep:4.11
It should switch (and update) to junit:junit:4.13.2