Added Vector3Utils.ceil. Finished getBlockVolume tests but need to confirm expected results of different scenarios with design.

Author: sweetniamhy

libraries/math/src/aabb/coreHelpers.test.ts

@@ -155,10 +155,31 @@ describe('AABB operations', () => {
 });
 
 describe('AABB BlockVolume operations', () => {
-    it('successfully creates a BlockVolume containing a valid AABB', () => {
+    it('successfully creates a BlockVolume when AABB extents are VECTOR3_ONE', () => {
         const aabb: AABB = { center: VECTOR3_ZERO, extents: VECTOR3_ONE };
         const blockVolume = AABBUtils.getBlockVolume(aabb);
         expect(Vector3Utils.equals(blockVolume.from, { x: -1.0, y: -1.0, z: -1.0 })).toBe(true);
         expect(Vector3Utils.equals(blockVolume.to, { x: 1.0, y: 1.0, z: 1.0 })).toBe(true);
     });
+
+    it('successfully creates a BlockVolume when AABB extents are close but less than VECTOR3_ONE', () => {
+        const aabb: AABB = { center: VECTOR3_ZERO, extents: { x: 0.99999, y: 0.99999, z: 0.99999 } };
+        const blockVolume = AABBUtils.getBlockVolume(aabb);
+        expect(Vector3Utils.equals(blockVolume.from, { x: -1.0, y: -1.0, z: -1.0 })).toBe(true);
+        expect(Vector3Utils.equals(blockVolume.to, { x: 1.0, y: 1.0, z: 1.0 })).toBe(true);
+    });
+
+    it('successfully creates a BlockVolume when AABB extents are close but greater than VECTOR3_ZERO', () => {
+        const aabb: AABB = { center: VECTOR3_ZERO, extents: { x: 0.00001, y: 0.00001, z: 0.00001 } };
+        const blockVolume = AABBUtils.getBlockVolume(aabb);
+        expect(Vector3Utils.equals(blockVolume.from, { x: -1.0, y: -1.0, z: -1.0 })).toBe(true);
+        expect(Vector3Utils.equals(blockVolume.to, { x: 1.0, y: 1.0, z: 1.0 })).toBe(true);
+    });
+
+    it('successfully creates a BlockVolume when AABB extents are close but greater than VECTOR3_ONE', () => {
+        const aabb: AABB = { center: VECTOR3_ZERO, extents: { x: 1.00001, y: 1.00001, z: 1.00001 } };
+        const blockVolume = AABBUtils.getBlockVolume(aabb);
+        expect(Vector3Utils.equals(blockVolume.from, { x: -2.0, y: -2.0, z: -2.0 })).toBe(true);
+        expect(Vector3Utils.equals(blockVolume.to, { x: 2.0, y: 2.0, z: 2.0 })).toBe(true);
+    });
 });

libraries/math/src/aabb/coreHelpers.ts

@@ -111,28 +111,9 @@ export class AABBUtils {
      * @returns - The BlockVolume containing the source AABB.
      */
     static getBlockVolume(aabb: AABB): BlockVolume {
-        const from = this.getMin(aabb);
-        from.x = Math.floor(from.x);
-        from.y = Math.floor(from.y);
-        from.z = Math.floor(from.z);
-
-        // Could be added to Vector3Utils
-        const to = this.getMax(aabb);
-        to.x = Math.floor(to.x);
-        to.y = Math.floor(to.y);
-        to.z = Math.floor(to.z);
-
+        const from = Vector3Utils.floor(this.getMin(aabb));
+        const to = Vector3Utils.ceil(this.getMax(aabb));
         return new BlockVolume(from, to);
-
-        /*
-        GetBlockVolume(box: AABB): BlockVolumeBase
-        We get the smallest block volume that includes all of the bounding box
-        The collision code uses (floor(min - 1), floor(max + 1), we should probably continue using this calculation
-        We could also use (floor(min), ceil(max))
-        There might be some floating point errors like <1.0, 1.0>, <4.000001, 4.00001> and <1.0, 1.0>, <3.99999, 3.99999> returning different Block Volumes
-        Perhaps handle that specific edge case by doing a nearEqual comparison (0.00001 diff)
-        ToBeCloseTo check this out later as a reference of what already exists for checking if a float is close to a target number --> (vitest/packages/expect/src/jest-expect.ts at 34f67546df3848c66bcdfa48f5221717d498b965 · vitest-dev/vitest · GitHub), and use math.round()
-        */
     }
 
     /**

libraries/math/src/vector3/coreHelpers.ts

@@ -100,6 +100,15 @@ export class Vector3Utils {
         return { x: Math.floor(v.x), y: Math.floor(v.y), z: Math.floor(v.z) };
     }
 
+    /**
+     * ceil
+     *
+     * Ceil the components of a vector to produce a new vector
+     */
+    static ceil(v: Vector3): Vector3 {
+        return { x: Math.ceil(v.x), y: Math.ceil(v.y), z: Math.ceil(v.z) };
+    }
+
     /**
      * toString
      *