Metadata support for property and argument bounds info #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/markup-generators-plugin/templates/msdocs/script/module_changelog.mustache
Outdated
Show resolved
Hide resolved
…e and max value changes
…pertyAndArgumentBoundsInfo
BrandonChanSkybox
requested review from
JakeShirley and
rlandav
as code owners
BrandonChanSkybox
requested review from
SBLMikeDemone and
zachcampbellskyboxlabs
Contributor
SBLMikeDemone
left a comment
SBLMikeDemone
left a comment
There was a problem hiding this comment.
Looks good, just a few unnecessary changes and some mild confusion around the new argument comments
...-generator-test-snapshots/test/changelog_diffing/__snapshots__/changelogDiffing.spec.ts.snap
Outdated
Show resolved
Hide resolved
...-generator-test-snapshots/test/changelog_diffing/__snapshots__/changelogDiffing.spec.ts.snap
Outdated
Show resolved
Hide resolved
tools/markup-generators-plugin/templates/msdocs/script/module_changelog.mustache
Outdated
Show resolved
Hide resolved
JakeShirley
reviewed
Dec 4, 2025
tools/api-docs-generator-test-snapshots/test/bounds/input/test-module_v2.json
Outdated
Show resolved
Hide resolved
SBLMikeDemone
approved these changes
Dec 4, 2025
Contributor
SBLMikeDemone
left a comment
SBLMikeDemone
left a comment
There was a problem hiding this comment.
Makes sense to me, just 2 small nits.
JakeShirley
approved these changes
Dec 4, 2025
zachcampbellskyboxlabs
approved these changes
Jan 8, 2026
SBLMikeDemone
approved these changes
Jan 8, 2026
Contributor
SBLMikeDemone
left a comment
SBLMikeDemone
left a comment
There was a problem hiding this comment.
Looks good! Nothing blocking, thank you for the tests!
tools/markup-generators-plugin/templates/tsdef/function.mustache
Outdated
Show resolved
Hide resolved
JakeShirley
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Metadata support for Property and Argument Minimum and Maximum bounds info