cleanup: fix bunches of warnings when byte-compile (emacs-lsp#279)

Author: kiennq

dap-mode.el

@@ -528,7 +528,7 @@ thread exection but the server will log message."
 (defun dap--parser-read (p output)
   "Parser OUTPUT using parser P."
   (let* ((messages '())
-         (output (string-as-unibyte output))
+         (output (encode-coding-string output 'utf-8 'nocopy))
          (chunk (concat (dap--parser-leftovers p) output)))
     (while (not (string-empty-p chunk))
       (if (not (dap--parser-reading-body p))
@@ -607,7 +607,7 @@ thread exection but the server will log message."
   (interactive (list (dap--cur-active-session-or-die)))
   (dap--send-message (dap--make-request "disconnect"
                                         (list :restart :json-false))
-                     (lambda (result)
+                     (lambda (_result)
                        (when-let (proc (dap--debug-session-program-proc session))
                          (lsp--info "Killing process %s" proc)
                          (kill-process proc)))
@@ -890,7 +890,10 @@ PARAMS are the event params.")
                                                         debug-session
                                                         (gethash "command" parsed-msg)))
                                 (message "Unable to find handler for %s." (pp parsed-msg))))
-                  ("request" (-let* (((&hash "arguments" (&hash? "args" "cwd" "title") "command" "seq") parsed-msg)
+                  ("request" (-let* (((&hash "arguments"
+                                             (&hash? "args" "cwd")
+                                             "seq")
+                                      parsed-msg)
                                      (default-directory cwd))
                                (async-shell-command (s-join " " args))
                                (dap--send-message (dap--make-response seq)
@@ -913,8 +916,8 @@ PARAMS are the event params.")
     (list :command command
           :type "request")))
 
-(defun dap--make-response (id &optional args)
-  "Make request for COMMAND with arguments ARGS."
+(defun dap--make-response (id &optional _args)
+  "Make request with ID and arguments ARGS."
   (list :request_seq id
         :success t
         :type "response"))
@@ -1059,10 +1062,10 @@ DEBUG-SESSION is the active debug session."
 
 (defun dap--breakpoint-filter-enabled (filter type default)
   (alist-get filter
-             (alist-get type dap-exception-breakpoints nil nil #'string=)
+             (alist-get type dap-exception-breakpoints nil nil #'equal)
              default
              nil
-             #'string=))
+             #'equal))
 
 (defun dap--set-exception-breakpoints (debug-session callback)
   (-let [(&dap-session 'initialize-result 'launch-args (&plist :type)) debug-session]
@@ -1076,7 +1079,7 @@ DEBUG-SESSION is the active debug session."
                                              (when (dap--breakpoint-filter-enabled filter type default)
                                                filter))))
                                   [])))
-     (lambda (result)
+     (lambda (_result)
        (funcall callback))
      debug-session)))
 
@@ -1444,39 +1447,38 @@ after selecting configuration template."
         (funcall launch-args #'dap-start-debugging)
       (dap-start-debugging launch-args))))
 
-(defun dap-debug-edit-template (&optional parg debug-args)
+(defun dap-debug-edit-template (&optional debug-args)
   "Edit registered template DEBUG-ARGS.
 When being invoked with prefix argument, poping up the prepopulated version of the template.
-Otherwise, return its original version. After registration, the new template can be used
-normally with dap-debug"
-
-  (interactive "P")
-  (let ((debug-args (dap--select-template (not parg))))
-    (progn
-      (with-current-buffer (or (get-buffer "*DAP Templates*")
-                               (with-current-buffer (get-buffer-create "*DAP Templates*")
-                                 (emacs-lisp-mode)
-                                 (current-buffer)))
-        (goto-char (point-max))
-        (when (s-blank? (buffer-string))
-          (insert ";; Eval Buffer with `M-x eval-buffer' to register the newly created template."))
-        (insert
-         (format "\n\n(dap-register-debug-template\n  \"%s%s\"\n"
-                 (plist-get debug-args :name)
-                 (if parg " - Copy" "")))
-        (insert "  (list ")
-        (-let ((column (current-column))
-               ((fst snd . rst) debug-args))
-          (insert (format "%s %s" fst (prin1-to-string snd)))
-          (cl-loop for (k v) on rst by (function cddr)
-                   do (if (not (equal k :program-to-start))
-                          (progn
-                            (insert "\n")
-                            (--dotimes column (insert " "))
-                            (insert (format "%s %s" k (prin1-to-string v)))))))
-        (insert "))"))
-      (pop-to-buffer "*DAP Templates*")
-      (goto-char (point-max)))))
+Otherwise, return its original version.  After registration, the new template can be used
+normally with `dap-debug'"
+  (interactive)
+  (unless debug-args
+    (setq debug-args (dap--select-template (not current-prefix-arg))))
+  (with-current-buffer (or (get-buffer "*DAP Templates*")
+                           (with-current-buffer (get-buffer-create "*DAP Templates*")
+                             (emacs-lisp-mode)
+                             (current-buffer)))
+    (goto-char (point-max))
+    (when (s-blank? (buffer-string))
+      (insert ";; Eval Buffer with `M-x eval-buffer' to register the newly created template."))
+    (insert
+     (format "\n\n(dap-register-debug-template\n  \"%s%s\"\n"
+             (plist-get debug-args :name)
+             (if current-prefix-arg " - Copy" "")))
+    (insert "  (list ")
+    (-let ((column (current-column))
+           ((fst snd . rst) debug-args))
+      (insert (format "%s %s" fst (prin1-to-string snd)))
+      (cl-loop for (k v) on rst by (function cddr)
+         do (if (not (equal k :program-to-start))
+                (progn
+                  (insert "\n")
+                  (--dotimes column (insert " "))
+                  (insert (format "%s %s" k (prin1-to-string v)))))))
+    (insert "))"))
+  (pop-to-buffer "*DAP Templates*")
+  (goto-char (point-max)))
 
 (defun dap-debug-last ()
   "Debug last configuration."

dap-ui.el

@@ -556,6 +556,7 @@ DEBUG-SESSION is the debug session triggering the event."
   `(defun ,name (&rest args)
      ,(format "Code action %s" name)
      (interactive)
+     (ignore args)
      (if-let (node (treemacs-node-at-point))
          (-let [,(cons '&plist keys) (button-get node :item)]
            ,@body)
@@ -753,7 +754,8 @@ DEBUG-SESSION is the debug session triggering the event."
                       (list :variablesReference variables-reference
                             :name name
                             :value (read-string (format "Enter value for %s: " name ) value)))
-   (-lambda (result))
+   ;; FIXME: create properly callback here
+   #'ignore
    session))
 
 (defun dap-ui-render-variables (debug-session variables-reference _node)
@@ -763,7 +765,7 @@ DEBUG-SESSION is the debug session triggering the event."
      (dap-request debug-session "variables" :variablesReference)
      (gethash "variables")
      (-map (-lambda ((&hash "value" "name"
-                            "indexedVariables" indexed-variables
+                            "indexedVariables" _indexed-variables
                             "variablesReference" variables-reference))
              `(:label ,(concat (propertize (format "%s" name)
                                            'face 'font-lock-variable-name-face)