Timestamp issue with prepared statements

Author: bolner

Examples/DataModification/src/Application.php

@@ -17,6 +17,7 @@
 
 namespace Example;
 
+use DateTime;
 use MonetDB\Connection;
 
 
@@ -34,7 +35,8 @@ public function Run(array $args) {
                 "weight_kg" decimal(8, 2),
                 "category" text,
                 "birth_date" date,
-                "net_worth_usd" decimal(20, 4)
+                "net_worth_usd" decimal(20, 4),
+                "created" timestamp
             );
         ');
 
@@ -44,28 +46,30 @@ public function Run(array $args) {
 
         /* *** */
 
+        $now = date("Y-m-d H:i:s.u");
+
         $result = $connection->Query(<<<EOF
             start transaction;
 
             insert into
                 "cats"
-                ("name", "weight_kg", "category", "birth_date", "net_worth_usd")
+                ("name", "weight_kg", "category", "birth_date", "net_worth_usd", "created")
             values
-                ('Tiger', 8.2, 'fluffy', '2012-04-23', 2340000),
-                ('Oscar', 3.4, 'spotted', '2014-02-11', 556235.34),
-                ('Coco', 2.52, 'spotted', '2008-12-31', 1470500000),
-                ('Max', 4.23, 'spotted', '2010-01-15', 100),
-                ('Sooty', 7.2, 'shorthair', '2016-10-01', 580000),
-                ('Milo', 5.87, 'spotted', '2015-06-23', 1500.53),
-                ('Muffin', 12.6, 'fluffy', '2013-04-07', 230000),
-                ('Ginger', 9.4, 'shorthair', '2012-06-19', 177240.5),
-                ('Fluffor', 13.12, 'fluffy', '2000-10-07', 5730180200.12),
-                ('Lucy', 3.12, 'shorthair', '2018-06-29', 5780000),
-                ('Chloe', 2.12, 'spotted', '2013-05-01', 13666200),
-                ('Misty', 1.96, 'shorthair', '2014-11-24', 12000000),
-                ('Sam', 3.45, 'fluffy', '2018-12-19', 580.4),
-                ('Gizmo', 4.65, 'fluffy', '2016-05-11', 120300),
-                ('Kimba', 1.23, 'spotted', '2020-01-08', 890000);
+                ('Tiger', 8.2, 'fluffy', '2012-04-23', 2340000, timestamp '{$now}'),
+                ('Oscar', 3.4, 'spotted', '2014-02-11', 556235.34, timestamp '{$now}'),
+                ('Coco', 2.52, 'spotted', '2008-12-31', 1470500000, timestamp '{$now}'),
+                ('Max', 4.23, 'spotted', '2010-01-15', 100, timestamp '{$now}'),
+                ('Sooty', 7.2, 'shorthair', '2016-10-01', 580000, timestamp '{$now}'),
+                ('Milo', 5.87, 'spotted', '2015-06-23', 1500.53, timestamp '{$now}'),
+                ('Muffin', 12.6, 'fluffy', '2013-04-07', 230000, timestamp '{$now}'),
+                ('Ginger', 9.4, 'shorthair', '2012-06-19', 177240.5, timestamp '{$now}'),
+                ('Fluffor', 13.12, 'fluffy', '2000-10-07', 5730180200.12, timestamp '{$now}'),
+                ('Lucy', 3.12, 'shorthair', '2018-06-29', 5780000, timestamp '{$now}'),
+                ('Chloe', 2.12, 'spotted', '2013-05-01', 13666200, timestamp '{$now}'),
+                ('Misty', 1.96, 'shorthair', '2014-11-24', 12000000, timestamp '{$now}'),
+                ('Sam', 3.45, 'fluffy', '2018-12-19', 580.4, timestamp '{$now}'),
+                ('Gizmo', 4.65, 'fluffy', '2016-05-11', 120300, timestamp '{$now}'),
+                ('Kimba', 1.23, 'spotted', '2020-01-08', 890000, timestamp '{$now}');
 
             update
                 "cats"
@@ -93,9 +97,11 @@ public function Run(array $args) {
                 round(avg("weight_kg"), 2) as "weight_mean"
             from
                 "cats"
+            where
+                "created" <= ?
             group by
                 "category"
-        ');
+        ', [new DateTime()]);
 
         echo "Columns:\n\n";
 

README.md

@@ -163,6 +163,27 @@ $result = $connection->Query('
 ', [ "D'artagnan", 5.3 ]);
 ```
 
+The parameter types for prepared statements have to match
+the column types. See the below example. Never pass `null`,
+`true`, `false` values as strings.
+
+```php
+$result = $connection->Query('
+    update
+        "test"
+    set
+        "nullable_column" = ?
+    where
+        "bool_column" = ?
+        and "numeric_column" > ?
+        and "date_column" > ?
+        and "timestamp_column" < ?
+', [ null, false, 5.3, "2020-12-08", new DateTime()]);
+```
+
+While the `date` values have to be passed as normal strings, the
+`timestamp` type has be passed as a `DateTime` object.
+
 ## Example 4: Using escaping
 
 ```php

protocol_doc/README.md

@@ -755,11 +755,20 @@ statement with the specified parameters. Example:
     sEXECUTE 15 ('First\'Value', 'Second\"Value');
 
 Please note that all values passed to the execute statement are type sensitive.
-You cannot pass numbers or true/false values as strings, but they have to be
+You cannot pass `numbers`, `null` or `true`/`false` values as strings, but they have to be
 passed without quotes, example:
 
     sEXECUTE 16 ('2020-08-12', true, false, null, 3.141592653589, 'another string');
 
+While the `date` type is auto-converted from string, this doesn't happen for the `timestamp` type:
+
+    sEXECUTE 17 ('2020-08-12')                  // Date can be passed as string
+    sEXECUTE 18 ('2020-08-12 12:00:00.000000')  // Throws error for timestamp column
+
+If the column has a `timestamp` type, then pass the value with explicit type conversion:
+
+    sEXECUTE 18 (timestamp '2020-08-12 12:00:00.000000')
+
 All string values need to be escaped as discussed in chapter [Escaping](#61-escaping).
 Date values are also passed as strings.
 

src/Connection.php

@@ -17,6 +17,7 @@
 
 namespace MonetDB;
 
+use DateTime;
 use Exception;
 
 /**
@@ -480,7 +481,11 @@ private function WritePreparedStatement(string $sql, array $params) {
             }
             elseif (is_numeric($param) && !is_string($param)) {
                 $escaped[] = $param + 0;
-            } else {
+            }
+            elseif ($param instanceof DateTime) {
+                $escaped[] = "TIMESTAMP '".$param->format("Y-m-d H:i:s.u")."'";
+            }
+            else {
                 $escaped[] = "'".$this->Escape((string)$param)."'";
             }
         }