minor changes

Author: bolner

protocol_doc/monet-explorer/Client.hpp

@@ -37,7 +37,7 @@ namespace MonetExplorer {
              * @param isSent True = sent to the server, False = received from it.
              * @param output Most probably std::cout.
              */
-            void PrintFormatted(std::string &msg, bool isSent, std::ostream &output) {
+            void PrintFormatted(const std::string &msg, bool isSent, std::ostream &output) {
                 int mb_remain = 0;  // Bytes remaining from a multi-byte character
                 const char *pos = msg.c_str();
                 const char *endPos = pos + msg.length();
@@ -151,17 +151,22 @@ namespace MonetExplorer {
                     Connect to the server
                 */
                 if (args.IsOptionSet("unix-domain-socket")) {
+                    std::cout << "\033[32mConnecting through Unix domain socket.\033[0m\n";
+
                     this->connection.ConnectUnix(
                         args.GetIntValue("port")
                     );
                 } else {
+                    std::cout << "\033[32mConnecting through TCP/IP to: " << args.GetStringValue("host") << ':'
+                        << args.GetIntValue("port") << "\033[0m\n";
+
                     this->connection.ConnectTCP(
                         args.GetStringValue("host"),
                         args.GetIntValue("port")
                     );
                 }
 
-                std::cout << "\033[32mConnected.\033[0m\n";                
+                std::cout << "\033[32mConnected.\033[0m\n";
                 std::string msg;
 
                 /*
@@ -198,6 +203,8 @@ namespace MonetExplorer {
                     this->connection.SendMessage(msg);
                 }
 
+                std::cout << "\033[32mAuthenticated.\033[0m\n";
+
                 /*
                     Communication
                 */

protocol_doc/monet-explorer/Connection.hpp

@@ -168,9 +168,6 @@ namespace MonetExplorer {
                 /*
                     Connect through TCP/IP.
                 */
-                std::cout << "\033[32mConnecting through TCP/IP to: " << host << ':'
-                    << port << "\033[0m\n";
-
                 this->clientSocket = socket(AF_INET, SOCK_STREAM, 0);
                 if (this->clientSocket == -1) {
                     throw std::runtime_error("Failed to create socket. Error: '" + std::string(strerror(errno))
@@ -206,8 +203,6 @@ namespace MonetExplorer {
                         "(Method is called twice.)");
                 }
 
-                std::cout << "\033[32mConnecting through Unix domain socket.\033[0m\n";
-
                 this->clientSocket = socket(AF_UNIX, SOCK_STREAM, 0);
                 if (this->clientSocket == -1) {
                     throw std::runtime_error("Failed to create socket. Error: '" + std::string(strerror(errno))
@@ -303,7 +298,7 @@ namespace MonetExplorer {
              * 
              * @param message 
              */
-            void SendMessage(std::string &message) {
+            void SendMessage(const std::string &message) {
                 const char *pos = message.c_str();
                 int remaining = message.length();
                 int packetSize;

protocol_doc/monet-explorer/ServerChallenge.hpp

@@ -61,7 +61,7 @@ namespace MonetExplorer {
              * @param data Input
              * @return std::string Output
              */
-            std::string Sha512(std::string &data) {
+            std::string Sha512(const std::string &data) {
                 SHA512((unsigned char*)data.c_str(), data.length(), (unsigned char*)this->bufferBin);
                 this->BinToHex(this->bufferBin, 64, this->bufferHex);
 
@@ -74,7 +74,7 @@ namespace MonetExplorer {
              * @param data Input
              * @return std::string Output
              */
-            std::string Sha256(std::string &data) {
+            std::string Sha256(const std::string &data) {
                 SHA256((unsigned char*)data.c_str(), data.length(), (unsigned char*)this->bufferBin);
                 this->BinToHex(this->bufferBin, 32, this->bufferHex);
 
@@ -87,7 +87,7 @@ namespace MonetExplorer {
              * @param data Input
              * @return std::string Output
              */
-            std::string Sha1(std::string &data) {
+            std::string Sha1(const std::string &data) {
                 SHA1((unsigned char*)data.c_str(), data.length(), (unsigned char*)this->bufferBin);
                 this->BinToHex(this->bufferBin, 20, this->bufferHex);
 
@@ -100,7 +100,7 @@ namespace MonetExplorer {
              * @param data Input
              * @return std::string Output
              */
-            std::string Sha384(std::string &data) {
+            std::string Sha384(const std::string &data) {
                 SHA384((unsigned char*)data.c_str(), data.length(), (unsigned char*)this->bufferBin);
                 this->BinToHex(this->bufferBin, 48, this->bufferHex);
 
@@ -113,7 +113,7 @@ namespace MonetExplorer {
              * @param data Input
              * @return std::string Output
              */
-            std::string Sha224(std::string &data) {
+            std::string Sha224(const std::string &data) {
                 SHA224((unsigned char*)data.c_str(), data.length(), (unsigned char*)this->bufferBin);
                 this->BinToHex(this->bufferBin, 28, this->bufferHex);
 
@@ -126,7 +126,7 @@ namespace MonetExplorer {
              * @param data Input
              * @return std::string Output
              */
-            std::string RipeMd160(std::string &data) {
+            std::string RipeMd160(const std::string &data) {
                 RIPEMD160((unsigned char*)data.c_str(), data.length(), (unsigned char*)this->bufferBin);
                 this->BinToHex(this->bufferBin, 20, this->bufferHex);
 
@@ -139,7 +139,7 @@ namespace MonetExplorer {
              * 
              * @param msg The message received from the server.
              */
-            ServerChallenge(std::string &msg) : salt(), backend(), version(0), protocols(),
+            ServerChallenge(const std::string &msg) : salt(), backend(), version(0), protocols(),
                     endianness(), passwordHashAlgo() {
 
                 if (msg.length() < 1) {