Merge pull request #60 from eventsage/master

Issue #59: MultipleField._is_select returns false if data is None

Author: itsnauman

flask_mongoengine/wtf/fields.py

@@ -107,7 +107,7 @@ def process_formdata(self, valuelist):
                     self.data = None
 
     def _is_selected(self, item):
-        return item in self.data
+        return item in self.data if self.data else False
 
 
 class ModelSelectField(QuerySetSelectField):

tests/test_forms.py

@@ -264,6 +264,34 @@ class DogOwner(db.Document):
             self.assertTrue(choices[0].checked)
             self.assertTrue(choices[1].checked)
 
+    def test_modelselectfield_multiple_initalvalue_None(self):
+        with self.app.test_request_context('/'):
+            db = self.db
+
+            class Dog(db.Document):
+                name = db.StringField()
+
+            class DogOwner(db.Document):
+                dogs = db.ListField(db.ReferenceField(Dog))
+
+            DogOwnerForm = model_form(DogOwner)
+
+            dogs = [Dog(name="fido"), Dog(name="rex")]
+            for dog in dogs:
+                dog.save()
+
+            form = DogOwnerForm(dogs=None)
+            self.assertTrue(form.validate())
+
+            self.assertEqual(wtforms.widgets.Select, type(form.dogs.widget))
+            self.assertEqual(True, form.dogs.widget.multiple)
+
+            # Validate if both dogs are selected
+            choices = list(form.dogs)
+            self.assertEqual(len(choices), 2)
+            self.assertFalse(choices[0].checked)
+            self.assertFalse(choices[1].checked)
+
     def test_passwordfield(self):
         with self.app.test_request_context('/'):
             db = self.db