Skip to content

Commit a320b13

Browse files
author
Len Buckens
committed
do not ignore 'False' settings (fixes #127)
1 parent e72e4d8 commit a320b13

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

flask_mongoengine/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def init_app(self, app):
4848
if isinstance(conn_settings, list):
4949
self.connection = {}
5050
for conn in conn_settings:
51-
conn = dict([(k.lower(), v) for k, v in conn.items() if v])
51+
conn = dict((k.lower(), v) for k, v in conn.items() if v is not None)
5252

5353
if 'replicaset' in conn:
5454
conn['replicaSet'] = conn['replicaset']

tests/test_json_app.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,18 @@ def test_connection_kwargs(self):
7575
db.init_app(app)
7676
self.assertFalse(db.connection.tz_aware)
7777

78+
def test_connection_kwargs_with_false_values(self):
79+
app = flask.Flask(__name__)
80+
app.config['MONGODB_SETTINGS'] = {
81+
'DB': 'testing',
82+
'alias': 'test',
83+
'ssl_validate_hostname': False
84+
}
85+
app.config['TESTING'] = True
86+
db = MongoEngine()
87+
db.init_app(app)
88+
self.assertFalse(db.connection.ssl_validate_hostname)
89+
7890
def test_with_id(self):
7991
c = self.app.test_client()
8092
resp = c.get('/show/38783728378090/')

0 commit comments

Comments
 (0)