CR

Author: idocyabra

docs/changelog.rst

@@ -8,7 +8,7 @@ Development
 ===========
 - (Fill this out as you fix issues and develop your features).
 - Fix for uuidRepresentation not read when provided in URI #2741
-- Add option to user array_filters https://www.mongodb.com/docs/manual/reference/operator/update/positional-filtered/
+- Add option to user array_filters https://www.mongodb.com/docs/manual/reference/operator/update/positional-filtered/ #2769
 - Fix combination of __raw__ and mongoengine syntax #2773
 - Add tests against MongoDB 6.0 and MongoDB 7.0 in the pipeline
 - Fix validate() not being called when inheritance is used in EmbeddedDocument and validate is overriden #2784

docs/guide/querying.rst

@@ -261,9 +261,8 @@ This is done by using ``__raw__`` keyword argument to the update method and prov
 ::
 
     # assuming an initial 'tags' field == ['test1', 'test2', 'test3']
-    Page.objects().update(__raw__=
-                                  {'$set': {"tags.$[element]": 'test11111'}},
-                                  'array_filters': [{"element": {'$eq': 'test2'}}],
+    Page.objects().update(__raw__={'$set': {"tags.$[element]": 'test11111'}},
+                                  array_filters=[{"element": {'$eq': 'test2'}}],
 
     # updated 'tags' field == ['test1', 'test11111', 'test3']
 

mongoengine/queryset/base.py

@@ -562,14 +562,12 @@ def update(
 
         queryset = self.clone()
         query = queryset._query
-        if "__raw__" in update and isinstance(update["__raw__"], list):
+        if "__raw__" in update and isinstance(update["__raw__"], list):     # Case of Update with Aggregation Pipeline
             update = [
                 transform.update(queryset._document, **{"__raw__": u})
                 for u in update["__raw__"]
             ]
         else:
-            if "array_filters" in update:
-                array_filters = update.pop("array_filters")
             update = transform.update(queryset._document, **update)
         # If doing an atomic upsert on an inheritable class
         # then ensure we add _cls to the update operation