Merge pull request #2828 from bagerard/allow_list_as_value_for_gte_lte_ne

allow_list_as_value_for_gte_lte_ne

Author: bagerard

docs/changelog.rst

@@ -7,6 +7,7 @@ Changelog
 Development
 ===========
 - (Fill this out as you fix issues and develop your features).
+- Allow gt/gte/lt/lte/ne operators to be used with a list as value on ListField #2813
 - Switch tox to use pytest instead of legacy `python setup.py test` #2804
 
 Changes in 0.28.2

mongoengine/fields.py

@@ -951,11 +951,11 @@ def prepare_query_value(self, op, value):
         if self.field:
             # If the value is iterable and it's not a string nor a
             # BaseDocument, call prepare_query_value for each of its items.
+            is_iter = hasattr(value, "__iter__")
+            eligible_iter = is_iter and not isinstance(value, (str, BaseDocument))
             if (
-                op in ("set", "unset", None)
-                and hasattr(value, "__iter__")
-                and not isinstance(value, str)
-                and not isinstance(value, BaseDocument)
+                op in ("set", "unset", "gt", "gte", "lt", "lte", "ne", None)
+                and eligible_iter
             ):
                 return [self.field.prepare_query_value(op, v) for v in value]
 

tests/queryset/test_field_list.py

@@ -459,6 +459,45 @@ class User(Base):
         with pytest.raises(LookUpError):
             Base.objects.exclude("made_up")
 
+    def test_gt_gte_lt_lte_ne_operator_with_list(self):
+        class Family(Document):
+            ages = ListField(field=FloatField())
+
+        Family.drop_collection()
+
+        Family(ages=[1.0, 2.0]).save()
+        Family(ages=[]).save()
+
+        qs = list(Family.objects(ages__gt=[1.0]))
+        assert len(qs) == 1
+        assert qs[0].ages == [1.0, 2.0]
+
+        qs = list(Family.objects(ages__gt=[1.0, 1.99]))
+        assert len(qs) == 1
+        assert qs[0].ages == [1.0, 2.0]
+
+        qs = list(Family.objects(ages__gt=[]))
+        assert len(qs) == 1
+        assert qs[0].ages == [1.0, 2.0]
+
+        qs = list(Family.objects(ages__gte=[1.0, 2.0]))
+        assert len(qs) == 1
+        assert qs[0].ages == [1.0, 2.0]
+
+        qs = list(Family.objects(ages__lt=[1.0]))
+        assert len(qs) == 1
+        assert qs[0].ages == []
+
+        qs = list(Family.objects(ages__lte=[5.0]))
+        assert len(qs) == 2
+
+        qs = list(Family.objects(ages__ne=[5.0]))
+        assert len(qs) == 2
+
+        qs = list(Family.objects(ages__ne=[]))
+        assert len(qs) == 1
+        assert qs[0].ages == [1.0, 2.0]
+
 
 if __name__ == "__main__":
     unittest.main()