bring back 3.6 (want to keep it here)

Author: bagerard

.github/workflows/github-actions.yml

@@ -13,6 +13,7 @@ on:
     tags:
       - 'v[0-9]+\.[0-9]+\.[0-9]+*'
 env:
+  MONGODB_3_6: "3.6.23"
   MONGODB_4_0: "4.0.28"
   MONGODB_4_2: "4.2.25"
   MONGODB_4_4: "4.4.29"
@@ -62,6 +63,9 @@ jobs:
         MONGODB: [$MONGODB_4_0]
         PYMONGO: [$PYMONGO_3_12]
         include:
+          - python-version: "3.9"
+            MONGODB: $MONGODB_3_6
+            PYMONGO: $PYMONGO_3_12
           - python-version: "3.9"
             MONGODB: $MONGODB_4_4
             PYMONGO: $PYMONGO_3_13

.github/workflows/install_mongo.sh

@@ -16,6 +16,8 @@ if [[ "${MONGODB}" =~ ^(7.0|8.0) ]]; then
   mongo_build="mongodb-linux-x86_64-ubuntu2004-${MONGODB}"
 elif [[ "${MONGODB}" =~ ^(4.0|4.2|4.4|5.0|6.0) ]]; then
   mongo_build="mongodb-linux-x86_64-ubuntu1804-${MONGODB}"
+elif [[ "${MONGODB}" =~ ^3.6$ ]]; then
+  mongo_build="mongodb-linux-x86_64-${MONGODB}"
 else
   echo "Error: Unsupported MongoDB version: ${MONGODB}"
   usage

README.rst

@@ -35,7 +35,7 @@ an `API reference <https://mongoengine-odm.readthedocs.io/apireference.html>`_.
 
 Supported MongoDB Versions
 ==========================
-MongoEngine is currently tested against MongoDB v4.0, v4.4, v5.0, v6.0, v7.0 and v8.0. Future versions
+MongoEngine is currently tested against MongoDB v3.6, v4.0, v4.4, v5.0, v6.0, v7.0 and v8.0. Future versions
 should be supported as well, but aren't actively tested at the moment. Make
 sure to open an issue or submit a pull request if you experience any problems
 with a more recent MongoDB versions.

mongoengine/mongodb_support.py

@@ -6,7 +6,6 @@
 
 # Constant that can be used to compare the version retrieved with
 # get_mongodb_version()
-MONGODB_34 = (3, 4)
 MONGODB_36 = (3, 6)
 MONGODB_42 = (4, 2)
 MONGODB_44 = (4, 4)

tests/document/test_instance.py

@@ -25,7 +25,6 @@
     SaveConditionError,
 )
 from mongoengine.mongodb_support import (
-    MONGODB_34,
     MONGODB_36,
     get_mongodb_version,
 )
@@ -536,17 +535,12 @@ class Animal(Document):
         doc = Animal(is_mammal=True, name="Dog")
         doc.save()
 
-        mongo_db = get_mongodb_version()
-
         with query_counter() as q:
             doc.name = "Cat"
             doc.save()
             query_op = q.db.system.profile.find({"ns": "mongoenginetest.animal"})[0]
             assert query_op["op"] == "update"
-            if mongo_db <= MONGODB_34:
-                assert set(query_op["query"].keys()) == {"_id", "is_mammal"}
-            else:
-                assert set(query_op["command"]["q"].keys()) == {"_id", "is_mammal"}
+            assert set(query_op["command"]["q"].keys()) == {"_id", "is_mammal"}
 
         Animal.drop_collection()