Skip to content

Commit f94427b

Browse files
Monica-CodingWorldMonica-CodingWorld
committed
FINERACT-2206: Fix all typos in interest calculation code
1. Fixed 'allowPartialPeriodInterestCalcualtion' to 'allowPartialPeriodInterestCalculation' - REST API parameters in LoanProductsApiResource - Validation in LoanProductDataValidator, LoanApplicationValidator - Documentation, integration tests, global initializer 2. Fixed 'LoanInterestRecalcualtionAdditionalDetails' to 'LoanInterestRecalculationAdditionalDetails' - Renamed class file - Updated all references in LoanRepaymentScheduleInstallment, LoanScheduleModel*, etc. 3. Fixed error message typos: 'calcualtion' → 'calculation' Total: Complete typo fixes across 20+ files.
1 parent e294ce8 commit f94427b

File tree

48 files changed

+200
-200
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+200
-200
lines changed

‎fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/factory/LoanProductsRequestFactory.java‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP1() {
198198
.repaymentEvery(true)//
199199
.graceOnPrincipalAndInterestPayment(true)//
200200
.graceOnArrearsAgeing(true))//
201-
.allowPartialPeriodInterestCalcualtion(true)//
201+
.allowPartialPeriodInterestCalculation(true)//
202202
.maxTrancheCount(10)//
203203
.outstandingLoanBalance(10000.0)//
204204
.charges(charges)//
@@ -308,7 +308,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP1InterestFlat() {
308308
.repaymentEvery(true)//
309309
.graceOnPrincipalAndInterestPayment(true)//
310310
.graceOnArrearsAgeing(true))
311-
.allowPartialPeriodInterestCalcualtion(true)//
311+
.allowPartialPeriodInterestCalculation(true)//
312312
.maxTrancheCount(10)//
313313
.outstandingLoanBalance(10000.0)//
314314
.charges(charges)//
@@ -416,7 +416,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP1InterestDeclining()
416416
.repaymentEvery(true)//
417417
.graceOnPrincipalAndInterestPayment(true)//
418418
.graceOnArrearsAgeing(true))
419-
.allowPartialPeriodInterestCalcualtion(true)//
419+
.allowPartialPeriodInterestCalculation(true)//
420420
.maxTrancheCount(10)//
421421
.outstandingLoanBalance(10000.0)//
422422
.charges(charges)//
@@ -704,7 +704,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP2InterestDailyRecalcu
704704
.repaymentEvery(true)//
705705
.graceOnPrincipalAndInterestPayment(true)//
706706
.graceOnArrearsAgeing(true))//
707-
.allowPartialPeriodInterestCalcualtion(false)//
707+
.allowPartialPeriodInterestCalculation(false)//
708708
.allowVariableInstallments(false)//
709709
.amortizationType(AMORTIZATION_TYPE)//
710710
.canDefineInstallmentAmount(true)//
@@ -865,7 +865,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP2() {
865865
.repaymentEvery(true)//
866866
.graceOnPrincipalAndInterestPayment(true)//
867867
.graceOnArrearsAgeing(true))//
868-
.allowPartialPeriodInterestCalcualtion(true)//
868+
.allowPartialPeriodInterestCalculation(true)//
869869
.maxTrancheCount(10)//
870870
.outstandingLoanBalance(10000.0)//
871871
.charges(charges)//
@@ -978,7 +978,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP2InterestFlat() {
978978
.repaymentEvery(true)//
979979
.graceOnPrincipalAndInterestPayment(true)//
980980
.graceOnArrearsAgeing(true))
981-
.allowPartialPeriodInterestCalcualtion(true)//
981+
.allowPartialPeriodInterestCalculation(true)//
982982
.maxTrancheCount(10)//
983983
.outstandingLoanBalance(10000.0)//
984984
.charges(charges)//
@@ -1089,7 +1089,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP2Emi() {
10891089
.repaymentEvery(true)//
10901090
.graceOnPrincipalAndInterestPayment(true)//
10911091
.graceOnArrearsAgeing(true))//
1092-
.allowPartialPeriodInterestCalcualtion(false)//
1092+
.allowPartialPeriodInterestCalculation(false)//
10931093
.maxTrancheCount(10)//
10941094
.outstandingLoanBalance(10000.0)//
10951095
.charges(charges)//
@@ -1219,7 +1219,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP2EmiWithChargeOff() {
12191219
.repaymentEvery(true)//
12201220
.graceOnPrincipalAndInterestPayment(true)//
12211221
.graceOnArrearsAgeing(true))//
1222-
.allowPartialPeriodInterestCalcualtion(false)//
1222+
.allowPartialPeriodInterestCalculation(false)//
12231223
.maxTrancheCount(10)//
12241224
.outstandingLoanBalance(10000.0)//
12251225
.charges(charges)//
@@ -1337,7 +1337,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP2ChargeOffReasonToExp
13371337
.repaymentEvery(true)//
13381338
.graceOnPrincipalAndInterestPayment(true)//
13391339
.graceOnArrearsAgeing(true))//
1340-
.allowPartialPeriodInterestCalcualtion(true)//
1340+
.allowPartialPeriodInterestCalculation(true)//
13411341
.maxTrancheCount(10)//
13421342
.outstandingLoanBalance(10000.0)//
13431343
.charges(charges)//
@@ -1471,7 +1471,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP2EmiCashAccounting()
14711471
.repaymentEvery(true)//
14721472
.graceOnPrincipalAndInterestPayment(true)//
14731473
.graceOnArrearsAgeing(true))//
1474-
.allowPartialPeriodInterestCalcualtion(false)//
1474+
.allowPartialPeriodInterestCalculation(false)//
14751475
.maxTrancheCount(10)//
14761476
.outstandingLoanBalance(10000.0)//
14771477
.charges(charges)//
@@ -1576,7 +1576,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP2CapitalizedIncome()
15761576
.repaymentEvery(true)//
15771577
.graceOnPrincipalAndInterestPayment(true)//
15781578
.graceOnArrearsAgeing(true))//
1579-
.allowPartialPeriodInterestCalcualtion(true)//
1579+
.allowPartialPeriodInterestCalculation(true)//
15801580
.maxTrancheCount(10)//
15811581
.outstandingLoanBalance(10000.0)//
15821582
.charges(charges)//
@@ -1714,7 +1714,7 @@ public PostLoanProductsRequest defaultLoanProductsRequestLP2BuyDownFees() {
17141714
.repaymentEvery(true)//
17151715
.graceOnPrincipalAndInterestPayment(true)//
17161716
.graceOnArrearsAgeing(true))//
1717-
.allowPartialPeriodInterestCalcualtion(false)//
1717+
.allowPartialPeriodInterestCalculation(false)//
17181718
.maxTrancheCount(10)//
17191719
.outstandingLoanBalance(10000.0)//
17201720
.charges(charges)//

‎fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/initializer/global/LoanProductGlobalInitializerStep.java‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public void initialize() throws Exception {
122122
String name4 = DefaultLoanProduct.LP1_INTEREST_DECLINING_BALANCE_PERIOD_DAILY.getName();
123123
PostLoanProductsRequest loanProductsRequestInterestDecliningPeriodDaily = loanProductsRequestFactory
124124
.defaultLoanProductsRequestLP1InterestDeclining().name(name4)
125-
.interestCalculationPeriodType(InterestCalculationPeriodTime.DAILY.value).allowPartialPeriodInterestCalcualtion(false);
125+
.interestCalculationPeriodType(InterestCalculationPeriodTime.DAILY.value).allowPartialPeriodInterestCalculation(false);
126126
PostLoanProductsResponse responseInterestDecliningPeriodDaily = createLoanProductIdempotent(
127127
loanProductsRequestInterestDecliningPeriodDaily);
128128
TestContext.INSTANCE.set(TestContextKey.DEFAULT_LOAN_PRODUCT_CREATE_RESPONSE_LP1_INTEREST_DECLINING_PERIOD_DAILY,
@@ -209,7 +209,7 @@ public void initialize() throws Exception {
209209
.recalculationRestFrequencyType(RecalculationRestFrequencyType.SAME_AS_REPAYMENT.value)//
210210
.multiDisburseLoan(true)//
211211
.disallowExpectedDisbursements(true)//
212-
.allowPartialPeriodInterestCalcualtion(true)//
212+
.allowPartialPeriodInterestCalculation(true)//
213213
.maxTrancheCount(10)//
214214
.outstandingLoanBalance(10000.0);//
215215
PostLoanProductsResponse responseInterestDecliningBalanceSaRRecalculationSameAsRepaymentCompoundingNoneMultiDisbursement = createLoanProductIdempotent(
@@ -686,7 +686,7 @@ public void initialize() throws Exception {
686686
.name(name33)//
687687
.enableAccrualActivityPosting(true)//
688688
.interestCalculationPeriodType(InterestCalculationPeriodTime.DAILY.value)//
689-
.allowPartialPeriodInterestCalcualtion(false);//
689+
.allowPartialPeriodInterestCalculation(false);//
690690
PostLoanProductsResponse responseInterestDecliningPeriodDailyAccrualActivity = createLoanProductIdempotent(
691691
loanProductsRequestInterestDecliningPeriodDailyAccrualActivity);
692692
TestContext.INSTANCE.set(TestContextKey.DEFAULT_LOAN_PRODUCT_CREATE_RESPONSE_LP1_INTEREST_DECLINING_PERIOD_DAILY_ACCRUAL_ACTIVITY,
@@ -701,7 +701,7 @@ public void initialize() throws Exception {
701701
.name(name34)//
702702
.enableAccrualActivityPosting(true)//
703703
.interestCalculationPeriodType(InterestCalculationPeriodTime.DAILY.value)//
704-
.allowPartialPeriodInterestCalcualtion(false);//
704+
.allowPartialPeriodInterestCalculation(false);//
705705
PostLoanProductsResponse responseLP1InterestDecliningBalanceDailyRecalculationCompoundingNoneAccrualActivity = createLoanProductIdempotent(
706706
loanProductsRequestLP1InterestDecliningBalanceDailyRecalculationCompoundingNoneAccrualActivity);
707707
TestContext.INSTANCE.set(
@@ -1315,7 +1315,7 @@ public void initialize() throws Exception {
13151315
.enableDownPayment(false)//
13161316
.interestRecalculationCompoundingMethod(0)//
13171317
.repaymentFrequencyType(REPAYMENT_FREQUENCY_TYPE_MONTHS)//
1318-
.allowPartialPeriodInterestCalcualtion(true)//
1318+
.allowPartialPeriodInterestCalculation(true)//
13191319
.paymentAllocation(List.of(//
13201320
createPaymentAllocation("DEFAULT", "NEXT_INSTALLMENT")));//
13211321
PostLoanProductsResponse responseLP2AdvancedPaymentInterestEmi36030InterestRecalculationDailyAllowPartialPeriod = createLoanProductIdempotent(
@@ -1952,7 +1952,7 @@ public void initialize() throws Exception {
19521952
.defaultLoanProductsRequestLP1InterestDeclining().name(name81).isInterestRecalculationEnabled(true)
19531953
.preClosureInterestCalculationStrategy(1).rescheduleStrategyMethod(1).interestRecalculationCompoundingMethod(0)
19541954
.recalculationRestFrequencyType(2).recalculationRestFrequencyInterval(1)
1955-
.interestCalculationPeriodType(InterestCalculationPeriodTime.DAILY.value).allowPartialPeriodInterestCalcualtion(false);
1955+
.interestCalculationPeriodType(InterestCalculationPeriodTime.DAILY.value).allowPartialPeriodInterestCalculation(false);
19561956
final PostLoanProductsResponse responseInterestDecliningPeriodDailyIntRecalc = createLoanProductIdempotent(
19571957
loanProductsRequestInterestDecliningPeriodDailyIntRecalc);
19581958
TestContext.INSTANCE.set(TestContextKey.DEFAULT_LOAN_PRODUCT_CREATE_RESPONSE_LP1_INTEREST_DECLINING_PERIOD_DAILY_INT_RECALC,
@@ -1964,7 +1964,7 @@ public void initialize() throws Exception {
19641964
final PostLoanProductsRequest loanProductsRequestInterest36030DecliningPeriodDailyIntRecalc = loanProductsRequestFactory
19651965
.defaultLoanProductsRequestLP1InterestDeclining().name(name82).isInterestRecalculationEnabled(false)
19661966
.daysInYearType(DaysInYearType.DAYS360.value).daysInMonthType(DaysInMonthType.DAYS30.value)
1967-
.interestCalculationPeriodType(InterestCalculationPeriodTime.DAILY.value).allowPartialPeriodInterestCalcualtion(false);
1967+
.interestCalculationPeriodType(InterestCalculationPeriodTime.DAILY.value).allowPartialPeriodInterestCalculation(false);
19681968
final PostLoanProductsResponse responseInterest36030DecliningPeriodDailyIntRecalc = createLoanProductIdempotent(
19691969
loanProductsRequestInterest36030DecliningPeriodDailyIntRecalc);
19701970
TestContext.INSTANCE.set(TestContextKey.DEFAULT_LOAN_PRODUCT_CREATE_RESPONSE_LP1_INTEREST_360_30__DECLINING_PERIOD_DAILY_INT_RECALC,
@@ -3168,7 +3168,7 @@ public void initialize() throws Exception {
31683168
.disbursedAmountPercentageForDownPayment(null)//
31693169
.multiDisburseLoan(true)//
31703170
.disallowExpectedDisbursements(true)//
3171-
.allowPartialPeriodInterestCalcualtion(false)//
3171+
.allowPartialPeriodInterestCalculation(false)//
31723172
.maxTrancheCount(10)//
31733173
.outstandingLoanBalance(10000.0)//
31743174
.paymentAllocation(List.of(//
@@ -3202,7 +3202,7 @@ public void initialize() throws Exception {
32023202
.disbursedAmountPercentageForDownPayment(null)//
32033203
.multiDisburseLoan(true)//
32043204
.disallowExpectedDisbursements(true)//
3205-
.allowPartialPeriodInterestCalcualtion(false)//
3205+
.allowPartialPeriodInterestCalculation(false)//
32063206
.maxTrancheCount(10)//
32073207
.outstandingLoanBalance(10000.0)//
32083208
.paymentAllocation(List.of(//
@@ -3259,7 +3259,7 @@ public void initialize() throws Exception {
32593259
.installmentAmountInMultiplesOf(null)//
32603260
.multiDisburseLoan(true)//
32613261
.disallowExpectedDisbursements(true)//
3262-
.allowPartialPeriodInterestCalcualtion(false)//
3262+
.allowPartialPeriodInterestCalculation(false)//
32633263
.maxTrancheCount(10)//
32643264
.outstandingLoanBalance(10000.0)//
32653265
.paymentAllocation(List.of(//
@@ -3377,7 +3377,7 @@ public void initialize() throws Exception {
33773377
// .interestType(INTEREST_TYPE_DECLINING_BALANCE)//
33783378
.defaultLoanProductsRequestLP1() //
33793379
.interestCalculationPeriodType(0)//
3380-
.allowPartialPeriodInterestCalcualtion(false)//
3380+
.allowPartialPeriodInterestCalculation(false)//
33813381
// .allowApprovedDisbursedAmountsOverApplied(false)//
33823382
.name(name130)//
33833383
.transactionProcessingStrategyCode(
@@ -3419,7 +3419,7 @@ public void initialize() throws Exception {
34193419
createPaymentAllocation("MERCHANT_ISSUED_REFUND", "REAMORTIZATION"), //
34203420
createPaymentAllocation("PAYOUT_REFUND", "NEXT_INSTALLMENT")))//
34213421
.multiDisburseLoan(true)//
3422-
.allowPartialPeriodInterestCalcualtion(true)//
3422+
.allowPartialPeriodInterestCalculation(true)//
34233423
.disallowExpectedDisbursements(true)//
34243424
.maxTrancheCount(10)//
34253425
.outstandingLoanBalance(10000.0);//
@@ -3452,7 +3452,7 @@ public void initialize() throws Exception {
34523452
createPaymentAllocation("MERCHANT_ISSUED_REFUND", "REAMORTIZATION"), //
34533453
createPaymentAllocation("PAYOUT_REFUND", "NEXT_INSTALLMENT")))//
34543454
.multiDisburseLoan(true)//
3455-
.allowPartialPeriodInterestCalcualtion(true)//
3455+
.allowPartialPeriodInterestCalculation(true)//
34563456
.disallowExpectedDisbursements(true)//
34573457
.maxTrancheCount(10)//
34583458
.outstandingLoanBalance(10000.0);//
@@ -3485,7 +3485,7 @@ public void initialize() throws Exception {
34853485
createPaymentAllocation("MERCHANT_ISSUED_REFUND", "REAMORTIZATION"), //
34863486
createPaymentAllocation("PAYOUT_REFUND", "NEXT_INSTALLMENT")))//
34873487
.multiDisburseLoan(true)//
3488-
.allowPartialPeriodInterestCalcualtion(false)//
3488+
.allowPartialPeriodInterestCalculation(false)//
34893489
.disallowExpectedDisbursements(true)//
34903490
.maxTrancheCount(10)//
34913491
.outstandingLoanBalance(10000.0);//
@@ -3839,7 +3839,7 @@ public void initialize() throws Exception {
38393839
.installmentAmountInMultiplesOf(null)//
38403840
.multiDisburseLoan(true)//
38413841
.disallowExpectedDisbursements(true)//
3842-
.allowPartialPeriodInterestCalcualtion(true)//
3842+
.allowPartialPeriodInterestCalculation(true)//
38433843
.maxTrancheCount(10)//
38443844
.outstandingLoanBalance(10000.0)//
38453845
.allowApprovedDisbursedAmountsOverApplied(true)//
@@ -3866,7 +3866,7 @@ public void initialize() throws Exception {
38663866
.installmentAmountInMultiplesOf(null)//
38673867
.multiDisburseLoan(true)//
38683868
.disallowExpectedDisbursements(true)//
3869-
.allowPartialPeriodInterestCalcualtion(true)//
3869+
.allowPartialPeriodInterestCalculation(true)//
38703870
.maxTrancheCount(10)//
38713871
.outstandingLoanBalance(10000.0)//
38723872
.allowApprovedDisbursedAmountsOverApplied(true)//
@@ -3886,7 +3886,7 @@ public void initialize() throws Exception {
38863886
.name(name145)//
38873887
.interestType(INTEREST_TYPE_FLAT)//
38883888
.interestCalculationPeriodType(InterestCalculationPeriodTime.DAILY.value)//
3889-
.allowPartialPeriodInterestCalcualtion(false)//
3889+
.allowPartialPeriodInterestCalculation(false)//
38903890
.recalculationRestFrequencyType(RecalculationRestFrequencyType.DAILY.value)//
38913891
.recalculationRestFrequencyInterval(1)//
38923892
.daysInYearType(DaysInYearType.DAYS360.value)//
@@ -3917,7 +3917,7 @@ public void initialize() throws Exception {
39173917
.enableDownPayment(true)//
39183918
.enableAutoRepaymentForDownPayment(true)//
39193919
.disbursedAmountPercentageForDownPayment(new BigDecimal(25))//
3920-
.allowPartialPeriodInterestCalcualtion(true)//
3920+
.allowPartialPeriodInterestCalculation(true)//
39213921
.maxTrancheCount(10)//
39223922
.outstandingLoanBalance(10000.0);//
39233923
PostLoanProductsResponse responseLoanProductsRequestInterestFlatSaRRecalculationSameAsRepaymentMultiDisbursementAUtoDownPayment = createLoanProductIdempotent(
@@ -4144,7 +4144,7 @@ public void initialize() throws Exception {
41444144
.name(DefaultLoanProduct.LP1_INTEREST_FLAT_DAILY_RECALCULATION_SAR_MULTIDISB_EXPECT_TRANCHES.getName())//
41454145
.interestType(INTEREST_TYPE_FLAT)//
41464146
.interestCalculationPeriodType(InterestCalculationPeriodTime.DAILY.value)//
4147-
.allowPartialPeriodInterestCalcualtion(false)//
4147+
.allowPartialPeriodInterestCalculation(false)//
41484148
.recalculationRestFrequencyType(RecalculationRestFrequencyType.SAME_AS_REPAYMENT.value)//
41494149
.recalculationRestFrequencyInterval(1)//
41504150
.installmentAmountInMultiplesOf(null)//
@@ -4181,7 +4181,7 @@ public void initialize() throws Exception {
41814181
.name(DefaultLoanProduct.LP1_INTEREST_FLAT_DAILY_ACTUAL_ACTUAL_MULTIDISB_EXPECT_TRANCHES.getName())//
41824182
.interestType(INTEREST_TYPE_FLAT)//
41834183
.interestCalculationPeriodType(InterestCalculationPeriodTime.DAILY.value)//
4184-
.allowPartialPeriodInterestCalcualtion(false)//
4184+
.allowPartialPeriodInterestCalculation(false)//
41854185
.recalculationRestFrequencyType(RecalculationRestFrequencyType.DAILY.value)//
41864186
.interestRecalculationCompoundingMethod(0)//
41874187
.recalculationRestFrequencyInterval(1)//

0 commit comments

Comments
 (0)