Fix android lint config download

 - The task was defined multiple times since we do so for each lint
task

Author: jsotuyod

src/integTest/groovy/com/monits/gradle/sca/AndroidLintIntegTest.groovy

@@ -113,8 +113,6 @@ class AndroidLintIntegTest extends AbstractIntegTestFixture {
         BuildResult secondRun = gradleRunner.build()
 
         then:
-        file('build/outputs/').list().each { println it }
-
         firstRun.task(taskName()).outcome == SUCCESS
         secondRun.task(taskName()).outcome == UP_TO_DATE
 
@@ -144,8 +142,6 @@ class AndroidLintIntegTest extends AbstractIntegTestFixture {
         BuildResult secondRun = gradleRunner.build()
 
         then:
-        file('build/outputs/').list().each { println it }
-
         firstRun.task(':lintDebug').outcome == SUCCESS
         secondRun.task(':lintDebug').outcome == UP_TO_DATE
 

src/main/groovy/com/monits/gradle/sca/AndroidHelper.groovy

@@ -34,6 +34,7 @@ final class AndroidHelper {
     private static final VersionNumber REPORT_PER_VARIANT_ANDROID_GRADLE_VERSION_MAX = VersionNumber.parse('2.2.9')
     private static final VersionNumber LINT_HAS_VARIANT_INFO = VersionNumber.parse('1.5.0')
     private static final VersionNumber USES_REPORTS_DIR = VersionNumber.parse(VERSION_2_3_0)
+    private static final VersionNumber USES_JAVAC_TASK_OUTPUTS = VersionNumber.parse('3.2.0')
 
     /**
      * Checks if the current Android Plugin produces a global report that matches a debuggable variant or not.
@@ -83,6 +84,14 @@ final class AndroidHelper {
         "${project.buildDir}/outputs/"
     }
 
+    static String getCompileOutputDir(final Project project, final String sourceSetName, final String sourceSetPath) {
+        if (getCurrentVersion(project) >= USES_JAVAC_TASK_OUTPUTS) {
+            return project.buildDir.absolutePath +
+                "/intermediates/javac/${sourceSetName}/compile${sourceSetName.capitalize()}JavaWithJavac/classes/"
+        }
+
+        project.buildDir.absolutePath + '/intermediates/classes/' + sourceSetPath + File.separator
+    }
     /**
      * Retrieves the location of Android's build-cache directory.
      * @param project The project to analyze.

src/main/groovy/com/monits/gradle/sca/ClasspathAware.groovy

@@ -188,7 +188,7 @@ trait ClasspathAware {
             }
         }
 
-        project.buildDir.absolutePath + '/intermediates/classes/' + sourceSetOutputPath + File.separator
+        AndroidHelper.getCompileOutputDir(project, sourceSetName, sourceSetOutputPath)
     }
 
     /**

src/main/groovy/com/monits/gradle/sca/config/RemoteConfigLocator.groovy

@@ -48,29 +48,32 @@ class RemoteConfigLocator {
                                        final String localFileName, final String taskName) {
         File destFile = getDestinationFile(project, localFileName)
 
-        DownloadTask download = getDownloadTaskIfExists(project, configLocation)
+        // Make sure it doesn't already exist in the current project
+        if (project.tasks.findByName(taskName) == null) {
+            DownloadTask download = getDownloadTaskIfExists(project, configLocation)
 
-        if (download) {
-            if (download.downloadedFile.absolutePath == destFile.absolutePath) {
-                // Same file, so we create a NOOP task
-                project.task(taskName, dependsOn:download.path)
-            } else {
-                // Already downloading, just wait for it to finish and copy it
-                project.task(taskName, type:Copy) { Copy it ->
-                    it.from download.downloadedFile.parentFile
-                    it.into getDestinationDirectory(project)
-                    it.include download.downloadedFile.name
-                    it.rename download.downloadedFile.name, localFileName
-                    it.dependsOn download.path
+            if (download) {
+                if (download.downloadedFile.absolutePath == destFile.absolutePath) {
+                    // Same file, so we create a NOOP task
+                    project.task(taskName, dependsOn:download.path)
+                } else {
+                    // Already downloading, just wait for it to finish and copy it
+                    project.task(taskName, type:Copy) { Copy it ->
+                        it.from download.downloadedFile.parentFile
+                        it.into getDestinationDirectory(project)
+                        it.include download.downloadedFile.name
+                        it.rename download.downloadedFile.name, localFileName
+                        it.dependsOn download.path
+                    }
                 }
-            }
-        } else {
-            download = project.task(taskName, type:DownloadTask) { DownloadTask it ->
-                it.downloadedFile = destFile
-                it.resourceUri = configLocation
-            } as DownloadTask
+            } else {
+                download = project.task(taskName, type:DownloadTask) { DownloadTask it ->
+                    it.downloadedFile = destFile
+                    it.resourceUri = configLocation
+                } as DownloadTask
 
-            DOWNLOAD_TASKS[configLocation] = download.path
+                DOWNLOAD_TASKS[configLocation] = download.path
+            }
         }
 
         destFile