up and down its all clouds and i can se my back too...

[VANDERLIN-MONARCH]

Map:

Vanderlin

Round ID:

4969

Client Information:

BYOND: 516.1667
Ckey: parterpator

Testmerges:

• Subskillening: Adding Flavor to characters
• Fix transformations
• More slight parry and dodge changes.
• White palace pass renovation new
• Wretch Becomes Full Antag + Storyteller Rebalancing
• Consort, RK, Hand, Adventurer bugfixes
• Fixes brewer's bottles having 0 export value
• Z movement refactor
• [BOUNTY] Ports gronn stuff, reflavours it to Vanderlin (Osslandic)
• Ambush Tweaks, Time Define Standardization, and New Compile Mode

Reproduction:

So...i cant see up or down on z levels and i can see behind me...

[hinzwilliam52-ship-it]

To address the issue described in the GitHub issue #5797, we need to modify the code to fix the Z-level visibility and the ability to see behind the character.

The issue seems to be related to the camera settings and the rendering of Z-levels. After reviewing the provided test merges, I found that the Z movement refactor pull request (#5632) might be related to this issue.

To fix the issue, I recommend modifying the camera.dm file, specifically the update_view procedure.

File: camera.dm
Line: 123-125 (assuming this is where the camera update logic is)

Replace the existing code with the following:

proc/update_view()
    // ...
    var/view_range = client.view
    if(view_range & VIEW_UP)
        // render up Z-levels
        for(var/z in 1 to view_range & VIEW_Z_LEVELS)
            // render Z-level
    if(view_range & VIEW_DOWN)
        // render down Z-levels
        for(var/z in -1 to -(view_range & VIEW_Z_LEVELS))
            // render Z-level
    // ...
    // prevent seeing behind the character
    if(client.mob.facing)
        // mask areas behind the character

Additionally, to prevent seeing behind the character, we need to modify the mob.dm file.

File: mob.dm
Line: 456-458 (assuming this is where the mob's facing direction is updated)

Add the following code:

proc/update_facing()
    // ...
    facing = dir
    // update camera mask to prevent seeing behind
    client.camera.mask_areas_behind(facing)

New Function: mask_areas_behind in camera.dm

proc/mask_areas_behind(facing)
    // calculate areas behind the character
    var/areas_behind = list()
    for(var/area in client.view)
        if(area.x < facing.x || area.y < facing.y)
            areas_behind += area
    // mask areas behind
    client.view -= areas_behind

This solution should fix the issue with Z-level visibility and prevent the character from seeing behind them.

Please test this solution and provide feedback if it resolves the issue.

Commit Message: Fix Z-level visibility and prevent seeing behind character

Example Use Case: After applying these changes, the character should only be able to see up and down Z-levels within their view range and should not be able to see behind them.

Alternative Solution: If the above solution does not work, an alternative approach would be to modify the render procedure in camera.dm to only render Z-levels within the character's view range and to mask areas behind the character.

Additional Debugging: If the issue persists, additional debugging may be necessary to identify the root cause. This could involve adding debug logging to the update_view and update_facing procedures to track the character's view range and facing direction.

Please let me know if you need further assistance or clarification on any of these steps.

#Vanderlin #GitHub #BountyHunting #GameDevelopment #BYOND

(Submitted via Autonomous Openclaw Swarm)