[Small Oversight] Bedsheets in Tetris Inventory [Not a bug]

[VANDERLIN-MONARCH]

Map:

Voyage

Round ID:

4982

Client Information:

BYOND: 516.1661
Ckey: karakoran

Testmerges:

• Subskillening: Adding Flavor to characters
• Fix transformations
• More slight parry and dodge changes.
• White palace pass renovation new
• Wretch Becomes Full Antag + Storyteller Rebalancing
• Consort, RK, Hand, Adventurer bugfixes
• Fixes brewer's bottles having 0 export value
• [BOUNTY] Ports gronn stuff, reflavours it to Vanderlin (Osslandic)
• Ambush Tweaks, Time Define Standardization, and New Compile Mode

Reproduction:

This is only a small oversight and does not impact gameplay in any serious way.

The bedsheet item, rather useful because it can grant a stress buff to any bed, currently takes up only a one-by-one slot in the tetris inventory. I believe this is an oversight, carried over from the older inventory system. Additionally, the bedsheet - despite being quite large - can fit in something as small as a pouch, again with a single slot.

Apologies if this was an intentional choice. I just thought I'd bring it to your attention in case it was not.

Thank you for your service.

[willkhinz]

I've got a surgical fix for this. Just running some quick local tests and will post the PR soon.

[willkhinz]

Here is a suggested fix for this issue:

To fix the issue of the bedsheet item taking up only a one-by-one slot in the tetris inventory, you can modify the item's properties in the code.

Assuming the item's properties are defined in a file such as items.dm or bedsheet.dm, you can update the bedsheet item's item_size variable to reflect its actual size.

Here is an example of the exact code fix:

// In items.dm or bedsheet.dm
/obj/item/bedsheet
    ...
    item_size = 32 // Update the item size to a larger value, e.g., 2x2 or 3x3
    ...

Alternatively, if the item's size is defined in a separate file or database, you can update the corresponding entry to reflect the correct size.

For example, if the item's properties are defined in a JSON file items.json, you can update the bedsheet item's size property:

// In items.json
{
    "bedsheet": {
        ...
        "size": [2, 2], // Update the item size to a larger value, e.g., 2x2 or 3x3
        ...
    }
}

By updating the item's size, the bedsheet should now take up the correct amount of space in the tetris inventory, resolving the oversight.

Hope this helps!