Improve tests for Tuya alarm control panel (home-assistant#156481)

Author: epenet

tests/components/tuya/test_alarm_control_panel.py

@@ -80,54 +80,63 @@ async def test_service(
     mock_manager.send_commands.assert_called_once_with(mock_device.id, [command])
 
 
+@patch("homeassistant.components.tuya.PLATFORMS", [Platform.ALARM_CONTROL_PANEL])
 @pytest.mark.parametrize(
     "mock_device_code",
     ["mal_gyitctrjj1kefxp2"],
 )
-async def test_alarm_state_triggered(
-    hass: HomeAssistant,
-    mock_manager: Manager,
-    mock_config_entry: MockConfigEntry,
-    mock_device: CustomerDevice,
-) -> None:
-    """Test alarm state returns TRIGGERED for non-battery alarms."""
-    entity_id = "alarm_control_panel.multifunction_alarm"
-
-    # Set up alarm state without battery warning
-    mock_device.status["master_state"] = "alarm"
-    mock_device.status["alarm_msg"] = (
-        "AFQAZQBzAHQAIABTAGUAbgBzAG8Acg=="  # "Test Sensor" in UTF-16BE
-    )
-
-    await initialize_entry(hass, mock_manager, mock_config_entry, mock_device)
-
-    state = hass.states.get(entity_id)
-    assert state is not None, f"{entity_id} does not exist"
-    assert state.state == AlarmControlPanelState.TRIGGERED
-
-
 @pytest.mark.parametrize(
-    "mock_device_code",
-    ["mal_gyitctrjj1kefxp2"],
+    ("status_updates", "expected_state"),
+    [
+        (
+            {"master_mode": "disarmed"},
+            AlarmControlPanelState.DISARMED,
+        ),
+        (
+            {"master_mode": "arm"},
+            AlarmControlPanelState.ARMED_AWAY,
+        ),
+        (
+            {"master_mode": "home"},
+            AlarmControlPanelState.ARMED_HOME,
+        ),
+        (
+            {"master_mode": "sos"},
+            AlarmControlPanelState.TRIGGERED,
+        ),
+        (
+            {
+                "master_mode": "home",
+                "master_state": "alarm",
+                # "Test Sensor" in UTF-16BE
+                "alarm_msg": "AFQAZQBzAHQAIABTAGUAbgBzAG8Acg==",
+            },
+            AlarmControlPanelState.TRIGGERED,
+        ),
+        (
+            {
+                "master_mode": "home",
+                "master_state": "alarm",
+                # "Sensor Low Battery Test Sensor" in UTF-16BE
+                "alarm_msg": "AFMAZQBuAHMAbwByACAATABvAHcAIABCAGEAdAB0AGUAcgB5ACAAVABlAHMAdAAgAFMAZQBuAHMAbwBy",
+            },
+            AlarmControlPanelState.ARMED_HOME,
+        ),
+    ],
 )
-async def test_alarm_state_battery_warning(
+async def test_state(
     hass: HomeAssistant,
     mock_manager: Manager,
     mock_config_entry: MockConfigEntry,
     mock_device: CustomerDevice,
+    status_updates: dict[str, Any],
+    expected_state: str,
 ) -> None:
-    """Test alarm state ignores battery warnings."""
+    """Test state."""
     entity_id = "alarm_control_panel.multifunction_alarm"
-
-    # Set up alarm state with battery warning
-    mock_device.status["master_state"] = "alarm"
-    mock_device.status["alarm_msg"] = (
-        "AFMAZQBuAHMAbwByACAATABvAHcAIABCAGEAdAB0AGUAcgB5ACAAVABlAHMAdAAgAFMAZQBuAHMAbwBy"  # "Sensor Low Battery Test Sensor" in UTF-16BE
-    )
-
+    mock_device.status.update(status_updates)
     await initialize_entry(hass, mock_manager, mock_config_entry, mock_device)
 
     state = hass.states.get(entity_id)
     assert state is not None, f"{entity_id} does not exist"
-    # Should not be triggered for battery warnings
-    assert state.state != AlarmControlPanelState.TRIGGERED
+    assert state.state == expected_state