fix: resolve ruff lint errors across backend

Author: MoonMao42

apps/api/app/api/v1/chat.py

@@ -15,7 +15,13 @@
 from app.db import get_db
 from app.db.tables import Conversation, Message
 from app.i18n import get_progress_message, t
-from app.models import APIResponse, ChatStopRequest, MessagePaginatedResponse, MessageResponse, SSEEvent
+from app.models import (
+    APIResponse,
+    ChatStopRequest,
+    MessagePaginatedResponse,
+    MessageResponse,
+    SSEEvent,
+)
 from app.services.app_settings import get_or_create_app_settings, settings_to_dict
 from app.services.chat_runtime import (
     ActiveQueryRegistry,

apps/api/app/services/engine_visualization.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 from typing import Any
+
 import structlog
 
 logger = structlog.get_logger()

apps/api/app/services/execution.py

@@ -3,7 +3,6 @@
 使用 gptme 作为执行引擎
 """
 
-from asyncio import TimeoutError as AsyncioTimeoutError
 from collections.abc import AsyncGenerator, Callable
 from dataclasses import dataclass
 from typing import Any
@@ -280,7 +279,7 @@ async def execute_stream(
                 failed_stage="execution",
             )
 
-        except AsyncioTimeoutError as exc:
+        except TimeoutError:
             # Timeout errors - these are expected in some scenarios
             logger.warning(
                 "Timeout during execution",

apps/api/app/services/gptme_engine.py

@@ -54,9 +54,9 @@
     PythonSecurityAnalyzer,
     validate_python_code,
 )
-from app.services.sql_executor import SQLExecutor
 from app.services.python_sandbox import PythonSandbox
 from app.services.result_processor import ResultProcessor
+from app.services.sql_executor import SQLExecutor
 from app.services.visualization_engine import VisualizationEngine
 
 logger = structlog.get_logger()

apps/api/app/services/python_sandbox.py

@@ -7,12 +7,13 @@
 
 from __future__ import annotations
 
-from typing import TYPE_CHECKING, Any
 import asyncio
+from typing import TYPE_CHECKING, Any
+
 import structlog
 
 if TYPE_CHECKING:
-    from app.services.engine_workflow import EngineRunState
+    pass
 
 logger = structlog.get_logger()
 
@@ -92,7 +93,7 @@ async def execute(
                     self._execute_with_timeout(code),
                     timeout=timeout,
                 )
-            except asyncio.TimeoutError as exc:
+            except TimeoutError as exc:
                 logger.error("Python execution timeout", timeout=timeout)
                 raise RuntimeError(f"Code execution timeout ({timeout}s)") from exc
 

apps/api/app/services/result_processor.py

@@ -8,6 +8,7 @@
 from __future__ import annotations
 
 from typing import TYPE_CHECKING, Any
+
 import structlog
 
 if TYPE_CHECKING:
@@ -55,9 +56,9 @@ async def extract_results(
             ValueError: Content parsing failed (malformed response)
         """
         from app.services.engine_content import (
+            extract_chart_config,
             extract_python_block,
             extract_sql_block,
-            extract_chart_config,
             parse_thinking_markers,
         )
 

apps/api/app/services/visualization_engine.py

@@ -8,6 +8,7 @@
 from __future__ import annotations
 
 from typing import TYPE_CHECKING, Any
+
 import structlog
 
 if TYPE_CHECKING:

apps/api/tests/test_services.py

@@ -10,13 +10,13 @@
 Per BACK-06: Code review and test coverage documentation.
 """
 
+from unittest.mock import MagicMock, patch
+
 import pytest
-from unittest.mock import AsyncMock, MagicMock, patch, Mock
-from typing import Any
 
-from app.services.sql_executor import SQLExecutor
 from app.services.python_sandbox import PythonSandbox
 from app.services.result_processor import ResultProcessor
+from app.services.sql_executor import SQLExecutor
 from app.services.visualization_engine import VisualizationEngine
 
 
@@ -236,8 +236,7 @@ async def test_execute_with_timeout(self, sandbox):
                 mock_runtime_class.return_value = mock_runtime
 
                 with patch("asyncio.wait_for") as mock_wait:
-                    import asyncio
-                    mock_wait.side_effect = asyncio.TimeoutError()
+                    mock_wait.side_effect = TimeoutError()
 
                     with pytest.raises(RuntimeError) as exc_info:
                         await sandbox.execute(slow_code, timeout=5)
@@ -398,12 +397,8 @@ async def test_extract_chart_config_valid(self, processor):
                 "yKeys": ["revenue"],
             }
 
-            sql_data = [
-                {"date": "2024-01-01", "revenue": 1000},
-                {"date": "2024-01-02", "revenue": 2000},
-            ]
 
-            result = await processor.extract_results(ai_content)
+            await processor.extract_results(ai_content)
 
             # Since extract_chart_config is mocked, verify the mock is set up
             mock_extract.assert_called()
@@ -428,7 +423,7 @@ def test_build_chart_payload(self, processor):
             "data": data,
         }
 
-        with patch("app.services.engine_visualization.build_chart_from_config", return_value=expected_chart) as mock_build:
+        with patch("app.services.engine_visualization.build_chart_from_config", return_value=expected_chart):
             result = processor.build_chart_payload(chart_config, data)
 
             assert result is not None
@@ -580,7 +575,7 @@ class TestServiceModuleIntegration:
     async def test_sql_to_python_pipeline(self):
         """Test pipeline: SQL execution → Python analysis"""
         sql_executor = SQLExecutor()
-        python_sandbox = PythonSandbox()
+        PythonSandbox()
 
         # Mock SQL execution result
         mock_result = MagicMock()
@@ -608,7 +603,7 @@ async def test_sql_to_python_pipeline(self):
     async def test_result_processor_to_visualization_pipeline(self):
         """Test pipeline: Result extraction → Chart generation"""
         processor = ResultProcessor()
-        engine = VisualizationEngine()
+        VisualizationEngine()
 
         ai_content = """
         SQL: SELECT category, COUNT(*) as count FROM items GROUP BY category
@@ -646,7 +641,6 @@ async def test_sql_executor_specific_exceptions(self):
         executor = SQLExecutor()
 
         # Check that code uses specific exception types
-        from sqlalchemy.exc import OperationalError, ProgrammingError
         import inspect
 
         source = inspect.getsource(executor.execute_sql)
@@ -695,9 +689,9 @@ class TestAPICCompatibility:
 
     def test_service_modules_importable(self):
         """Verify all service modules can be imported"""
-        from app.services.sql_executor import SQLExecutor
         from app.services.python_sandbox import PythonSandbox
         from app.services.result_processor import ResultProcessor
+        from app.services.sql_executor import SQLExecutor
         from app.services.visualization_engine import VisualizationEngine
 
         assert SQLExecutor is not None
@@ -707,10 +701,10 @@ def test_service_modules_importable(self):
 
     def test_gptme_engine_imports_services(self):
         """Verify GptmeEngine imports and uses service modules"""
-        from app.services.gptme_engine import GptmeEngine
-
         import inspect
 
+        from app.services.gptme_engine import GptmeEngine
+
         source = inspect.getsource(GptmeEngine)
 
         # Verify service modules are imported
@@ -721,20 +715,22 @@ def test_gptme_engine_imports_services(self):
 
     def test_service_module_type_hints(self):
         """Verify service modules have proper type hints per BACK-06 checklist"""
-        from app.services.sql_executor import SQLExecutor
         import inspect
 
+        from app.services.sql_executor import SQLExecutor
+
         # Check type hints on main methods
         sig = inspect.signature(SQLExecutor.execute_sql)
         assert sig.return_annotation is not None
 
     def test_no_bare_except_clauses(self):
         """Verify no bare except clauses per D-04"""
-        from app.services.sql_executor import SQLExecutor
+        import inspect
+
         from app.services.python_sandbox import PythonSandbox
         from app.services.result_processor import ResultProcessor
+        from app.services.sql_executor import SQLExecutor
         from app.services.visualization_engine import VisualizationEngine
-        import inspect
 
         modules = [
             (SQLExecutor, "SQLExecutor"),
@@ -752,7 +748,7 @@ def test_no_bare_except_clauses(self):
                 if stripped.startswith("except:"):
                     # Allow "except:" if it's followed by comment or if it's part of error message
                     # But flag actual bare except clauses in try blocks
-                    if "except:" in line and not "except:" in "# except:":
+                    if "except:" in line and "except:" not in "# except:":
                         # This is a potential bare except - would fail per D-04
                         pass  # Acceptable in test context