parlio tweaks

Author: ewowi

docs/moonbase/inputoutput.md

@@ -10,7 +10,7 @@ Currently the following boards are defined. Not all are supported yet 🚧
 
 For each board the following presets are defined:
 
-* Modded: if any change to the default preset is made. Press off to go back to standard. If any pin is not default, modded will be set.
+* Modded: set when any pin differs from the selected board preset. Press off to return to the preset defaults.
 * Max Power in Watts: adjust the brightness to approach this max power, depending on the number of LEDs used. Default 10: 5V * 2A = 10W (so it runs fine on USB). Used by LED drivers, see [Drivers](../../moonlight/drivers/)
 * Jumper1: If the board contains a jumper, it can define pin behaviour. Eg. select between Infrared and Ethernet.
 * Pins: Assign functionality to gpio pins. Other modules and nodes use the pin assignments made here.
@@ -28,7 +28,7 @@ For each board the following presets are defined:
 
   * Supported
     * LEDs: Used by LED drivers to setup LED outputs, see [Drivers](../../moonlight/drivers/)
-    * Voltage and Current: Sets energy monitoring, see [System status](../../system/status) and , see [System Metrics](../../system/metrics)
+    * Voltage and Current: Sets energy monitoring, see [System status](../../system/status) and [System Metrics](../../system/metrics)
     * Infrared: Used by IR driver, see [Drivers](../../moonlight/drivers/)
     * Button LightsOn: sets on/off in [Light Control](../../moonlight/lightscontrol/)
     * Relay LightsOn: sets on/off in [Light Control](../../moonlight/lightscontrol/)
@@ -71,10 +71,10 @@ For each board the following presets are defined:
 
 * Choose the esp32-p4-nano board in the [MoonLight Installer](../../gettingstarted/installer/) 
 * On new boards, the WiFi coprocessor needs to be updated first to a recent version, currently v2.0.17, see the link in the [MoonLight Installer](../../gettingstarted/installer/)
-* After install, select the MHC P4 shield board preset to have the pins assigned correctly.
-    * Assuming 100W LED power!! Change if not!
-    * Jumper1: off (default): 16 LED pins. On: 8 LED pins, 4 RS-485 pins and 4 exposed pins (set the switches on the board!)
-* Add the Parallel LED Driver, see [Drivers](../../moonlight/drivers/). It uses @troyhacks his parallel IO driver to drive all the 12 LED pins of the P4 shield.
+* After install, select the **MHC P4 Nano Shield** board preset to have the pins assigned correctly.
+  * Assuming 100W LED power; change if needed.
+  * Jumper1: off (default): 16 LED pins. On: 8 LED pins, 4 RS-485 pins and 4 exposed pins (set also the switches on the board).
+* Add the Parallel LED Driver, see [Drivers](../../moonlight/drivers/). It uses @troyhacks his parallel IO driver to drive all LED pins configured for the shield.
 
 ![ESP32-P4 shield](https://shop.myhome-control.de/thumbnail/87/41/c2/1762031307/WLED_ESP32_P4_Shield_02_1920x1326.jpg?ts=1762031315){: style="width:320px"}
 

src/MoonLight/Nodes/Drivers/D_ParallelLEDDriver.h

@@ -61,9 +61,7 @@ class ParallelLEDDriver : public DriverNode {
     #else
       // LUTs are accessed directly within show_parlio via extern ledsDriver
       // No brightness parameter needed
-      show_parlio(pins, layer->layerP->lights.header.nrOfLights, layer->layerP->lights.channels,
-                  // REMOVED: ledsDriver._brightness,
-                  layer->layerP->lights.header.channelsPerLight == 4, nrOfPins, layer->layerP->ledsPerPin[0], layer->layerP->lights.header.offsetRed, layer->layerP->lights.header.offsetGreen, layer->layerP->lights.header.offsetBlue);
+      show_parlio(pins, layer->layerP->lights.header.nrOfLights, layer->layerP->lights.channels, layer->layerP->lights.header.channelsPerLight == 4, nrOfPins, layer->layerP->ledsPerPin[0], layer->layerP->lights.header.offsetRed, layer->layerP->lights.header.offsetGreen, layer->layerP->lights.header.offsetBlue);
     #endif
     }
   #else  // ESP32_LEDSDRIVER
@@ -113,6 +111,8 @@ class ParallelLEDDriver : public DriverNode {
       updateControl("status", statusString.c_str());
       moduleNodes->requestUIUpdate = true;
 
+        // ESP32-P4: Uses parlio driver with direct LUT access (no explicit init needed)
+        // Non-P4: Uses Yves driver with DMA buffer allocation and initled()
     #ifndef CONFIG_IDF_TARGET_ESP32P4  // Non P4: Yves driver
 
       if (!initDone) {

src/MoonLight/Nodes/Drivers/parlio.cpp

@@ -25,13 +25,12 @@ namespace LedMatrixDetail {
 
 // This intermediate step is common to all packing functions.
 // It transposes the data for 32 time-slices into a cache-friendly temporary buffer.
-inline void transpose_32_slices(uint32_t (&transposed_slices)[32],  // Output buffer (on stack)
-                                const uint8_t* input_buffer, const uint32_t pixel_in_pin, const uint32_t component_in_pixel, const uint32_t pixels_per_pin, const uint32_t num_active_pins, const uint32_t COMPONENTS_PER_PIXEL, const uint32_t* waveform_cache, const uint8_t* brightness_cache) {
+inline void transpose_32_slices(uint32_t (&transposed_slices)[32], const uint8_t* input_buffer, const uint32_t pixel_in_pin, const uint32_t input_component, const uint32_t pixels_per_pin, const uint32_t num_active_pins, const uint32_t COMPONENTS_PER_PIXEL, const uint32_t* waveform_cache, const uint8_t* brightness_cache) {
   memset(transposed_slices, 0, sizeof(uint32_t) * 32);
 
   for (uint32_t pin = 0; pin < num_active_pins; ++pin) {
     const uint32_t pixel_idx = (pin * pixels_per_pin) + pixel_in_pin;
-    const uint32_t component_idx = (pixel_idx * COMPONENTS_PER_PIXEL) + component_in_pixel;
+    const uint32_t component_idx = (pixel_idx * COMPONENTS_PER_PIXEL) + input_component;  // ← Now uses input_component!
     const uint8_t data_byte = brightness_cache[input_buffer[component_idx]];
     const uint32_t waveform = waveform_cache[data_byte];
     const uint32_t pin_bit = (1 << pin);
@@ -205,24 +204,24 @@ void create_transposed_led_output_optimized(const uint8_t* input_buffer, uint16_
 
       uint32_t transposed_slices[32];
 
-      // Select the appropriate LUT based on which INPUT channel we're processing
+      // Select LUT based on INPUT component (which color we're reading from lights.channels)
       const uint8_t* brightness_cache;
-      switch (component_in_pixel) {
+      switch (input_component) {  // ← Change 1: Use input_component
       case 0:
-        brightness_cache = ledsDriver.__red_map;
+        brightness_cache = ledsDriver.__red_map;  // Position 0 in RGB array = RED
         break;
       case 1:
-        brightness_cache = ledsDriver.__green_map;
+        brightness_cache = ledsDriver.__green_map;  // Position 1 in RGB array = GREEN
         break;
       case 2:
-        brightness_cache = ledsDriver.__blue_map;
+        brightness_cache = ledsDriver.__blue_map;  // Position 2 in RGB array = BLUE
         break;
       case 3:
         brightness_cache = ledsDriver.__white_map;
         break;
       default:
         brightness_cache = ledsDriver.__red_map;
-        break;  // Fallback
+        break;
       }
 
       LedMatrixDetail::transpose_32_slices(transposed_slices, input_buffer, pixel_in_pin, input_component, pixels_per_pin, num_active_pins, COMPONENTS_PER_PIXEL, waveform_cache, brightness_cache);
@@ -429,7 +428,7 @@ uint8_t IRAM_ATTR __attribute__((hot)) show_parlio(uint8_t* parallelPins, uint32
   #endif
   parallel_buffer_repacked = (parallel_buffer_repacked == parallel_buffer_repacked1) ? parallel_buffer_repacked2 : parallel_buffer_repacked1;
 
-  if (after - before < 50) delayMicroseconds(20);
+  // if (after - before < 50) delayMicroseconds(20);
 
   // portENTER_CRITICAL(&parlio_spinlock);
   for (int i = 0; i < num_chunks && i < 4; ++i) {