Doc updates + Ethernet / Art-Net-In small changes

Back-End
========
- Ethernet: set pins to int8_t (to allow for -1)
- Module
- Art-Net-In: universe Min/Max to uint16_t, max 32K

Author: ewowi

docs/develop/development.md

@@ -115,7 +115,7 @@ Firmware binaries come in 2 flavours: including boot and partition (merged) and
      * replace port and file to match your setup
      * optionally add erase-flash before write-flash
      * -b 2000000: Baud rate: lower if too high for your device
-     * use ./build/release/MoonLight_esp32-s3-devkitc-1-n16r8v_0-6-0.bin and address 0x10000 to flash only the MoonLight partition
+     * use ./build/release/MoonLight_esp32-s3-devkitc-1-n16r8v_0-6-1.bin and address 0x10000 to flash only the MoonLight partition
 
 ### Adding an ESP32 device Definition
 

docs/gettingstarted/installation.md

@@ -178,5 +178,5 @@ ESPConnect is a browser-based control center for ESP32- and ESP8266-class boards
 * Select Flash Tools, go to Flash Firmware
 * Open a firmware.bin file. 
     * Files ending with _webflash.bin (e.g. MoonLight_esp32-d0_0-6-1_webflash.bin) also formats the partition: choose Flash offset 0x0 or recommended offsets Bootloader. webflash files can be found [here](https://github.com/MoonModules/MoonLight/tree/main/firmware/installer) and are used by the [MoonLight Installer](https://moonmodules.org/MoonLight/gettingstarted/installer/) as well.
-    * Files ending with .bin, without _webflash (e.g. MoonLight_esp32-d0_0-6-1.bin). Choose recommended offsets App0 (Or App1?). Only use if you previously had MoonLight installed on the device, so the partitions has already been set. These files can be found in [published releases](https://github.com/MoonModules/MoonLight/releases).
+    * Files ending with .bin, without _webflash (e.g. MoonLight_esp32-d0_0-6-1.bin). Choose recommended offsets App0. Only use if you previously had MoonLight installed on the device, so the partitions has already been set. These files can be found in [published releases](https://github.com/MoonModules/MoonLight/releases).
     * Nightly builds if shared on [discord](https://discord.gg/MTn9mVUG5n).

docs/moonbase/inputoutput.md

@@ -63,7 +63,7 @@ For each board the following presets are defined:
 
 * Dig 2Go, Dig Uno, Dig Quad: Choose the esp32-d0 (4MB) board in the [MoonLight Installer](https://moonmodules.org/MoonLight/gettingstarted/installer/) 
 * Dig Octa: Choose the esp32-d0-16mb board in the [MoonLight Installer](https://moonmodules.org/MoonLight/gettingstarted/installer/) 
-* On first install, erase flash first (Especially when other firmware like WLED was on it) as MoonLight uses a partition scheme with 3MB of flash (no ota at the moment).
+* On first install, erase flash first (Especially when other firmware like WLED was on it) as MoonLight uses a partition scheme with 3MB of flash (currently no OTA support).
 * You might need to reset your router if you first run WLED on the same MCU and no new IP is assigned.
 
 !!! Tip "Dig Uno USB"

lib/framework/EthernetSettingsService.h

@@ -112,15 +112,15 @@ class EthernetSettingsService : public StatefulService<EthernetSettings>
 
     // 🌙 compiler directives to variables
     #ifdef CONFIG_IDF_TARGET_ESP32S3 
-        uint8_t v_ETH_SPI_SCK = UINT8_MAX; //42; v_ETH_SPI_SCK is check if configured, see configureNetwork and ModuleIO
-        uint8_t v_ETH_SPI_MISO = 44;
-        uint8_t v_ETH_SPI_MOSI = 43;
+        int8_t v_ETH_SPI_SCK = INT8_MAX; //42; v_ETH_SPI_SCK is check if configured, see configureNetwork and ModuleIO
+        int8_t v_ETH_SPI_MISO = 44;
+        int8_t v_ETH_SPI_MOSI = 43;
 
         eth_phy_type_t v_ETH_PHY_TYPE = ETH_PHY_W5500; //currently only one supported for S3 ...
         int32_t v_ETH_PHY_ADDR = 1;
-        int v_ETH_PHY_CS = 41;
-        int v_ETH_PHY_IRQ = 2; // -1 if you won't wire
-        int v_ETH_PHY_RST = 1; // -1 if you won't wire
+        int8_t v_ETH_PHY_CS = 41;
+        int8_t v_ETH_PHY_IRQ = 2; // -1 if you won't wire
+        int8_t v_ETH_PHY_RST = 1; // -1 if you won't wire
     #endif
 
 private:

src/MoonBase/Modules/ModuleIO.h

@@ -498,50 +498,43 @@ class ModuleIO : public Module {
     EXT_LOGD(MB_TAG, "Try to configure ethernet");
     EthernetSettingsService* ess = _sveltekit->getEthernetSettingsService();
     #ifdef CONFIG_IDF_TARGET_ESP32S3
-    ess->v_ETH_SPI_SCK = UINT8_MAX;
-    ess->v_ETH_SPI_MISO = UINT8_MAX;
-    ess->v_ETH_SPI_MOSI = UINT8_MAX;
-    ess->v_ETH_PHY_CS = UINT8_MAX;
-    ess->v_ETH_PHY_IRQ = UINT8_MAX;
+    ess->v_ETH_SPI_SCK = INT8_MAX;
+    ess->v_ETH_SPI_MISO = INT8_MAX;
+    ess->v_ETH_SPI_MOSI = INT8_MAX;
+    ess->v_ETH_PHY_CS = INT8_MAX;
+    ess->v_ETH_PHY_IRQ = INT8_MAX;
+
+    auto assignIfValid = [](uint8_t gpio, uint8_t usage, int8_t& target) {
+      if (GPIO_IS_VALID_GPIO(gpio))
+        target = gpio;
+      else
+        EXT_LOGE(MB_TAG, "%d: gpio %d not valid", usage, gpio);
+    };
+
     // if ethernet pins change
     // find the pins needed
     for (JsonObject pinObject : _state.data["pins"].as<JsonArray>()) {
       uint8_t usage = pinObject["usage"];
       uint8_t gpio = pinObject["GPIO"];
       if (usage == pin_SPI_SCK) {
-        if (GPIO_IS_VALID_GPIO(gpio))
-          ess->v_ETH_SPI_SCK = gpio;
-        else
-          EXT_LOGE(MB_TAG, "%d: gpio %d not valid", usage, gpio);
+        assignIfValid(gpio, usage, ess->v_ETH_SPI_SCK);
       }
       if (usage == pin_SPI_MISO) {
-        if (GPIO_IS_VALID_GPIO(gpio))
-          ess->v_ETH_SPI_MISO = gpio;
-        else
-          EXT_LOGE(MB_TAG, "%d: gpio %d not valid", usage, gpio);
+        assignIfValid(gpio, usage, ess->v_ETH_SPI_MISO);
       }
       if (usage == pin_SPI_MOSI) {
-        if (GPIO_IS_VALID_GPIO(gpio))
-          ess->v_ETH_SPI_MOSI = gpio;
-        else
-          EXT_LOGE(MB_TAG, "%d: gpio %d not valid", usage, gpio);
+        assignIfValid(gpio, usage, ess->v_ETH_SPI_MOSI);
       }
       if (usage == pin_PHY_CS) {
-        if (GPIO_IS_VALID_GPIO(gpio))
-          ess->v_ETH_PHY_CS = gpio;
-        else
-          EXT_LOGE(MB_TAG, "%d: gpio %d not valid", usage, gpio);
+        assignIfValid(gpio, usage, ess->v_ETH_PHY_CS);
       }
       if (usage == pin_PHY_IRQ) {
-        if (GPIO_IS_VALID_GPIO(gpio))
-          ess->v_ETH_PHY_IRQ = gpio;
-        else
-          EXT_LOGE(MB_TAG, "%d: gpio %d not valid", usage, gpio);
+        assignIfValid(gpio, usage, ess->v_ETH_PHY_IRQ);
       }
     }
 
     // allocate the pins found
-    if (ess->v_ETH_SPI_SCK != UINT8_MAX && ess->v_ETH_SPI_MISO != UINT8_MAX && ess->v_ETH_SPI_MOSI != UINT8_MAX && ess->v_ETH_PHY_CS != UINT8_MAX && ess->v_ETH_PHY_IRQ != UINT8_MAX) {
+    if (ess->v_ETH_SPI_SCK != INT8_MAX && ess->v_ETH_SPI_MISO != INT8_MAX && ess->v_ETH_SPI_MOSI != INT8_MAX && ess->v_ETH_PHY_CS != INT8_MAX && ess->v_ETH_PHY_IRQ != INT8_MAX) {
       // ess->v_ETH_PHY_TYPE = ETH_PHY_W5500;
       // ess->v_ETH_PHY_ADDR = 1;
       ess->v_ETH_PHY_RST = -1;  // not wired

src/MoonLight/Nodes/Drivers/D_ArtnetIn.h

@@ -28,14 +28,14 @@ class ArtNetInDriver : public Node {
   bool ddp = false;
   uint8_t view = 0;  // physical layer
   uint16_t port = 6454;
-  uint8_t universeMin = 0;
-  uint8_t universeMax = 255;
+  uint16_t universeMin = 0;
+  uint16_t universeMax = 255;
 
   void setup() override {
     addControl(ddp, "DDP", "checkbox");
     addControl(port, "port", "number", 0, 65538);
-    addControl(universeMin, "universeMin", "number", 0, 65538);
-    addControl(universeMax, "universeMax", "number", 0, 65538);
+    addControl(universeMin, "universeMin", "number", 0, 32767);
+    addControl(universeMax, "universeMax", "number", 0, 32767);
     addControl(view, "view", "select");
     addControlValue("Physical layer");
     uint8_t i = 1;  // start with one
@@ -149,7 +149,7 @@ class ArtNetInDriver : public Node {
   void handleDDP() {
     DDPHeader* header = (DDPHeader*)packetBuffer;
 
-    bool pushFlag = (header->flags & 0x80) != 0;
+    // bool pushFlag = (header->flags & 0x80) != 0;
     uint8_t dataType = header->dataType;
 
     uint32_t offset = (header->offset >> 24) | ((header->offset >> 8) & 0xFF00) | ((header->offset << 8) & 0xFF0000) | (header->offset << 24);