Skip to content

Commit 953b8a4

Browse files
committed
Merge branch 'esp_log-tag'
2 parents c69e56f + 430364c commit 953b8a4

23 files changed

+86
-83
lines changed

lib/framework/APStatus.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ void APStatus::begin()
2828
_securityManager->wrapRequest(std::bind(&APStatus::apStatus, this, std::placeholders::_1),
2929
AuthenticationPredicates::IS_AUTHENTICATED));
3030

31-
ESP_LOGV("APStatus", "Registered GET endpoint: %s", AP_STATUS_SERVICE_PATH);
31+
ESP_LOGV(TAG, "Registered GET endpoint: %s", AP_STATUS_SERVICE_PATH);
3232
}
3333

3434
esp_err_t APStatus::apStatus(PsychicRequest *request)

lib/framework/AuthenticationService.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ void AuthenticationService::begin()
3939
}
4040
return request->reply(401); });
4141

42-
ESP_LOGV("AuthenticationService", "Registered POST endpoint: %s", SIGN_IN_PATH);
42+
ESP_LOGV(TAG, "Registered POST endpoint: %s", SIGN_IN_PATH);
4343

4444
// Verifies that the request supplied a valid JWT
4545
_server->on(VERIFY_AUTHORIZATION_PATH, HTTP_GET, [this](PsychicRequest *request)
4646
{
4747
Authentication authentication = _securityManager->authenticateRequest(request);
4848
return request->reply(authentication.authenticated ? 200 : 401); });
4949

50-
ESP_LOGV("AuthenticationService", "Registered GET endpoint: %s", VERIFY_AUTHORIZATION_PATH);
50+
ESP_LOGV(TAG, "Registered GET endpoint: %s", VERIFY_AUTHORIZATION_PATH);
5151
}
5252

5353
#endif // end FT_ENABLED(FT_SECURITY)

lib/framework/DownloadFirmwareService.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ void update_progress(int currentBytes, int totalBytes)
3737
doc["progress"] = progress;
3838
JsonObject jsonObject = doc.as<JsonObject>();
3939
_socket->emitEvent(EVENT_DOWNLOAD_OTA, jsonObject);
40-
ESP_LOGV("Download OTA", "HTTP update process at %d of %d bytes... (%d %%)", currentBytes, totalBytes, progress);
40+
ESP_LOGV(TAG, "HTTP update process at %d of %d bytes... (%d %%)", currentBytes, totalBytes, progress);
4141
}
4242
previousProgress = progress;
4343
}
@@ -85,7 +85,7 @@ void updateTask(void *param)
8585
jsonObject = doc.as<JsonObject>();
8686
_socket->emitEvent(EVENT_DOWNLOAD_OTA, jsonObject);
8787

88-
ESP_LOGE("Download OTA", "HTTP Update failed with error (%d): %s", httpUpdate.getLastError(), httpUpdate.getLastErrorString().c_str());
88+
ESP_LOGE(TAG, "HTTP Update failed with error (%d): %s", httpUpdate.getLastError(), httpUpdate.getLastErrorString().c_str());
8989
#ifdef SERIAL_INFO
9090
Serial.printf("HTTP Update failed with error (%d): %s\n", httpUpdate.getLastError(), httpUpdate.getLastErrorString().c_str());
9191
#endif
@@ -97,13 +97,13 @@ void updateTask(void *param)
9797
jsonObject = doc.as<JsonObject>();
9898
_socket->emitEvent(EVENT_DOWNLOAD_OTA, jsonObject);
9999

100-
ESP_LOGE("Download OTA", "HTTP Update failed, has same firmware version");
100+
ESP_LOGE(TAG, "HTTP Update failed, has same firmware version");
101101
#ifdef SERIAL_INFO
102102
Serial.println("HTTP Update failed, has same firmware version");
103103
#endif
104104
break;
105105
case HTTP_UPDATE_OK:
106-
ESP_LOGI("Download OTA", "HTTP Update successful - Restarting");
106+
ESP_LOGI(TAG, "HTTP Update successful - Restarting");
107107
#ifdef SERIAL_INFO
108108
Serial.println("HTTP Update successful - Restarting");
109109
#endif
@@ -130,7 +130,7 @@ void DownloadFirmwareService::begin()
130130
std::bind(&DownloadFirmwareService::downloadUpdate, this, std::placeholders::_1, std::placeholders::_2),
131131
AuthenticationPredicates::IS_ADMIN));
132132

133-
ESP_LOGV("DownloadFirmwareService", "Registered POST endpoint: %s", GITHUB_FIRMWARE_PATH);
133+
ESP_LOGV(TAG, "Registered POST endpoint: %s", GITHUB_FIRMWARE_PATH);
134134
}
135135

136136
esp_err_t DownloadFirmwareService::downloadUpdate(PsychicRequest *request, JsonVariant &json)
@@ -141,7 +141,7 @@ esp_err_t DownloadFirmwareService::downloadUpdate(PsychicRequest *request, JsonV
141141
}
142142

143143
String downloadURL = json["download_url"];
144-
ESP_LOGI("Download OTA", "Starting OTA from: %s", downloadURL.c_str());
144+
ESP_LOGI(TAG, "Starting OTA from: %s", downloadURL.c_str());
145145
#ifdef SERIAL_INFO
146146
Serial.println("Starting OTA from: " + downloadURL);
147147
#endif
@@ -163,7 +163,7 @@ esp_err_t DownloadFirmwareService::downloadUpdate(PsychicRequest *request, JsonV
163163
1 // Have it on application core
164164
) != pdPASS)
165165
{
166-
ESP_LOGE("Download OTA", "Couldn't create download OTA task");
166+
ESP_LOGE(TAG, "Couldn't create download OTA task");
167167
return request->reply(500);
168168
}
169169
return request->reply(200);

lib/framework/ESP32SvelteKit.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ ESP32SvelteKit::ESP32SvelteKit(PsychicHttpServer *server, unsigned int numberEnd
6161

6262
void ESP32SvelteKit::begin()
6363
{
64-
ESP_LOGV("ESP32SvelteKit", "Loading settings from files system");
64+
ESP_LOGV(TAG, "Loading settings from files system");
6565
ESPFS.begin(true);
6666

6767
_wifiSettingsService.initWiFi();
@@ -73,7 +73,7 @@ void ESP32SvelteKit::begin()
7373

7474
#ifdef EMBED_WWW
7575
// Serve static resources from PROGMEM
76-
ESP_LOGV("ESP32SvelteKit", "Registering routes from PROGMEM static resources");
76+
ESP_LOGV(TAG, "Registering routes from PROGMEM static resources");
7777
WWWData::registerRoutes(
7878
[&](const String &uri, const String &contentType, const uint8_t *content, size_t len)
7979
{
@@ -100,7 +100,7 @@ void ESP32SvelteKit::begin()
100100
});
101101
#else
102102
// Serve static resources from /www/
103-
ESP_LOGV("ESP32SvelteKit", "Registering routes from FS /www/ static resources");
103+
ESP_LOGV(TAG, "Registering routes from FS /www/ static resources");
104104
_server->serveStatic("/_app/", ESPFS, "/www/_app/");
105105
_server->serveStatic("/favicon.png", ESPFS, "/www/favicon.png");
106106
// Serving all other get requests with "/www/index.htm"
@@ -120,13 +120,13 @@ void ESP32SvelteKit::begin()
120120
#endif
121121

122122
#if defined(ENABLE_CORS)
123-
ESP_LOGV("ESP32SvelteKit", "Enabling CORS headers");
123+
ESP_LOGV(TAG, "Enabling CORS headers");
124124
DefaultHeaders::Instance().addHeader("Access-Control-Allow-Origin", CORS_ORIGIN);
125125
DefaultHeaders::Instance().addHeader("Access-Control-Allow-Headers", "Accept, Content-Type, Authorization");
126126
DefaultHeaders::Instance().addHeader("Access-Control-Allow-Credentials", "true");
127127
#endif
128128

129-
ESP_LOGV("ESP32SvelteKit", "Starting MDNS");
129+
ESP_LOGV(TAG, "Starting MDNS");
130130
MDNS.begin(_wifiSettingsService.getHostname().c_str());
131131
MDNS.setInstanceName(_appName);
132132
MDNS.addService("http", "tcp", 80);
@@ -179,7 +179,7 @@ void ESP32SvelteKit::begin()
179179
#endif
180180

181181
// Start the loop task
182-
ESP_LOGV("ESP32SvelteKit", "Starting loop task");
182+
ESP_LOGV(TAG, "Starting loop task");
183183
xTaskCreatePinnedToCore(
184184
this->_loopImpl, // Function that should be called
185185
"ESP32 SvelteKit Loop", // Name of the task (for debugging)

lib/framework/EventSocket.cpp

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,25 @@ void EventSocket::begin()
1818
_socket.onFrame(std::bind(&EventSocket::onFrame, this, std::placeholders::_1, std::placeholders::_2));
1919
_server->on(EVENT_SERVICE_PATH, &_socket);
2020

21-
ESP_LOGV("EventSocket", "Registered event socket endpoint: %s", EVENT_SERVICE_PATH);
21+
ESP_LOGV(TAG, "Registered event socket endpoint: %s", EVENT_SERVICE_PATH);
2222
}
2323

2424
void EventSocket::registerEvent(String event)
2525
{
2626
if (!isEventValid(event))
2727
{
28-
ESP_LOGD("EventSocket", "Registering event: %s", event.c_str());
28+
ESP_LOGD(TAG, "Registering event: %s", event.c_str());
2929
events.push_back(event);
3030
}
3131
else
3232
{
33-
ESP_LOGW("EventSocket", "Event already registered: %s", event.c_str());
33+
ESP_LOGW(TAG, "Event already registered: %s", event.c_str());
3434
}
3535
}
3636

3737
void EventSocket::onWSOpen(PsychicWebSocketClient *client)
3838
{
39-
ESP_LOGI("EventSocket", "ws[%s][%u] connect", client->remoteIP().toString().c_str(), client->socket());
39+
ESP_LOGI(TAG, "ws[%s][%u] connect", client->remoteIP().toString().c_str(), client->socket());
4040
}
4141

4242
void EventSocket::onWSClose(PsychicWebSocketClient *client)
@@ -47,26 +47,26 @@ void EventSocket::onWSClose(PsychicWebSocketClient *client)
4747
event_subscriptions.second.remove(client->socket());
4848
}
4949
xSemaphoreGive(clientSubscriptionsMutex);
50-
ESP_LOGI("EventSocket", "ws[%s][%u] disconnect", client->remoteIP().toString().c_str(), client->socket());
50+
ESP_LOGI(TAG, "ws[%s][%u] disconnect", client->remoteIP().toString().c_str(), client->socket());
5151
}
5252

5353
esp_err_t EventSocket::onFrame(PsychicWebSocketRequest *request, httpd_ws_frame *frame)
5454
{
55-
ESP_LOGV("EventSocket", "ws[%s][%u] opcode[%d]", request->client()->remoteIP().toString().c_str(),
55+
ESP_LOGV(TAG, "ws[%s][%u] opcode[%d]", request->client()->remoteIP().toString().c_str(),
5656
request->client()->socket(), frame->type);
5757

5858
JsonDocument doc;
5959
#if FT_ENABLED(EVENT_USE_JSON)
6060
if (frame->type == HTTPD_WS_TYPE_TEXT)
6161
{
62-
ESP_LOGV("EventSocket", "ws[%s][%u] request: %s", request->client()->remoteIP().toString().c_str(),
62+
ESP_LOGV(TAG, "ws[%s][%u] request: %s", request->client()->remoteIP().toString().c_str(),
6363
request->client()->socket(), (char *)frame->payload);
6464

6565
DeserializationError error = deserializeJson(doc, (char *)frame->payload, frame->len);
6666
#else
6767
if (frame->type == HTTPD_WS_TYPE_BINARY)
6868
{
69-
ESP_LOGV("EventSocket", "ws[%s][%u] request: %s", request->client()->remoteIP().toString().c_str(),
69+
ESP_LOGV(TAG, "ws[%s][%u] request: %s", request->client()->remoteIP().toString().c_str(),
7070
request->client()->socket(), (char *)frame->payload);
7171

7272
DeserializationError error = deserializeMsgPack(doc, (char *)frame->payload, frame->len);
@@ -85,7 +85,7 @@ esp_err_t EventSocket::onFrame(PsychicWebSocketRequest *request, httpd_ws_frame
8585
}
8686
else
8787
{
88-
ESP_LOGW("EventSocket", "Client tried to subscribe to unregistered event: %s", doc["data"].as<String>().c_str());
88+
ESP_LOGW(TAG, "Client tried to subscribe to unregistered event: %s", doc["data"].as<String>().c_str());
8989
}
9090
}
9191
else if (event == "unsubscribe")
@@ -99,7 +99,7 @@ esp_err_t EventSocket::onFrame(PsychicWebSocketRequest *request, httpd_ws_frame
9999
}
100100
return ESP_OK;
101101
}
102-
ESP_LOGW("EventSocket", "Error[%d] parsing JSON: %s", error, (char *)frame->payload);
102+
ESP_LOGW(TAG, "Error[%d] parsing JSON: %s", error, (char *)frame->payload);
103103
}
104104
return ESP_OK;
105105
}
@@ -109,7 +109,7 @@ void EventSocket::emitEvent(String event, JsonObject &jsonObject, const char *or
109109
// Only process valid events
110110
if (!isEventValid(String(event)))
111111
{
112-
ESP_LOGW("EventSocket", "Method tried to emit unregistered event: %s", event);
112+
ESP_LOGW(TAG, "Method tried to emit unregistered event: %s", event);
113113
return;
114114
}
115115

@@ -149,7 +149,7 @@ void EventSocket::emitEvent(String event, JsonObject &jsonObject, const char *or
149149
auto *client = _socket.getClient(originSubscriptionId);
150150
if (client)
151151
{
152-
ESP_LOGV("EventSocket", "Emitting event: %s to %s[%u], Message[%d]: %s", event, client->remoteIP().toString().c_str(), client->socket(), len, output);
152+
ESP_LOGV(TAG, "Emitting event: %s to %s[%u], Message[%d]: %s", event, client->remoteIP().toString().c_str(), client->socket(), len, output);
153153
#if FT_ENABLED(EVENT_USE_JSON)
154154
client->sendMessage(HTTPD_WS_TYPE_TEXT, output, len);
155155
#else
@@ -170,7 +170,7 @@ void EventSocket::emitEvent(String event, JsonObject &jsonObject, const char *or
170170
subscriptions.remove(subscription);
171171
continue;
172172
}
173-
ESP_LOGV("EventSocket", "Emitting event: %s to %s[%u], Message[%d]: %s", event, client->remoteIP().toString().c_str(), client->socket(), len, output);
173+
ESP_LOGV(TAG, "Emitting event: %s to %s[%u], Message[%d]: %s", event, client->remoteIP().toString().c_str(), client->socket(), len, output);
174174
#if FT_ENABLED(EVENT_USE_JSON)
175175
client->sendMessage(HTTPD_WS_TYPE_TEXT, output, len);
176176
#else
@@ -203,7 +203,7 @@ void EventSocket::onEvent(String event, EventCallback callback)
203203
{
204204
if (!isEventValid(event))
205205
{
206-
ESP_LOGW("EventSocket", "Method tried to register unregistered event: %s", event.c_str());
206+
ESP_LOGW(TAG, "Method tried to register unregistered event: %s", event.c_str());
207207
return;
208208
}
209209
event_callbacks[event].push_back(callback);
@@ -213,11 +213,11 @@ void EventSocket::onSubscribe(String event, SubscribeCallback callback)
213213
{
214214
if (!isEventValid(event))
215215
{
216-
ESP_LOGW("EventSocket", "Method tried to subscribe to unregistered event: %s", event.c_str());
216+
ESP_LOGW(TAG, "Method tried to subscribe to unregistered event: %s", event.c_str());
217217
return;
218218
}
219219
subscribe_callbacks[event].push_back(callback);
220-
ESP_LOGI("EventSocket", "onSubscribe for event: %s", event.c_str());
220+
ESP_LOGI(TAG, "onSubscribe for event: %s", event.c_str());
221221
}
222222

223223
bool EventSocket::isEventValid(String event)

lib/framework/FactoryResetService.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ void FactoryResetService::begin()
3030
HTTP_POST,
3131
_securityManager->wrapRequest(std::bind(&FactoryResetService::handleRequest, this, _1), AuthenticationPredicates::IS_ADMIN));
3232

33-
ESP_LOGV("FactoryResetService", "Registered POST endpoint: %s", FACTORY_RESET_SERVICE_PATH);
33+
ESP_LOGV(TAG, "Registered POST endpoint: %s", FACTORY_RESET_SERVICE_PATH);
3434
}
3535

3636
esp_err_t FactoryResetService::handleRequest(PsychicRequest *request)

lib/framework/FeaturesService.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ void FeaturesService::begin()
2727
createJSON(root);
2828
return response.send(); });
2929

30-
ESP_LOGV("FeaturesService", "Registered GET endpoint: %s", FEATURES_SERVICE_PATH);
30+
ESP_LOGV(TAG, "Registered GET endpoint: %s", FEATURES_SERVICE_PATH);
3131

3232
_socket->registerEvent(FEATURES_SERVICE_EVENT);
3333

3434
_socket->onSubscribe(FEATURES_SERVICE_EVENT, [&](const String &originId)
3535
{
36-
ESP_LOGV("FeaturesService", "Sending features to %s", originId.c_str());
36+
ESP_LOGV(TAG, "Sending features to %s", originId.c_str());
3737
JsonDocument doc;
3838
JsonObject root = doc.as<JsonObject>();
3939
createJSON(root);

lib/framework/HttpEndpoint.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class HttpEndpoint
7070
return response.send();
7171
},
7272
_authenticationPredicate));
73-
ESP_LOGV("HttpEndpoint", "Registered GET endpoint: %s", _servicePath.c_str());
73+
ESP_LOGV(TAG, "Registered GET endpoint: %s", _servicePath);
7474

7575
// POST
7676
_server->on(_servicePath.c_str(),
@@ -105,7 +105,7 @@ class HttpEndpoint
105105
},
106106
_authenticationPredicate));
107107

108-
ESP_LOGV("HttpEndpoint", "Registered POST endpoint: %s", _servicePath.c_str());
108+
ESP_LOGV(TAG, "Registered POST endpoint: %s", _servicePath);
109109
}
110110
};
111111

lib/framework/MqttSettingsService.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ void MqttSettingsService::onMqttConnect(bool sessionPresent)
125125
String uri = _mqttClient.getMqttConfig()->uri;
126126
#endif
127127

128-
ESP_LOGI("MQTT", "Connected to MQTT: %s", uri.c_str());
128+
ESP_LOGI(TAG, "Connected to MQTT: %s", uri.c_str());
129129
#ifdef SERIAL_INFO
130130
Serial.printf("Connected to MQTT: %s\n", uri.c_str());
131131
#endif
@@ -134,7 +134,7 @@ void MqttSettingsService::onMqttConnect(bool sessionPresent)
134134

135135
void MqttSettingsService::onMqttDisconnect(bool sessionPresent)
136136
{
137-
ESP_LOGI("MQTT", "Disconnected from MQTT.");
137+
ESP_LOGI(TAG, "Disconnected from MQTT.");
138138
#ifdef SERIAL_INFO
139139
Serial.println("Disconnected from MQTT.");
140140
#endif
@@ -145,7 +145,7 @@ void MqttSettingsService::onMqttError(esp_mqtt_error_codes_t error)
145145
if (error.error_type == MQTT_ERROR_TYPE_TCP_TRANSPORT)
146146
{
147147
_lastError = strerror(error.esp_transport_sock_errno);
148-
ESP_LOGE("MQTT", "MQTT TCP error: %s", _lastError.c_str());
148+
ESP_LOGE(TAG, "MQTT TCP error: %s", _lastError.c_str());
149149
}
150150
}
151151

@@ -158,7 +158,7 @@ void MqttSettingsService::onStationModeGotIP(WiFiEvent_t event, WiFiEventInfo_t
158158
{
159159
if (_state.enabled)
160160
{
161-
ESP_LOGI("MQTT", "WiFi connection established, starting MQTT client.");
161+
ESP_LOGI(TAG, "WiFi connection established, starting MQTT client.");
162162
onConfigUpdated();
163163
}
164164
}
@@ -167,7 +167,7 @@ void MqttSettingsService::onStationModeDisconnected(WiFiEvent_t event, WiFiEvent
167167
{
168168
if (_state.enabled)
169169
{
170-
ESP_LOGI("MQTT", "WiFi connection dropped, stopping MQTT client.");
170+
ESP_LOGI(TAG, "WiFi connection dropped, stopping MQTT client.");
171171
onConfigUpdated();
172172
}
173173
}

lib/framework/MqttStatus.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ void MqttStatus::begin()
2929
_securityManager->wrapRequest(std::bind(&MqttStatus::mqttStatus, this, std::placeholders::_1),
3030
AuthenticationPredicates::IS_AUTHENTICATED));
3131

32-
ESP_LOGV("MqttStatus", "Registered GET endpoint: %s", MQTT_STATUS_SERVICE_PATH);
32+
ESP_LOGV(TAG, "Registered GET endpoint: %s", MQTT_STATUS_SERVICE_PATH);
3333
}
3434

3535
esp_err_t MqttStatus::mqttStatus(PsychicRequest *request)

0 commit comments

Comments
 (0)