Small fixes

Author: ewowi

docs/moonlight/drivers.md

@@ -73,7 +73,7 @@ Want to add a Driver to MoonLight, see [develop](../../develop/overview/). See a
 Receives Art-Net data from the network.
 
 * DDP: If unchecked, processes data in Art-Net format, if checked, process data in DDP format
-* Port: The port listening to for Art-Net, When using DDP change 4048 is the default port for DDP.
+* Port: The port listening for Art-Net. When using DDP, change to 4048 (the default port for DDP).
 * Universe Min-Max: Filters Universes (Art-Net only).
 * View: 
     * Select physical layer to directly store the received channels into the physical layer

src/MoonBase/NodeManager.h

@@ -82,7 +82,7 @@ class NodeManager : public Module {
   template <typename T>
   Node* checkAndAlloc(const char* name) const {
     if (equalAZaz09(name, T::name())) {
-      EXT_LOGD(ML_TAG, "Allocate %d", name);
+      EXT_LOGD(ML_TAG, "Allocate %s", name);
       return allocMBObject<T>();
     } else
       return nullptr;

src/MoonLight/Modules/ModuleDrivers.h

@@ -128,7 +128,7 @@ class ModuleDrivers : public NodeManager {
     if (!node) node = checkAndAlloc<SE16Layout>(name);
 
   #if FT_LIVESCRIPT
-    else if (!node) {
+    if (!node) {
       LiveScriptNode* liveScriptNode = allocMBObject<LiveScriptNode>();
       liveScriptNode->animation = name;  // set the (file)name of the script
       node = liveScriptNode;

src/MoonLight/Modules/ModuleEffects.h

@@ -250,7 +250,7 @@ class ModuleEffects : public NodeManager {
     if (!node) node = checkAndAlloc<RippleYZModifier>(name);
 
   #if FT_LIVESCRIPT
-    else if (!node) {
+    if (!node) {
       LiveScriptNode* liveScriptNode = allocMBObject<LiveScriptNode>();
       liveScriptNode->animation = name;  // set the (file)name of the script
       node = liveScriptNode;

src/MoonLight/Nodes/Effects/E_WLED.h

@@ -811,7 +811,7 @@ class AntEffect : public Node {
 
   uint8_t antSpeed = 192;
   uint8_t nrOfAnts = MAX_ANTS / 2;
-  uint8_t antSizeControl = 32 / 255;
+  uint8_t antSizeControl = 8;
   uint8_t blur = 0;
   bool gatherFood = true;
   bool passByControl = true;
@@ -824,34 +824,15 @@ class AntEffect : public Node {
     addControl(blur, "blur", "slider");
     addControl(gatherFood, "gatherFood", "checkbox");
     addControl(passByControl, "passBy", "checkbox");
-  }
-
-  Ant* ants = nullptr;
-  // uint16_t nrOfAnts = 0;
 
-  void onSizeChanged(const Coord3D& prevSize) override {
-    Ant* newAlloc = reallocMB<Ant>(ants, MAX_ANTS);
-    if (newAlloc) {
-      ants = newAlloc;
-      // nrOfAnts = MAX_ANTS;
-    } else {
-      EXT_LOGE(ML_TAG, "(re)allocate ants failed");  // keep old (if existed)
-    }
+    initAnts();
   }
 
-  ~AntEffect() override { freeMB(ants); };
-
-  void onUpdate(const Char<20>& oldValue, const JsonObject& control) {
-    // add your custom onUpdate code here
-    if (control["name"] == "bpm") {
-      if (control["value"] == 0) {
-      }
-    }
-  }
+  Ant ants[MAX_ANTS];
 
   // Helper function to calculate ant color
   CRGB getAntColor(int antIndex, int numAnts, bool usePalette) {
-    // if (usePalette) 
+    // if (usePalette)
     return ColorFromPalette(layerP.palette, antIndex * 255 / numAnts);
     // Alternate between two colors for default palette
     // return (antIndex % 3 == 1) ? SEGCOLOR(0) : SEGCOLOR(2);
@@ -868,23 +849,22 @@ class AntEffect : public Node {
     }
   }
 
-    // Initialize ants on first call
+  // Initialize ants on first call
   void initAnts() {
-          int confusedAntIndex = random(0, numAnts);  // the first random ant to go backwards
-
-      for (int i = 0; i < MAX_ANTS; i++) {
-        ants[i].lastBumpUpdate = millis();
+    int confusedAntIndex = random(0, numAnts);  // the first random ant to go backwards
 
-        // Random velocity
-        float velocity = VELOCITY_MIN + (VELOCITY_MAX - VELOCITY_MIN) * random16(1000, 5000) / 5000.0f;
-        // One random ant moves in opposite direction
-        ants[i].velocity = (i == confusedAntIndex) ? -velocity : velocity;
-        // Random starting position (0.0 to 1.0)
-        ants[i].position = random16(0, 10000) / 10000.0f;
-        // Ants don't have food yet
-        ants[i].hasFood = false;
-      }
+    for (int i = 0; i < MAX_ANTS; i++) {
+      ants[i].lastBumpUpdate = millis();
 
+      // Random velocity
+      float velocity = VELOCITY_MIN + (VELOCITY_MAX - VELOCITY_MIN) * random16(1000, 5000) / 5000.0f;
+      // One random ant moves in opposite direction
+      ants[i].velocity = (i == confusedAntIndex) ? -velocity : velocity;
+      // Random starting position (0.0 to 1.0)
+      ants[i].position = random16(0, 10000) / 10000.0f;
+      // Ants don't have food yet
+      ants[i].hasFood = false;
+    }
   }
 
   unsigned numAnts;
@@ -958,7 +938,7 @@ class AntEffect : public Node {
       unsigned pixelPosition = roundf(newPosition * (layer->nrOfLights - 1));
 
       // Determine ant color
-      CRGB antColor = getAntColor(i, numAnts, true); //always use palette for now 
+      CRGB antColor = getAntColor(i, numAnts, true);  // always use palette for now
 
       // Render ant pixels
       for (int pixelOffset = 0; pixelOffset < antSize; pixelOffset++) {