refactor setting all channels to 0

Author: ewowi

docs/moonlight/nodes.md

@@ -75,9 +75,9 @@ MoonLight specific
     * if the loop() function contains setXXX functions is used it is an **effect** node. It will contain for-loops iterating over each virtual ! light defined by layout and modifier nodes. The iteration will be on the x-axis for 1D effects, but also on the y- and z-axis for 2D and 3D effects. setRGB is the default function setting the RGB values of the light. If a light has more 'channels' (e.g. Moving heads) they also can be set. 
 * Moving heads
     * **addLight** will show where the moving head will be on the stage. In general only an array of a few lights e.g. 4 moving heads in a row. A moving head effect will then iterate over 4 lights where each light might do something different (e.g. implement a wave of moving head movement)
-    * You need to define **channelsPerLight** in the layout node setup() - (it is default 3 to support normal LEDs). Currently MoonLight only supports identical moving heads with the same channels. The first light starts at DMX 0 (+1), the second at DMX channelsPerLight (+1) the third on DMX 2*channelsPerLight (+1) and so on. (+1): DMX typically starts at address 1 while MoonLight internal starts with 0... WIP. We are working on a solution to support different lights e.g a mix of 15 channel lights and 32 channel lights etc. You could set channelsPerLight to a higher number as the real light, e.g. 32 so each lights DMX address starts at a multiple of 32.
+    * You need to define **channelsPerLight** in the layout node setup() - (it is default 3 to support normal LEDs). Currently MoonLight only supports identical moving heads with the same channels. The first light starts at DMX 0 (+1), the second at DMX channelsPerLight (+1) the third on DMX 2*channelsPerLight (+1) and so on. (+1): DMX typically starts at address 1 while MoonLight internal starts with 0... WIP. We are working on a solution to support different lights e.g a mix of 15 channel lights and 32 channel lights etc. You could set channelsPerLight to a higher number as the real lights channels, e.g. 32 so each lights DMX address starts at a multiple of 32.
     * **Layout**: The layout node also defines which functionality / channels the light support by defining **offsets**. Currently the following offsets are supported: offsetRGB, offsetWhite, offsetBrightness, offsetPan, offsetTilt, offsetZoom, offsetRotate, offsetGobo, offsetRGB1, offsetRGB2, offsetRGB3, offsetBrightness2 and need to be set in the setup() function.
-    * The distinction between physical and virtual layer for moving heads is not useful if you have only 2-4 moving heads. However this is standard MoonLight feature. It might become useful if you have like 8 (identical) moving heads, 4 left and 4 right of the stage, then you can add a mirror modifier and the virtual layer will only control 4 lights, which then will be mapped to 8 physical lights. In theory you can also have a cube of like 512 moving heads and then exotic modifiers like pinwheel could be used to really go crazy. Let us know when you have one of these setups 🚨
+    * The distinction between physical and virtual layer for moving heads is not useful if you have only 2-4 moving heads. However this is a standard MoonLight feature. It might become useful if you have like 8 (identical) moving heads, 4 left and 4 right of the stage, then you can add a mirror modifier and the virtual layer will only control 4 lights, which then will be mapped to 8 physical lights. In theory you can also have a cube of like 512 moving heads and then exotic modifiers like pinwheel could be used to really go crazy. Let us know when you have one of these setups 🚨
     * Moving heads will be controlled using [ArtNed](https://moonmodules.org/MoonLight/moonbase/module/artnet/). addPin is not needed for moving heads, although you might want to attach LEDs for a visual view of what is send to ArtNet.
     * Effect nodes **set light**: Currently setRGB, setWhite, setBrightness, setPan, setTilt, setZoom, setRotate, setGobo, setRGB1, setRGB2, setRGB3, setBrightness2 is supported. In the background MoonLight calculates which channel need to be filled with values using the offsets (using the setLight function).
     * If offsetBrightness is defined, the RGB values will not be corrected for brightness in [ArtNed](https://moonmodules.org/MoonLight/moonbase/module/artnet/).

src/MoonLight/Nodes.h

@@ -47,7 +47,6 @@ class Node {
   virtual void setup() {
     if (hasLayout) {
       layerV->layerP->lights.header.resetOffsets(); //reset offsets to default
-      layerV->resetLights(); //all channels to 0
       layerV->requestMapPhysical = true;
       layerV->requestMapVirtual = true;
     }

src/MoonLight/PhysicalLayer.cpp

@@ -23,6 +23,7 @@ PhysicalLayer::PhysicalLayer() {
         ESP_LOGD(TAG, "constructor");
 
         lights.header.resetOffsets(); //reset the offsets to default
+        memset(lights.channels, 0, MAX_CHANNELS); // set all the channels to 0
 
         // initLightsToBlend();
 
@@ -53,6 +54,8 @@ PhysicalLayer::PhysicalLayer() {
             lights.header.size = {0,0,0};
             lights.header.isPositions = 1; //in progress...
             delay(100); //wait to stop effects
+            //set all channels to 0 (e.g for multichannel to not activate unused channels, e.g. fancy modes on MHs)
+            memset(lights.channels, 0, MAX_CHANNELS); // set all the channels to 0
             //dealloc pins
             sortedPins.clear(); //clear the added pins for the next pass
         } else if (pass == 2) {

src/MoonLight/VirtualLayer.cpp

@@ -259,16 +259,6 @@ void VirtualLayer::fadeToBlackMin() {
   }
 }
 
-void VirtualLayer::resetLights() {
-  uint8_t channels[64];
-  memset(channels, 0, sizeof(channels));
-  for (uint16_t index = 0; index < nrOfLights; index++) {
-    setLight(index, channels, 0, MIN(layerP->lights.header.channelsPerLight, 64));
-  }
-  if (layerP->lights.header.channelsPerLight > 64) 
-    ESP_LOGW(TAG, "channelsPerLight %d > 64 !", layerP->lights.header.channelsPerLight );
-}
-
 void VirtualLayer::fill_solid(const CRGB& color) {
   // if (effectDimension < projectionDimension) { //only process the effect lights (so modifiers can do things with the other dimension)
   //   for (int y=0; y < ((effectDimension == _1D)?1:size.y); y++) { //1D effects only on y=0, 2D effects loop over y

src/MoonLight/VirtualLayer.h

@@ -170,9 +170,6 @@ class VirtualLayer {
   void fadeToBlackBy(const uint8_t fadeBy);
   void fadeToBlackMin();
 
-  //set all channels to 0 (e.g for multichannel to not activate unused channels, e.g. fancy modes on MHs)
-  void resetLights();
-
   void fill_solid(const CRGB& color);
   void fill_rainbow(const uint8_t initialhue, const uint8_t deltahue);