Tuning

Author: ewowi

docs/develop/standardsguidelines.md

@@ -38,7 +38,7 @@ Github will pick up the changes so your PR stays up-to-date.
 > It has many subtle and unexpected consequences on our GitHub repository.
 > For example, we regularly lost review comments when the PR author force-pushes code changes. So, pretty please, do not force-push.
 
-You can find a collection of very useful tips and tricks here: https://github.com/wled-dev/WLED/wiki/How-to-properly-submit-a-PR
+You can find a collection of very useful tips and tricks here: [How to properly submit a PR](https://github.com/wled-dev/WLED/wiki/How-to-properly-submit-a-PR)
 
 
 ## Source Code from an AI agent or bot
@@ -52,11 +52,11 @@ You can find a collection of very useful tips and tricks here: https://github.co
 * If you don't feel very confident using English, you can use AI for translating code comments and descriptions into English. AI bots are very good at understanding language. However, always check if the results is correct. The translation might still have wrong technical terms, or errors in some details.
 
 ### best practice with AI:
-  * As the person who contributes source code to MoonLight, make sure you understand exactly what the AI-generated code does
-@@  * best practice: add a comment like ``'// below section of my code was generated by an AI``, when larger parts of your source code were not written by you personally.
-  * always review translations and code comments for correctness
-  * always review AI-generated source code
-  * If the AI has rewritten existing code, check that the change is necessary and that nothing has been lost or broken. Also check that previous code comments are still intact.
+* As the person who contributes source code to MoonLight, make sure you understand exactly what the AI-generated code does
+* best practice: add a comment like ``'// below section of my code was generated by an AI``, when larger parts of your source code were not written by you personally.
+* always review translations and code comments for correctness
+* always review AI-generated source code
+* If the AI has rewritten existing code, check that the change is necessary and that nothing has been lost or broken. Also check that previous code comments are still intact.
 
 ## Code style
 

interface/src/lib/components/moonbase/MultiRow.svelte

@@ -51,8 +51,10 @@
 	function handleReorder(reorderedItems: { item: any; originalIndex: number }[]) {
 		console.log('handleReorder', property.name, reorderedItems);
 		const full = [...data[property.name]];
+		// Capture the current filteredItems mapping before any potential state changes
+		const indexMap = filteredItems.map((f: any) => f.originalIndex);
 		reorderedItems.forEach(({ item }, pos) => {
-			const originalIndex = filteredItems[pos].originalIndex;
+			const originalIndex = indexMap[pos];
 			full[originalIndex] = item;
 		});
 		data[property.name] = full;
@@ -152,7 +154,7 @@
 <div class="h-16 flex w-full items-center justify-between space-x-3 p-0 text-xl font-medium">
 	{initCap(property.name)}
 </div>
-{#if findItemInDefinition?.crud == null || findItemInDefinition.crud.includes('c')}
+{#if findItemInDefinition?.crud == null || findItemInDefinition?.crud?.includes('c')}
 	<div class="relative w-full overflow-visible">
 		<!-- <div class="mx-4 mb-4 flex flex-wrap justify-end gap-2"> -->
 		<button
@@ -193,12 +195,12 @@
 		items={filteredItems}
 		onReorder={handleReorder}
 		class="space-y-2"
-		dragDisabled={!(findItemInDefinition?.crud == null || findItemInDefinition.crud.includes('s'))}
+		dragDisabled={!(findItemInDefinition?.crud == null || findItemInDefinition?.crud?.includes('s'))}
 	>
 		{#snippet children({ item: itemWrapper }: { item: any })}
 			<!-- svelte-ignore a11y_click_events_have_key_events -->
 			<div class="rounded-box bg-base-100 flex items-center space-x-3 px-4 py-2">
-				{#if findItemInDefinition?.crud == null || findItemInDefinition.crud.includes('s')}
+				{#if findItemInDefinition?.crud == null || findItemInDefinition?.crud?.includes('s')}
 					<Grip class="h-6 w-6 text-base-content/30 cursor-grab flex-shrink-0" />
 				{/if}
 				<!-- Show the first 3 fields -->
@@ -235,7 +237,7 @@
 						>
 							<SearchIcon class="h-6 w-6" /></button
 						>
-						{#if findItemInDefinition?.crud == null || findItemInDefinition.crud.includes('d')}
+						{#if findItemInDefinition?.crud == null || findItemInDefinition?.crud?.includes('d')}
 							<button
 								class="btn btn-ghost btn-sm"
 								onclick={() => {

src/MoonBase/Char.h

@@ -12,6 +12,7 @@
 #pragma once
 
 #include <Arduino.h>
+
 #include "ArduinoJson.h"
 
 // See https://discord.com/channels/473448917040758787/718943978636050542/1357670679196991629
@@ -57,15 +58,6 @@ struct Char {
   // Or explicit to avoid implicit conversions:
   explicit operator const char*() const { return s; }
 
-  // concat operators
-  // Char& operator+(const char* rhs) {
-  //   strlcat(s, rhs, sizeof(s));
-  //   return *this;
-  // }
-  // Char& operator+(const String& rhs) {
-  //   strlcat(s, rhs.c_str(), sizeof(s));
-  //   return *this;
-  // }
   Char operator+(const char* rhs) const {
     Char result(*this);
     result += rhs;
@@ -85,23 +77,22 @@ struct Char {
     strlcat(s, rhs.c_str(), sizeof(s));
     return *this;
   }
- template <size_t M>
+  template <size_t M>
   Char& operator+=(const Char<M>& rhs) {
     strlcat(s, rhs.c_str(), sizeof(s));
     return *this;
   }
 
-
   // compare operators
   bool operator==(const char* rhs) const { return strcmp(s, rhs) == 0; }
   bool operator==(const Char& rhs) const { return strcmp(s, rhs.s) == 0; }
   bool operator!=(const char* rhs) const { return strcmp(s, rhs) != 0; }
 
-  char operator[](const uint16_t indexV) const { return s[indexV]; }
+  char operator[](const uint16_t indexV) const { return (indexV < sizeof(s)) ? s[indexV] : '\0'; }
 
   Char<N> substring(uint16_t begin, uint16_t end = sizeof(s) - 1) {
     Char<N> sub;
-    if (begin >= sizeof(s) || end >= sizeof(s))
+    if (begin >= sizeof(s) || end >= sizeof(s) || end < begin)
       sub = "";
     else {
       strlcpy(sub.s, s + begin, end - begin + 1);