Skip to content

Commit 4521ba8

Browse files
committed
align extractModeSlider() and extractModeNames() behaviour
* document behavior * both functions are only called from usermods, and all calls are already correctly passing maxLen = buffersize -1
1 parent dab6a96 commit 4521ba8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

wled00/util.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ uint8_t extractModeName(uint8_t mode, const char *src, char *dest, uint8_t maxLe
311311
}
312312

313313

314-
// extracts effect slider data (1st group after @)
314+
// extracts effect slider data (1st group after @) -> maxLen is (buffersize - 1)
315315
uint8_t extractModeSlider(uint8_t mode, uint8_t slider, char *dest, uint8_t maxLen, uint8_t *var)
316316
{
317317
dest[0] = '\0'; // start by clearing buffer
@@ -378,7 +378,7 @@ uint8_t extractModeSlider(uint8_t mode, uint8_t slider, char *dest, uint8_t maxL
378378
case 0: strncpy_P(dest, PSTR("FX Speed"), maxLen); break;
379379
case 1: strncpy_P(dest, PSTR("FX Intensity"), maxLen); break;
380380
}
381-
dest[maxLen-1] = '\0'; // strncpy does not necessarily null terminate string
381+
dest[maxLen] = '\0'; // strncpy does not necessarily null terminate string
382382
}
383383
}
384384
return strlen(dest);

0 commit comments

Comments
 (0)