matrix: fix for a corner case (e.g. gapmaps)

softhack007 · softhack007 · commit 598e0bc06143 · 2023-09-18T15:36:34.000+02:00
workaround for a corner case; if the reference pixels falls into a "gap" then gPC returns BLACK. Solutions is to reject BLACK.
diff --git a/wled00/FX.cpp b/wled00/FX.cpp
@@ -5303,6 +5303,7 @@ uint16_t mode_2Dmatrix(void) {                  // Matrix2D. By Jeremy Williams.
         oldSpawnColor = SEGMENT.getPixelColorXY(SEGENV.aux0, SEGENV.aux1);  // find color of previous spawns
         SEGENV.aux1 ++;                                                     // our sample pixel will be one row down the next time
     }
+    if ((oldSpawnColor == CRGB::Black) || (oldSpawnColor == trailColor)) oldSpawnColor = spawnColor; // reject "black", as it would mean that ALL pixels create trails
 
     // move pixels one row down. Falling codes keep color and add trail pixels; all others pixels are faded
     for (int row=rows-1; row>=0; row--) {

Original file line number	Diff line number	Diff line change
`@@ -5303,6 +5303,7 @@ uint16_t mode_2Dmatrix(void) { // Matrix2D. By Jeremy Williams.`
`5303`	`5303`	`oldSpawnColor = SEGMENT.getPixelColorXY(SEGENV.aux0, SEGENV.aux1); // find color of previous spawns`
`5304`	`5304`	`SEGENV.aux1 ++; // our sample pixel will be one row down the next time`
`5305`	`5305`	`}`
	`5306`	`+ if ((oldSpawnColor == CRGB::Black) \|\| (oldSpawnColor == trailColor)) oldSpawnColor = spawnColor; // reject "black", as it would mean that ALL pixels create trails`
`5306`	`5307`
`5307`	`5308`	`// move pixels one row down. Falling codes keep color and add trail pixels; all others pixels are faded`
`5308`	`5309`	`for (int row=rows-1; row>=0; row--) {`