bugfix for Ripple effect (1D mode) - solves #130

softhack007 · web-flow · commit 6e2bd7780826 · 2024-04-22T18:20:18.000+02:00
bounds check on "w" was not working.
diff --git a/wled00/FX.cpp b/wled00/FX.cpp
@@ -2561,7 +2561,7 @@ uint16_t ripple_base()
           if ((v >= 0) && (v < SEGLEN))                                                // WLEDMM bugfix: v and w can be negative or out-of-range
             SEGMENT.setPixelColor(v, color_blend(SEGMENT.getPixelColor(v), col, mag)); // TODO
           int w = left + propI*2 + 3 -(v-left);
-          if ((v >= 0) && (v < SEGLEN))                                                // WLEDMM bugfix: v and w can be negative or out-of-range
+          if ((w >= 0) && (w < SEGLEN))                                                // WLEDMM bugfix: v and w can be negative or out-of-range
             SEGMENT.setPixelColor(w, color_blend(SEGMENT.getPixelColor(w), col, mag)); // TODO
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -2561,7 +2561,7 @@ uint16_t ripple_base()`
`2561`	`2561`	`if ((v >= 0) && (v < SEGLEN)) // WLEDMM bugfix: v and w can be negative or out-of-range`
`2562`	`2562`	`SEGMENT.setPixelColor(v, color_blend(SEGMENT.getPixelColor(v), col, mag)); // TODO`
`2563`	`2563`	`int w = left + propI*2 + 3 -(v-left);`
`2564`		`- if ((v >= 0) && (v < SEGLEN)) // WLEDMM bugfix: v and w can be negative or out-of-range`
	`2564`	`+ if ((w >= 0) && (w < SEGLEN)) // WLEDMM bugfix: v and w can be negative or out-of-range`
`2565`	`2565`	`SEGMENT.setPixelColor(w, color_blend(SEGMENT.getPixelColor(w), col, mag)); // TODO`
`2566`	`2566`	`}`
`2567`	`2567`	`}`