Skip to content

Commit d1d71f7

Browse files
Copilotsofthack007
andcommitted
Fix confusing exit code 1 in QEMU status check
The grep command checking for crash patterns was returning exit code 1 when no crashes were found (normal grep behavior), making it unclear what the actual failure was. Changes: - Redirect grep output to /dev/null with error suppression (> /dev/null 2>&1) - Show first 20 lines of crash patterns if found - Add clear "ERROR: HTTP server failed to start" message before exit - Better structured output for debugging This makes it clear the real failure is "HTTP server not responding" rather than the crash detection check itself. Co-authored-by: softhack007 <[email protected]>
1 parent ddd148e commit d1d71f7

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.github/workflows/qemu-e2e-test.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,15 @@ jobs:
200200
tail -200 qemu-output.log || true
201201
echo ""
202202
echo "=== Checking for ESP32 exceptions/crashes ==="
203-
if grep -i "exception\|abort\|backtrace\|panic" qemu-output.log; then
203+
if grep -i "exception\|abort\|backtrace\|panic" qemu-output.log > /dev/null 2>&1; then
204204
echo "FOUND: Firmware crash detected in QEMU output"
205+
echo ""
206+
grep -i "exception\|abort\|backtrace\|panic" qemu-output.log | head -20
205207
else
206208
echo "No obvious crash patterns found"
207209
fi
210+
echo ""
211+
echo "ERROR: HTTP server failed to start - check QEMU logs above"
208212
exit 1
209213
210214
- name: Run Playwright tests against QEMU

0 commit comments

Comments
 (0)