oappendi: fix stack corruption due to large numbers (ESP32 only)

softhack007 · softhack007 · commit d74f41d68019 · 2023-03-27T13:19:35.000+02:00
diff --git a/wled00/util.cpp b/wled00/util.cpp
@@ -139,8 +139,8 @@ void sappends(char stype, const char* key, char* val)
 
 bool oappendi(int i)
 {
-  char s[11];
-  sprintf(s, "%d", i);
+  char s[16];               // WLEDMM max 32bit integer needs 11 chars (sign + 10) not 10
+  snprintf(s, 15, "%d", i); // WLEDMM
   return oappend(s);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,8 @@ void sappends(char stype, const char* key, char* val)`
`139`	`139`
`140`	`140`	`bool oappendi(int i)`
`141`	`141`	`{`
`142`		`- char s[11];`
`143`		`- sprintf(s, "%d", i);`
	`142`	`+ char s[16]; // WLEDMM max 32bit integer needs 11 chars (sign + 10) not 10`
	`143`	`+ snprintf(s, 15, "%d", i); // WLEDMM`
`144`	`144`	`return oappend(s);`
`145`	`145`	`}`
`146`	`146`