Update usermod_PIR_sensor_switch.h - avoid starvation due to strip.isupdating()

softhack007 · web-flow · commit fdc43e0a2b96 · 2025-01-03T17:45:01.000+01:00
Another instance of the "if (strip.isupdating()) return;" problem that we inherited from upstream 🙄
diff --git a/usermods/PIR_sensor_switch/usermod_PIR_sensor_switch.h b/usermods/PIR_sensor_switch/usermod_PIR_sensor_switch.h
@@ -294,7 +294,8 @@ class PIRsensorSwitch : public Usermod
   void loop()
   {
     // only check sensors 4x/s
-    if (!enabled || millis() - lastLoop < 250 || strip.isUpdating()) return;
+    if (!enabled || millis() - lastLoop < 250) return;
+    if (strip.isUpdating() && (millis() - lastLoop < 250)) return; // WLEDMM be nice, but not too nice
     lastLoop = millis();
 
     if (!updatePIRsensorState()) {

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,8 @@ class PIRsensorSwitch : public Usermod`
`294`	`294`	`void loop()`
`295`	`295`	`{`
`296`	`296`	`// only check sensors 4x/s`
`297`		`- if (!enabled \|\| millis() - lastLoop < 250 \|\| strip.isUpdating()) return;`
	`297`	`+ if (!enabled \|\| millis() - lastLoop < 250) return;`
	`298`	`+ if (strip.isUpdating() && (millis() - lastLoop < 250)) return; // WLEDMM be nice, but not too nice`
`298`	`299`	`lastLoop = millis();`
`299`	`300`
`300`	`301`	`if (!updatePIRsensorState()) {`