style(clippy): fix all clippy lints

Author: MrDwarf7

src/cli.rs

@@ -283,14 +283,14 @@ pub async fn start(config: ConfigFile) -> Result<()> {
         Cli::Erase => erase_handler::start(config.config).await?,
         Cli::List => list_handler::start(config.config).await?,
         Cli::Complete { shell } => {
-            clap_complete::generate(shell, &mut Cli::command(), "bob", &mut std::io::stdout())
+            clap_complete::generate(shell, &mut Cli::command(), "bob", &mut std::io::stdout());
         }
         Cli::Update(data) => {
             update_handler::start(data, &client, config).await?;
         }
         Cli::ListRemote => list_remote_handler::start(config.config, client).await?,
         Cli::Run { version, args } => {
-            run_handler::start(&version, &args, &client, &config.config).await?
+            run_handler::start(&version, &args, &client, &config.config).await?;
         }
     }
 

src/github_requests.rs

@@ -212,7 +212,7 @@ pub async fn get_upstream_nightly(client: &Client) -> Result<UpstreamVersion> {
     )
     .await?;
 
-    deserialize_response(response)
+    deserialize_response(&response)
 }
 
 /// Fetches the commits for the nightly version from the GitHub API.
@@ -253,7 +253,7 @@ pub async fn get_commits_for_nightly(
     let response = make_github_request(client, format!(
             "https://api.github.com/repos/neovim/neovim/commits?since={since}&until={until}&per_page=100")).await?;
 
-    deserialize_response(response)
+    deserialize_response(&response)
 }
 
 /// Deserializes a JSON response from the GitHub API.
@@ -282,8 +282,8 @@ pub async fn get_commits_for_nightly(
 ///     Err(e) => println!("An error occurred: {:?}", e),
 /// }
 /// ```
-pub fn deserialize_response<T: DeserializeOwned>(response: String) -> Result<T> {
-    let value: serde_json::Value = serde_json::from_str(&response)?;
+pub fn deserialize_response<T: DeserializeOwned>(response: &str) -> Result<T> {
+    let value: serde_json::Value = serde_json::from_str(response)?;
 
     if value.get("message").is_some() {
         let result: ErrorResponse = serde_json::from_value(value)?;

src/handlers/erase_handler.rs

@@ -42,6 +42,7 @@ use crate::{
 ///
 /// * [`directories::get_downloads_directory`](src/helpers/directories.rs)
 /// * [`directories::get_installation_directory`](src/helpers/directories.rs)
+#[allow(clippy::items_after_statements)]
 pub async fn start(config: Config) -> Result<()> {
     let downloads = directories::get_downloads_directory(&config).await?;
     let mut installation_dir = directories::get_installation_directory(&config).await?;

src/handlers/install_handler.rs

@@ -12,6 +12,7 @@ use reqwest::Client;
 use semver::Version;
 use std::cmp::min;
 use std::env;
+use std::fmt::Write;
 use std::path::Path;
 use std::process::Stdio;
 use tokio::fs::File;
@@ -61,6 +62,7 @@ use super::{InstallResult, PostDownloadVersionType};
 /// let config = Config::default();
 /// let result = start(&mut version, &client, &config).await;
 /// ```
+#[allow(clippy::too_many_lines)]
 pub async fn start(
     version: &ParsedVersion,
     client: &Client,
@@ -108,7 +110,7 @@ pub async fn start(
 
         match config.config.enable_nightly_info {
             Some(boolean) if boolean => {
-                print_commits(client, &local_nightly, upstream_nightly).await?
+                print_commits(client, &local_nightly, upstream_nightly).await?;
             }
             None => print_commits(client, &local_nightly, upstream_nightly).await?,
             _ => (),
@@ -132,7 +134,7 @@ pub async fn start(
 
     if let PostDownloadVersionType::Standard(downloaded_archive) = downloaded_archive {
         if version.semver.is_some() && version.semver.as_ref().unwrap() <= &Version::new(0, 4, 4) {
-            unarchive::start(downloaded_archive).await?
+            unarchive::start(&downloaded_archive).await?;
         } else {
             let downloaded_checksum =
                 download_version(client, version, root, &config.config, true).await?;
@@ -147,7 +149,7 @@ pub async fn start(
                     downloaded_checksum.file_name, downloaded_checksum.file_format
                 ));
 
-                let platform = helpers::get_platform_name(&version.semver);
+                let platform = helpers::get_platform_name(version.semver.as_ref());
 
                 if !sha256cmp(
                     &archive_path,
@@ -161,10 +163,10 @@ pub async fn start(
 
                 info!("Checksum matched!");
                 tokio::fs::remove_file(checksum_path).await?;
-                unarchive::start(downloaded_archive).await?
+                unarchive::start(&downloaded_archive).await?;
             } else if let PostDownloadVersionType::None = downloaded_checksum {
                 warn!("No checksum provided, skipping checksum verification");
-                unarchive::start(downloaded_archive).await?
+                unarchive::start(&downloaded_archive).await?;
             }
         }
     }
@@ -250,8 +252,7 @@ async fn handle_rollback(config: &Config) -> Result<()> {
 
     info!("Creating rollback: nightly-{id}");
     filesystem::copy_dir_async("nightly", format!("nightly-{id}")).await?;
-
-    json_struct.tag_name += &format!("-{id}");
+    let _ = write!(json_struct.tag_name, "-{id}");
 
     let json_file = serde_json::to_string(&json_struct)?;
     fs::write(format!("nightly-{id}/bob.json"), json_file).await?;
@@ -311,7 +312,7 @@ async fn print_commits(
 /// This function sends a request to download the specified version of Neovim based on the version type.
 /// If the version type is Normal, Nightly, or Latest, it sends a request to download the version.
 /// If the version type is Hash, it handles building from the source.
-/// If the version type is NightlyRollback, it does nothing.
+/// If the version type is `NightlyRollback`, it does nothing.
 ///
 /// # Arguments
 ///
@@ -389,7 +390,7 @@ async fn download_version(
                 pbw.finish(root, file_type.clone().into());
 
                 Ok(PostDownloadVersionType::Standard(LocalVersion {
-                    file_name: version.tag_name.to_owned(),
+                    file_name: version.tag_name.clone(),
                     file_format: file_type.to_string(),
                     path: root.display().to_string(),
                     semver: version.semver.clone(),
@@ -508,6 +509,7 @@ fn file_type_ext(version: &ParsedVersion, get_sha256sum: bool) -> std::borrow::C
 /// let config = Config::default();
 /// let result = handle_building_from_source(&version, &config).await;
 /// ```
+#[allow(clippy::too_many_lines)]
 #[rustfmt::skip]
 async fn handle_building_from_source(version: &ParsedVersion, config: &Config) -> Result<PostDownloadVersionType> {
     cfg_if::cfg_if! {
@@ -560,7 +562,7 @@ async fn handle_building_from_source(version: &ParsedVersion, config: &Config) -
             std::io::ErrorKind::NotFound => {
                 fs::create_dir(dirname).await?;
             }
-            _ => return Err(anyhow!("unknown error: {}", error)),
+            _ => return Err(anyhow!("unknown error: {error}")),
         }
     }
 
@@ -575,24 +577,24 @@ async fn handle_building_from_source(version: &ParsedVersion, config: &Config) -
                     .await?;
             }
 
-            _ => return Err(anyhow!("unknown error: {}", error)),
+            _ => return Err(anyhow!("unknown error: {error}")),
         }
-    };
+    }
 
     {
 
     // check if repo has a remote
     let remote = Command::new("git").arg("remote").arg("get-url").arg("origin").stdout(Stdio::null())
         .spawn()?.wait().await?;
-    if !remote.success() {
-        // add neovim's remote
-        Command::new("git").arg("remote").arg("add").arg("origin").arg("https://github.com/neovim/neovim.git")
+    if remote.success() {
+        // set neovim's remote
+        Command::new("git").arg("remote").arg("set-url").arg("origin").arg("https://github.com/neovim/neovim.git")
             .spawn()?.wait().await?;
     } else {
-        // set neovim's remote otherwise
-        Command::new("git").arg("remote").arg("set-url").arg("origin").arg("https://github.com/neovim/neovim.git")
+        // add neovim's remote otherwise
+        Command::new("git").arg("remote").arg("add").arg("origin").arg("https://github.com/neovim/neovim.git")
             .spawn()?.wait().await?;
-    };
+    }
     // fetch version from origin
     let fetch_successful = Command::new("git").arg("fetch").arg("--depth").arg("1").arg("origin").arg(&version.non_parsed_string)
         .spawn()?.wait().await?.success();
@@ -672,7 +674,7 @@ where
 ///
 /// # Behavior
 ///
-/// The function constructs the download URL based on the provided `version` and `config.github_mirror`. If `config.github_mirror` is `None`, it defaults to "https://github.com".
+/// The function constructs the download URL based on the provided `version` and `config.github_mirror`. If `config.github_mirror` is `None`, it defaults to `<https://github.com>`.
 ///
 /// It then sends a GET request to the constructed URL with the header "user-agent" set to "bob".
 ///
@@ -702,13 +704,13 @@ async fn send_request(
     version: &ParsedVersion,
     get_sha256sum: bool,
 ) -> Result<reqwest::Response, reqwest::Error> {
-    let platform = helpers::get_platform_name(&version.semver);
+    let platform = helpers::get_platform_name(version.semver.as_ref());
     let file_type = crate::FILETYPE_EXT;
 
-    let url = config
-        .github_mirror
-        .as_ref()
-        .map_or_else(|| "https://github.com".to_string(), |val| val.to_string());
+    let url = config.github_mirror.as_ref().map_or_else(
+        || "https://github.com".to_string(),
+        std::string::ToString::to_string,
+    );
 
     let version_tag = &version.tag_name;
     let request_url = if get_sha256sum {

src/handlers/list_remote_handler.rs

@@ -65,7 +65,7 @@ pub async fn start(config: Config, client: Client) -> Result<()> {
         .map(|entry| entry.path())
         .collect();
 
-    let versions: Vec<RemoteVersion> = deserialize_response(response)?;
+    let versions: Vec<RemoteVersion> = deserialize_response(&response)?;
     let filtered_versions: Vec<RemoteVersion> = versions
         .into_iter()
         .filter(|v| v.name.starts_with('v'))
@@ -109,9 +109,8 @@ pub async fn start(config: Config, client: Client) -> Result<()> {
         if let Err(e) = write_result {
             if e.kind() == io::ErrorKind::BrokenPipe {
                 return Ok(());
-            } else {
-                return Err(e.into());
             }
+            return Err(e.into());
         }
 
         if version_installed {