feat: Added (again) self-check option in settings to see and configure app permissions

Patched apps checks: Check currently installed apps that are running with microG. Also detect whether apps use Morphe patches based on package name detection.

Permissions checks: Verify whether essential microG special permissions are granted.

System checks: Verify that the system is correctly configured to run microG, specifically background services.

Author: WSTxda

play-services-core/microg-ui-tools/src/main/java/org/microg/tools/selfcheck/SelfCheckGroup.java

@@ -17,18 +17,19 @@
 package org.microg.tools.selfcheck;
 
 import android.content.Context;
-
 import androidx.fragment.app.Fragment;
+import org.microg.tools.ui.AbstractSelfCheckFragment.ChipInfo;
+import java.util.List;
 
 public interface SelfCheckGroup {
     String getGroupName(Context context);
 
     void doChecks(Context context, ResultCollector collector);
 
     interface ResultCollector {
-        void addResult(String name, Result value, String resolution);
-
-        void addResult(String name, Result value, String resolution, CheckResolver resolver);
+        void addResult(String name, Result result, String resolution);
+        void addResult(String name, Result result, String resolution, CheckResolver resolver);
+        void addResult(String name, Result result, String resolution, boolean showIcon, List<ChipInfo> chips, CheckResolver resolver);
     }
 
     interface CheckResolver {

play-services-core/microg-ui-tools/src/main/java/org/microg/tools/ui/AbstractSelfCheckFragment.java

@@ -16,61 +16,89 @@
 
 package org.microg.tools.ui;
 
+import android.content.Intent;
+import android.graphics.drawable.Drawable;
 import android.os.Bundle;
-import android.view.MotionEvent;
-import android.util.Log;
+import android.text.Html;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
-import android.widget.CheckBox;
+import android.widget.ImageView;
 import android.widget.TextView;
 
+import androidx.activity.result.ActivityResultLauncher;
+import androidx.activity.result.contract.ActivityResultContracts;
 import androidx.annotation.Nullable;
 import androidx.fragment.app.Fragment;
 
+import com.google.android.material.chip.Chip;
+import com.google.android.material.chip.ChipGroup;
+import com.google.android.material.transition.platform.MaterialSharedAxis;
+
 import org.microg.tools.selfcheck.SelfCheckGroup;
 
 import java.util.ArrayList;
 import java.util.List;
 
 import static android.view.View.GONE;
+import static android.view.View.VISIBLE;
 import static android.view.View.INVISIBLE;
 import static org.microg.tools.selfcheck.SelfCheckGroup.Result.Negative;
 import static org.microg.tools.selfcheck.SelfCheckGroup.Result.Positive;
 import static org.microg.tools.selfcheck.SelfCheckGroup.Result.Unknown;
 
 public abstract class AbstractSelfCheckFragment extends Fragment {
-    private static final String TAG = "SelfCheck";
-
     private ViewGroup root;
+    protected ActivityResultLauncher<Intent> resolutionLauncher;
+    protected ActivityResultLauncher<String[]> permissionsLauncher;
+
+    public static class ChipInfo {
+        public String label;
+        public Drawable icon;
+        public View.OnClickListener onClick;
+
+        public ChipInfo(String label, Drawable icon, View.OnClickListener onClick) {
+            this.label = label;
+            this.icon = icon;
+            this.onClick = onClick;
+        }
+    }
+
+    @Override
+    public void onCreate(Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);
+        resolutionLauncher = registerForActivityResult(new ActivityResultContracts.StartActivityForResult(), r -> reset(LayoutInflater.from(getContext())));
+        permissionsLauncher = registerForActivityResult(new ActivityResultContracts.RequestMultiplePermissions(), r -> reset(LayoutInflater.from(getContext())));
+
+        setEnterTransition(new MaterialSharedAxis(MaterialSharedAxis.X, true));
+        setExitTransition(new MaterialSharedAxis(MaterialSharedAxis.X, true));
+    }
+
+    public void launchIntent(Intent intent) {
+        resolutionLauncher.launch(intent);
+    }
 
     @Nullable
     @Override
     public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
-        View scrollRoot = inflater.inflate(R.layout.self_check, container, false);
-        root = scrollRoot.findViewById(R.id.self_check_root);
+        View scrollRoot = inflater.inflate(org.microg.tools.ui.R.layout.self_check, container, false);
+        root = scrollRoot.findViewById(org.microg.tools.ui.R.id.self_check_root);
         reset(inflater);
         return scrollRoot;
     }
 
     protected abstract void prepareSelfCheckList(List<SelfCheckGroup> checks);
 
     protected void reset(LayoutInflater inflater) {
+        if (root == null) return;
         List<SelfCheckGroup> selfCheckGroupList = new ArrayList<>();
         prepareSelfCheckList(selfCheckGroupList);
-
         root.removeAllViews();
         for (SelfCheckGroup group : selfCheckGroupList) {
-            View groupView = inflater.inflate(R.layout.self_check_group, root, false);
+            View groupView = inflater.inflate(org.microg.tools.ui.R.layout.self_check_group, root, false);
             ((TextView) groupView.findViewById(android.R.id.title)).setText(group.getGroupName(getContext()));
-            final ViewGroup viewGroup = groupView.findViewById(R.id.group_content);
-            final SelfCheckGroup.ResultCollector collector = new GroupResultCollector(viewGroup);
-            try {
-                group.doChecks(getContext(), collector);
-            } catch (Exception e) {
-                Log.w(TAG, "Failed during check " + group.getGroupName(getContext()), e);
-                collector.addResult("Self-check failed:", Negative, "An exception occurred during self-check. Please report this issue.");
-            }
+            final ViewGroup viewGroup = groupView.findViewById(org.microg.tools.ui.R.id.group_content);
+            group.doChecks(getContext(), new GroupResultCollector(viewGroup));
             root.addView(groupView);
         }
     }
@@ -83,56 +111,80 @@ public GroupResultCollector(ViewGroup viewGroup) {
         }
 
         @Override
-        public void addResult(final String name, final SelfCheckGroup.Result result, final String resolution) {
-            addResult(name, result, resolution, null);
+        public void addResult(String name, SelfCheckGroup.Result result, String resolution) {
+            addResult(name, result, resolution, true, null, null);
         }
 
         @Override
-        public void addResult(final String name, final SelfCheckGroup.Result result, final String resolution, final SelfCheckGroup.CheckResolver resolver) {
-            if (result == null || getActivity() == null) return;
-            getActivity().runOnUiThread(() -> {
-                View resultEntry = LayoutInflater.from(getContext()).inflate(R.layout.self_check_entry, viewGroup, false);
+        public void addResult(String name, SelfCheckGroup.Result result, String resolution, SelfCheckGroup.CheckResolver resolver) {
+            addResult(name, result, resolution, true, null, resolver);
+        }
 
-                TextView nameView = resultEntry.findViewById(R.id.self_check_name);
-                TextView resolutionView = resultEntry.findViewById(R.id.self_check_resolution);
-                CheckBox checkBox = resultEntry.findViewById(R.id.self_check_result);
-                resultEntry.findViewById(R.id.list_item_check);
+        @Override
+        public void addResult(String name, SelfCheckGroup.Result result, String resolution, boolean showIcon, List<ChipInfo> chips, SelfCheckGroup.CheckResolver resolver) {
+            if (getActivity() == null || getContext() == null) return;
+            getActivity().runOnUiThread(() -> {
+                View entry = LayoutInflater.from(getContext()).inflate(org.microg.tools.ui.R.layout.self_check_entry, viewGroup, false);
+                TextView nameView = entry.findViewById(org.microg.tools.ui.R.id.self_check_name);
+                TextView resView = entry.findViewById(org.microg.tools.ui.R.id.self_check_resolution);
+                ImageView resultIcon = entry.findViewById(org.microg.tools.ui.R.id.self_check_result_icon);
+                ChipGroup chipGroup = entry.findViewById(org.microg.tools.ui.R.id.self_check_chip_group);
 
                 nameView.setText(name);
 
-                resultEntry.findViewById(R.id.self_check_result).setOnTouchListener((v, event) -> {
-                    if (event.getAction() == MotionEvent.ACTION_UP) {
-                        if (event.getX() >= 0 && event.getX() <= v.getWidth() && event.getY() >= 0 && event.getY() <= v.getHeight()) {
-                            v.performClick();
-                        }
+                if (showIcon) {
+                    resultIcon.setVisibility(VISIBLE);
+                    if (result == Positive) {
+                        resultIcon.setActivated(true);
+                    } else if (result == Negative) {
+                        resultIcon.setActivated(false);
+                    } else {
+                        resultIcon.setVisibility(INVISIBLE);
                     }
-                    return true;
-                });
+                } else {
+                    resultIcon.setVisibility(GONE);
+                }
 
                 if (result == Positive) {
-                    checkBox.setChecked(true);
-                    resolutionView.setVisibility(GONE);
+                    resView.setVisibility(GONE);
                 } else {
-                    resolutionView.setText(resolution);
-                    if (result == Unknown) {
-                        checkBox.setVisibility(INVISIBLE);
-                    }
+                    resView.setVisibility(VISIBLE);
+                    resView.setText(Html.fromHtml(resolution, Html.FROM_HTML_MODE_COMPACT));
                     if (resolver != null) {
-                        resultEntry.setClickable(true);
-                        resultEntry.setOnClickListener(v -> resolver.tryResolve(AbstractSelfCheckFragment.this));
+                        entry.setClickable(true);
+                        entry.setOnClickListener(v -> resolver.tryResolve(AbstractSelfCheckFragment.this));
                     }
                 }
 
-                viewGroup.addView(resultEntry);
-
-                for (int i = 0; i < viewGroup.getChildCount(); i++) {
-                    View child = viewGroup.getChildAt(i);
-                    com.google.android.material.listitem.ListItemLayout layout = child.findViewById(R.id.list_item_check);
-                    if (layout != null) {
-                        layout.updateAppearance(i, viewGroup.getChildCount());
+                if (chips != null && !chips.isEmpty()) {
+                    chipGroup.setVisibility(VISIBLE);
+                    chipGroup.removeAllViews();
+                    for (ChipInfo info : chips) {
+                        Chip chip = (Chip) LayoutInflater.from(getContext()).inflate(org.microg.tools.ui.R.layout.self_check_chip, chipGroup, false);
+                        chip.setText(info.label);
+                        if (info.icon != null) {
+                            chip.setChipIcon(info.icon);
+                            chip.setChipIconVisible(true);
+                        }
+                        if (info.onClick != null) {
+                            chip.setOnClickListener(info.onClick);
+                        }
+                        chipGroup.addView(chip);
                     }
                 }
+
+                viewGroup.addView(entry);
+                updateSegmentedStyle();
             });
         }
+
+        private void updateSegmentedStyle() {
+            for (int i = 0; i < viewGroup.getChildCount(); i++) {
+                View child = viewGroup.getChildAt(i);
+                if (child instanceof com.google.android.material.listitem.ListItemLayout) {
+                    ((com.google.android.material.listitem.ListItemLayout) child).updateAppearance(i, viewGroup.getChildCount());
+                }
+            }
+        }
     }
 }

play-services-core/microg-ui-tools/src/main/res/drawable/ic_allow.xml

@@ -0,0 +1,10 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:tint="?attr/colorPrimary"
+    android:viewportWidth="960"
+    android:viewportHeight="960">
+    <path
+        android:fillColor="@android:color/white"
+        android:pathData="M424,552L338,466Q327,455 310,455Q293,455 282,466Q271,477 271,494Q271,511 282,522L396,636Q408,648 424,648Q440,648 452,636L678,410Q689,399 689,382Q689,365 678,354Q667,343 650,343Q633,343 622,354L424,552ZM480,880Q397,880 324,848.5Q251,817 197,763Q143,709 111.5,636Q80,563 80,480Q80,397 111.5,324Q143,251 197,197Q251,143 324,111.5Q397,80 480,80Q563,80 636,111.5Q709,143 763,197Q817,251 848.5,324Q880,397 880,480Q880,563 848.5,636Q817,709 763,763Q709,817 636,848.5Q563,880 480,880Z" />
+</vector>

play-services-core/microg-ui-tools/src/main/res/drawable/ic_deny.xml

@@ -0,0 +1,10 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:tint="?attr/colorError"
+    android:viewportWidth="960"
+    android:viewportHeight="960">
+    <path
+        android:fillColor="@android:color/white"
+        android:pathData="M480,536L596,652Q607,663 624,663Q641,663 652,652Q663,641 663,624Q663,607 652,596L536,480L652,364Q663,353 663,336Q663,319 652,308Q641,297 624,297Q607,297 596,308L480,424L364,308Q353,297 336,297Q319,297 308,308Q297,319 297,336Q297,353 308,364L424,480L308,596Q297,607 297,624Q297,641 308,652Q319,663 336,663Q353,663 364,652L480,536ZM480,880Q397,880 324,848.5Q251,817 197,763Q143,709 111.5,636Q80,563 80,480Q80,397 111.5,324Q143,251 197,197Q251,143 324,111.5Q397,80 480,80Q563,80 636,111.5Q709,143 763,197Q817,251 848.5,324Q880,397 880,480Q880,563 848.5,636Q817,709 763,763Q709,817 636,848.5Q563,880 480,880Z" />
+</vector>

play-services-core/microg-ui-tools/src/main/res/drawable/ic_self_check_open.xml

@@ -0,0 +1,11 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:autoMirrored="true"
+    android:tint="?attr/colorOnPrimaryContainer"
+    android:viewportWidth="960"
+    android:viewportHeight="960">
+    <path
+        android:fillColor="@android:color/white"
+        android:pathData="M200,840Q167,840 143.5,816.5Q120,793 120,760L120,200Q120,167 143.5,143.5Q167,120 200,120L440,120Q457,120 468.5,131.5Q480,143 480,160Q480,177 468.5,188.5Q457,200 440,200L200,200Q200,200 200,200Q200,200 200,200L200,760Q200,760 200,760Q200,760 200,760L760,760Q760,760 760,760Q760,760 760,760L760,520Q760,503 771.5,491.5Q783,480 800,480Q817,480 828.5,491.5Q840,503 840,520L840,760Q840,793 816.5,816.5Q793,840 760,840L200,840ZM760,256L416,600Q405,611 388,611Q371,611 360,600Q349,589 349,572Q349,555 360,544L704,200L600,200Q583,200 571.5,188.5Q560,177 560,160Q560,143 571.5,131.5Q583,120 600,120L800,120Q817,120 828.5,131.5Q840,143 840,160L840,360Q840,377 828.5,388.5Q817,400 800,400Q783,400 771.5,388.5Q760,377 760,360L760,256Z" />
+</vector>

play-services-core/microg-ui-tools/src/main/res/drawable/ic_self_check_result.xml

@@ -0,0 +1,4 @@
+<selector xmlns:android="http://schemas.android.com/apk/res/android">
+    <item android:drawable="@drawable/ic_allow" android:state_activated="true" />
+    <item android:drawable="@drawable/ic_deny" />
+</selector>

play-services-core/microg-ui-tools/src/main/res/layout/self_check_chip.xml

@@ -0,0 +1,8 @@
+<com.google.android.material.chip.Chip xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
+    style="@style/Widget.Material3.Chip.Assist"
+    android:layout_width="wrap_content"
+    android:layout_height="wrap_content"
+    android:textColor="?attr/colorOnSecondaryContainer"
+    app:chipBackgroundColor="?attr/colorSecondaryContainer"
+    app:chipStrokeWidth="0dp" />

play-services-core/microg-ui-tools/src/main/res/layout/self_check_entry.xml

@@ -12,23 +12,23 @@
         android:id="@+id/material_card_view"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:checkable="false"
         app:cardBackgroundColor="?attr/colorSurfaceContainer">
 
         <androidx.constraintlayout.widget.ConstraintLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:paddingVertical="?attr/listPreferredItemPaddingEnd"
+            android:paddingVertical="16dp"
             android:paddingStart="?attr/listPreferredItemPaddingStart"
-            android:paddingEnd="8dp">
+            android:paddingEnd="?attr/listPreferredItemPaddingEnd">
 
             <com.google.android.material.textview.MaterialTextView
                 android:id="@+id/self_check_name"
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
+                android:maxLines="2"
                 android:textAppearance="?attr/textAppearanceTitleMedium"
                 app:layout_constraintBottom_toTopOf="@+id/self_check_resolution"
-                app:layout_constraintEnd_toStartOf="@+id/self_check_result"
+                app:layout_constraintEnd_toStartOf="@+id/self_check_result_icon"
                 app:layout_constraintHorizontal_chainStyle="spread"
                 app:layout_constraintStart_toStartOf="parent"
                 app:layout_constraintTop_toTopOf="parent"
@@ -39,20 +39,35 @@
                 android:id="@+id/self_check_resolution"
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
+                android:layout_marginTop="2dp"
+                android:maxLines="10"
                 android:textAppearance="?attr/textAppearanceBodyMedium"
                 android:textColor="?android:textColorSecondary"
-                app:layout_constraintBottom_toBottomOf="parent"
+                app:layout_constraintBottom_toTopOf="@+id/self_check_chip_group"
                 app:layout_constraintEnd_toEndOf="@id/self_check_name"
                 app:layout_constraintStart_toStartOf="@id/self_check_name"
                 app:layout_constraintTop_toBottomOf="@id/self_check_name"
                 tools:text="@string/self_check_desc" />
 
-            <com.google.android.material.checkbox.MaterialCheckBox
-                android:id="@+id/self_check_result"
+            <com.google.android.material.chip.ChipGroup
+                android:id="@+id/self_check_chip_group"
+                android:layout_width="0dp"
+                android:layout_height="wrap_content"
+                android:layout_marginTop="8dp"
+                android:visibility="gone"
+                app:chipSpacingVertical="4dp"
+                app:layout_constraintBottom_toBottomOf="parent"
+                app:layout_constraintEnd_toEndOf="@id/self_check_name"
+                app:layout_constraintStart_toStartOf="@id/self_check_name"
+                app:layout_constraintTop_toBottomOf="@id/self_check_resolution" />
+
+            <com.google.android.material.imageview.ShapeableImageView
+                android:id="@+id/self_check_result_icon"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:clickable="false"
-                android:focusable="false"
+                android:importantForAccessibility="no"
+                android:paddingStart="8dp"
+                android:src="@drawable/ic_self_check_result"
                 app:layout_constraintBottom_toBottomOf="parent"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintTop_toTopOf="parent" />