bug: Failed to purge temporary files

[cyberboh]

Bug description

--purge flag is not working properly. CLI still can not purge temporary files

Error logs

INFO: Compiling modified resources
INFO: Running string unescape processing
INFO: Running post-processing steps for package renaming
INFO: Processing aapt macros
INFO: Generating new resource IDs
INFO: Writing resource APK
INFO: Aligning APK
INFO: Signing APK
INFO: Saved to E:\ANDROID\APPS\Morphe\Install\YouTube_Music_Morphe_9.08.51-arm64-v8a.apk
INFO: Purging temporary files
INFO: Failed to purge resource cache directory

Solution

There is a PR on RV cli but closed, maybe he can help ReVanced/revanced-cli#332 @lorenzoverardo

Related issue on RV CLI ReVanced/revanced-cli#327

Additional context

No response

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.

[prateek-who]

Checked the PRs you linked. The issues seems to be that the streams don't get closed hence it fails to delete the temp files, right?

[prateek-who]

@hoo-dles made a fix for this on revanced. What was the better solution? Was it better to point to a file or closing the stream upstream in the patcher instead of the cli?

[hoo-dles]

These were the 2 relevant PRs I made:

• fix: Close streams to be able to delete cache folder ReVanced/revanced-library#70
• fix: Replace dex input streams with file references ReVanced/revanced-patcher#343

Osum decided not to merge it for his own reasons at the time. But then decided to implement into dev anyway? 🤷‍♂️

[LisoUseInAIKyrios]

Please open pull requests here for your fixes.

[hoo-dles]

@LisoUseInAIKyrios This is the simplest fix: MorpheApp/morphe-library#26

I still think it's better to pass around a File descriptor instead of an active stream, but that's a design decision.

[LisoUseInAIKyrios]

Try with v1.5.0-dev.6 and verify if it's fixed

[cyberboh]

Still error, full log below:

E:\ANDROID\APPS\Morphe>java -jar "morphe-cli-1.5.0-dev.6-all.jar" patch --patches "patches-1.16.0-dev.2.mpp" --keystore-entry-alias="null" --keystore-password="null" --keystore-entry-password="null" --keystore="null.keystore" --options-file "options.json" "Apps\com.google.android.apps.youtube.music-9.08.51-arm64-v8a.apk" --out "Install\YouTube_Music_Morphe_9.08.51-arm64-v8a.apk" --force --purge
INFO: Loading patches
INFO: Reading options from options.json
INFO: Setting patch options
INFO: "Override certificate pinning" disabled via options file
INFO: "Change package name" disabled via options file
INFO: Decoding all resources
INFO: Sanitizing unpatched strings
INFO: Escaping unpatched strings
INFO: Executing patches
INFO: "Bypass certificate checks" succeeded
INFO: "Change miniplayer color" succeeded
INFO: "Check watch history domain name resolution" succeeded
INFO: "Disable DRC audio" succeeded
INFO: "Disable QUIC protocol" succeeded
INFO: "Enable debugging" succeeded
INFO: "Enable exclusive audio playback" succeeded
INFO: "Force original audio" succeeded
INFO: "GmsCore support" succeeded
INFO: "Hide 'Get Music Premium'" succeeded
INFO: "Hide buttons" succeeded
INFO: "Hide category bar" succeeded
INFO: "Hide music video ads" succeeded
INFO: "Navigation bar" succeeded
INFO: "Permanent repeat" succeeded
INFO: "Remove background playback restrictions" succeeded
INFO: "Sanitize sharing links" succeeded
INFO: "Theme" succeeded
INFO: "Custom branding" succeeded
INFO: Compiling patched dex files
INFO: Compiled classes.dex
INFO: Compiled classes2.dex
INFO: Compiled classes3.dex
INFO: Compiled classes4.dex
INFO: Compiled classes5.dex
INFO: Compiled classes6.dex
INFO: Compiled classes7.dex
INFO: Compiled classes8.dex
INFO: Compiling modified resources
INFO: Unescaping strings
INFO: Post-processing package name change
INFO: Processing aapt macros
[Fatal Error] :1501:890: Invalid byte 3 of 3-byte UTF-8 sequence.
SEVERE: An unexpected error occurred: Invalid byte 3 of 3-byte UTF-8 sequence.
org.xml.sax.SAXParseException; lineNumber: 1501; columnNumber: 890; Invalid byte 3 of 3-byte UTF-8 sequence.
        at java.xml/com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:263)
        at java.xml/com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:342)
        at java.xml/javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:122)
        at app.morphe.patcher.util.Document.<init>(Document.kt:15)
        at app.morphe.patcher.util.Document.<init>(Document.kt:22)
        at app.morphe.patcher.resource.processor.AaptMacroProcessor.processDocument(AaptMacroProcessor.kt:73)
        at app.morphe.patcher.resource.processor.AaptMacroProcessor.process(AaptMacroProcessor.kt:48)
        at app.morphe.patcher.resource.coder.ArsclibResourceCoder.encodeResources(ArsclibResourceCoder.kt:155)
        at app.morphe.patcher.patch.ResourcePatchContext.get(ResourcePatchContext.kt:84)
        at app.morphe.patcher.Patcher.get(Patcher.kt:165)
        at app.morphe.cli.command.PatchCommand.call(PatchCommand.kt:591)
        at app.morphe.cli.command.PatchCommand.call(PatchCommand.kt:49)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2031)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2469)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2423)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2425)
        at picocli.CommandLine.execute(CommandLine.java:2174)
        at app.morphe.cli.command.MainCommandKt.main(MainCommand.kt:14)
Caused by: com.sun.org.apache.xerces.internal.impl.io.MalformedByteSequenceException: Invalid byte 3 of 3-byte UTF-8 sequence.
        at java.xml/com.sun.org.apache.xerces.internal.impl.io.UTF8Reader.invalidByte(UTF8Reader.java:702)
        at java.xml/com.sun.org.apache.xerces.internal.impl.io.UTF8Reader.read(UTF8Reader.java:436)
        at java.xml/com.sun.org.apache.xerces.internal.impl.XMLEntityScanner.load(XMLEntityScanner.java:1699)
        at java.xml/com.sun.org.apache.xerces.internal.impl.XMLEntityScanner.skipChar(XMLEntityScanner.java:1375)
        at java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2762)
        at java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:605)
        at java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:542)
        at java.xml/com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:889)
        at java.xml/com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:825)
        at java.xml/com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
        at java.xml/com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:247)
        ... 20 more
INFO: Purging temporary files
INFO: Failed to purge resource cache directory

[cyberboh]

Here my java version:

E:\ANDROID\APPS\Morphe>java -version
openjdk version "17.0.18" 2026-01-20 LTS
OpenJDK Runtime Environment Zulu17.64+15-CA (build 17.0.18+8-LTS)
OpenJDK 64-Bit Server VM Zulu17.64+15-CA (build 17.0.18+8-LTS, mixed mode, sharing)

[hoo-dles]

@LisoUseInAIKyrios any chance that @cyberboh patching error throws an exception before the stream is allowed to close?

@cyberboh Does it still fail on purging if you apply a patch that applies successfully?

[wchill]

The fix for the UTF-8 issue is in MorpheApp/morphe-patcher#58.

It also addresses a file reader leak I found that is likely the cause for the failure to purge.

[cyberboh]

@cyberboh Does it still fail on purging if you apply a patch that applies successfully?

I can not test it, fix was applied in dev.6. CLI dev.4 and upper I got error [Fatal Error] :1501:890: Invalid byte 3 of 3-byte UTF-8 sequence.
So, all patches can not be applied.

[wchill]

@cyberboh 1.2.0-dev.7 should include the necessary fixes, can you check again

[cyberboh]

@cyberboh 1.2.0-dev.7 should include the necessary fixes, can you check again

Thank you for quick fix. dev.7 working fine now. No any single error appear. Great job. Long live Morphe. ❤️

PS E:\ANDROID\APPS\Morphe> java -jar "morphe-cli-1.5.0-dev.7-all.jar" patch --patches "patches-1.16.0-dev.3.mpp" --keystore-entry-alias="null" --keystore-password="null" --keystore-entry-password="null" --keystore="null.keystore" --options-file "options.json" "Apps\com.google.android.youtube-21.08.271-all.apk" --out "Install\YouTube_Morphe_21.08.271-arm64-v8a.apk" --force --purge --striplibs "arm64-v8a"
INFO: Loading patches
INFO: Reading options from options.json
INFO: Setting patch options
INFO: "Override certificate pinning" disabled via options file
INFO: "Change package name" disabled via options file
INFO: Decoding all resources
INFO: Sanitizing unpatched strings
INFO: Escaping unpatched strings
INFO: Executing patches
INFO: "Alternative thumbnails" succeeded
INFO: "Ambient mode" succeeded
INFO: "Bypass URL redirects" succeeded
INFO: "Bypass image region restrictions" succeeded
INFO: "Captions" succeeded
INFO: "Change form factor" succeeded
INFO: "Change header" succeeded
INFO: "Change start page" succeeded
INFO: "Check watch history domain name resolution" succeeded
INFO: "Copy video URL" succeeded
INFO: "Custom player overlay opacity" succeeded
INFO: "Disable DRC audio" succeeded
INFO: "Disable QUIC protocol" succeeded
INFO: "Disable double tap actions" succeeded
INFO: "Disable haptic feedback" succeeded
INFO: "Disable layout updates" succeeded
INFO: "Disable player popup panels" succeeded
INFO: "Disable resuming Shorts on startup" succeeded
INFO: "Disable rolling number animations" succeeded
INFO: "Disable sign in to TV popup" succeeded
INFO: "Disable video codecs" succeeded
INFO: "Double tap to seek" succeeded
INFO: "Downloads" succeeded
INFO: "Enable debugging" succeeded
INFO: "Exit fullscreen mode" succeeded
INFO: "Force original audio" succeeded
INFO: "GmsCore support" succeeded
INFO: "Hide Shorts components" succeeded
INFO: "Hide ads" succeeded
INFO: "Hide autoplay preview" succeeded
INFO: "Hide end screen cards" succeeded
INFO: "Hide end screen suggested video" succeeded
INFO: "Hide info cards" succeeded
INFO: "Hide layout components" succeeded
INFO: "Hide player flyout menu items" succeeded
INFO: "Hide player overlay buttons" succeeded
INFO: "Hide related video overlay" succeeded
INFO: "Hide timestamp" succeeded
INFO: "Hide video action buttons" succeeded
INFO: "Loop video" succeeded
INFO: "Miniplayer" succeeded
INFO: "Navigation bar" succeeded
INFO: "Open Shorts in regular player" succeeded
INFO: "Open links externally" succeeded
INFO: "Open system share sheet" succeeded
INFO: "Open videos fullscreen" succeeded
INFO: "Playback speed" succeeded
INFO: "Remove background playback restrictions" succeeded
INFO: "Remove viewer discretion dialog" succeeded
INFO: "Return YouTube Dislike" succeeded
INFO: "Sanitize sharing links" succeeded
INFO: "Seekbar" succeeded
INFO: "Shorts autoplay" succeeded
INFO: "SponsorBlock" succeeded
INFO: "Spoof app version" succeeded
INFO: "Spoof device dimensions" succeeded
INFO: "Swipe controls" succeeded
INFO: "Theme" succeeded
INFO: "Video ads" succeeded
INFO: "Video quality" succeeded
INFO: "Custom branding" succeeded
INFO: Compiling patched dex files
INFO: Compiled classes.dex
INFO: Compiled classes2.dex
INFO: Compiled classes3.dex
INFO: Compiled classes4.dex
INFO: Compiled classes5.dex
INFO: Compiled classes6.dex
INFO: Compiled classes7.dex
INFO: Compiled classes8.dex
INFO: Compiled classes9.dex
INFO: Compiled classes10.dex
INFO: Compiled classes11.dex
INFO: Compiling modified resources
INFO: Unescaping strings
INFO: Post-processing package name change
INFO: Processing aapt macros
INFO: Generating new resource IDs
INFO: Writing resource APK
INFO: Aligning APK
INFO: Kept [arm64-v8a], stripped 90 native library files
INFO: Signing APK
INFO: Saved to E:\ANDROID\APPS\Morphe\Install\YouTube_Morphe_21.08.271-arm64-v8a.apk
INFO: Purging temporary files
INFO: Purged resource cache directory
PS E:\ANDROID\APPS\Morphe>

[wchill]

Will close this then, since bug was reported on dev branch