Skip to content

Commit 8c77362

Browse files
committed
Missed some line_terminator replacements.
1 parent caa364d commit 8c77362

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/academic_tracker/ref_srch_emails_and_reports.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ def create_tabular_report(publication_dict, config_dict, is_citation_in_prev_pub
234234
df = df[column_order]
235235

236236
if file_format == "csv":
237-
report = df.to_csv(index=False, sep=separator, line_terminator="\n")
237+
report = df.to_csv(index=False, sep=separator, lineterminator="\n")
238238
fileio.save_string_to_file(save_dir_name, filename, report)
239239
else:
240240
## If the file extension isn't .xlsx then there will be an error, so force it.

tests/test_athr_srch_emails_and_reports.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ def test_create_tabular_collaborator_report(publication_dict, config_dict_collab
262262

263263
df = pandas.read_csv(os.path.join(TESTING_DIR, filename), sep=sep)
264264
report_text = read_text_from_txt(os.path.join(TESTING_DIR, filename))
265-
assert df.to_csv(sep=sep, index=False, line_terminator="\n") == report_text
265+
assert df.to_csv(sep=sep, index=False, lineterminator="\n") == report_text
266266
assert list(df.columns) == config_dict_collab["Authors"]["Anna Hoover"]["collaborator_report"]["column_order"]
267267
assert df.iloc[1].loc["Col1"] == column_one
268268
assert df.iloc[0].loc["Col2"] == "asdf"
@@ -281,7 +281,7 @@ def test_create_tabular_collaborator_report_defaults(publication_dict):
281281

282282
df = pandas.read_csv(os.path.join(TESTING_DIR, "test_name.csv"), sep=",")
283283
report_text = read_text_from_txt(os.path.join(TESTING_DIR, "test_name.csv"))
284-
assert df.to_csv(sep=",", index=False, line_terminator="\n") == report_text
284+
assert df.to_csv(sep=",", index=False, lineterminator="\n") == report_text
285285
assert list(df.columns) == ["Name", "Affiliations"]
286286
assert df.iloc[0].loc["Name"] == 'Brewer, Dawn'
287287
assert df.iloc[0].loc["Affiliations"] == 'University of Kentucky Department of Dietetics and Human Nutrition.'
@@ -348,7 +348,7 @@ def test_create_tabular_summary_report_no_pub_keywords(publication_dict, config_
348348

349349
df = pandas.read_csv(os.path.join(TESTING_DIR, "test_name.csv"), sep="\t")
350350
report_text = read_text_from_txt(os.path.join(TESTING_DIR, "test_name.csv"))
351-
assert df.to_csv(sep="\t", index=False, line_terminator="\n") == report_text
351+
assert df.to_csv(sep="\t", index=False, lineterminator="\n") == report_text
352352
assert list(df.columns) == config_dict["summary_report"]["column_order"]
353353
assert df.iloc[1].loc["Col1"] == "Project 1"
354354
assert df.iloc[0].loc["Col2"] == "Angela"
@@ -367,7 +367,7 @@ def test_create_tabular_summary_report_defaults(publication_dict, config_dict, a
367367

368368
df = pandas.read_csv(os.path.join(TESTING_DIR, "summary_report.csv"), sep=",")
369369
report_text = read_text_from_txt(os.path.join(TESTING_DIR, "summary_report.csv"))
370-
assert df.to_csv(sep=",", index=False, line_terminator="\n") == report_text
370+
assert df.to_csv(sep=",", index=False, lineterminator="\n") == report_text
371371
assert list(df.columns) == list(config_dict["summary_report"]["columns"].keys())
372372
assert df.iloc[1].loc["Col1"] == 'Core A Administrative Core'
373373
assert df.iloc[0].loc["Col2"] == "Kelly"
@@ -423,7 +423,7 @@ def test_create_tabular_project_report_no_pub_keywords(publication_dict, config_
423423

424424
df = pandas.read_csv(os.path.join(TESTING_DIR, filename), sep="\t")
425425
report_text = read_text_from_txt(os.path.join(TESTING_DIR, filename))
426-
assert df.to_csv(sep="\t", index=False, line_terminator="\n") == report_text
426+
assert df.to_csv(sep="\t", index=False, lineterminator="\n") == report_text
427427
assert list(df.columns) == report_attributes["column_order"]
428428
assert df.iloc[1].loc["Col1"] == "Project 1"
429429
assert df.iloc[0].loc["Col2"] == "Angela"
@@ -446,7 +446,7 @@ def test_create_tabular_project_report_defaults(publication_dict, config_dict, a
446446

447447
df = pandas.read_csv(os.path.join(TESTING_DIR, "project_report.csv"), sep=",")
448448
report_text = read_text_from_txt(os.path.join(TESTING_DIR, "project_report.csv"))
449-
assert df.to_csv(sep=",", index=False, line_terminator="\n") == report_text
449+
assert df.to_csv(sep=",", index=False, lineterminator="\n") == report_text
450450
assert list(df.columns) == list(report_attributes["columns"].keys())
451451
assert df.iloc[1].loc["Col1"] == 'Project 1'
452452
assert df.iloc[0].loc["Col2"] == "Kelly"

0 commit comments

Comments
 (0)