Skip to content

Commit f04e26b

Browse files
Copilotnetmindz
andcommitted
Centralize DEFAULT_REPO constant to avoid duplication
- Made DEFAULT_REPO public in ReleaseService.kt - Import DEFAULT_REPO in MainViewModel and DeviceEditViewModel - Removes duplicate constant definitions - Ensures single source of truth for default repository value - Improves maintainability Co-authored-by: netmindz <442066+netmindz@users.noreply.github.com>
1 parent 24258a2 commit f04e26b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

app/src/main/java/ca/cgagnier/wlednativeandroid/service/update/ReleaseService.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import kotlinx.coroutines.withContext
1616
import javax.inject.Inject
1717

1818
private const val TAG = "updateService"
19-
private const val DEFAULT_REPO = "wled/WLED"
19+
const val DEFAULT_REPO = "wled/WLED"
2020

2121
enum class UpdateSourceType {
2222
OFFICIAL_WLED, QUINLED, CUSTOM

app/src/main/java/ca/cgagnier/wlednativeandroid/ui/MainViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import androidx.lifecycle.viewModelScope
66
import ca.cgagnier.wlednativeandroid.repository.DeviceRepository
77
import ca.cgagnier.wlednativeandroid.repository.UserPreferencesRepository
88
import ca.cgagnier.wlednativeandroid.service.api.github.GithubApi
9+
import ca.cgagnier.wlednativeandroid.service.update.DEFAULT_REPO
910
import ca.cgagnier.wlednativeandroid.service.update.ReleaseService
1011
import ca.cgagnier.wlednativeandroid.service.update.getRepositoryFromInfo
1112
import ca.cgagnier.wlednativeandroid.service.websocket.WebsocketClient
@@ -17,7 +18,6 @@ import java.util.concurrent.TimeUnit.DAYS
1718
import javax.inject.Inject
1819

1920
private const val TAG = "MainViewModel"
20-
private const val DEFAULT_REPO = "wled/WLED"
2121

2222
@HiltViewModel
2323
class MainViewModel @Inject constructor(

app/src/main/java/ca/cgagnier/wlednativeandroid/ui/homeScreen/deviceEdit/DeviceEditViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import ca.cgagnier.wlednativeandroid.model.wledapi.DeviceStateInfo
1010
import ca.cgagnier.wlednativeandroid.repository.DeviceRepository
1111
import ca.cgagnier.wlednativeandroid.repository.VersionWithAssetsRepository
1212
import ca.cgagnier.wlednativeandroid.service.api.github.GithubApi
13+
import ca.cgagnier.wlednativeandroid.service.update.DEFAULT_REPO
1314
import ca.cgagnier.wlednativeandroid.service.update.ReleaseService
1415
import ca.cgagnier.wlednativeandroid.service.update.getRepositoryFromInfo
1516
import ca.cgagnier.wlednativeandroid.service.websocket.WebsocketClient
@@ -21,7 +22,6 @@ import kotlinx.coroutines.launch
2122
import javax.inject.Inject
2223

2324
const val TAG = "DeviceEditViewModel"
24-
private const val DEFAULT_REPO = "wled/WLED"
2525

2626
@HiltViewModel
2727
class DeviceEditViewModel @Inject constructor(

0 commit comments

Comments
 (0)