Skip to content

Commit ff05b58

Browse files
committed
Fix minor things on Settings page
1 parent 45c3360 commit ff05b58

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/settings.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,18 +42,21 @@
4242
</div>
4343
<div class='row'>
4444
<label for='githubUserInput'>GitHub account:</label>
45+
<input type='text' id='githubUserInput' value=''>
4546
<div class='hint'>
4647
GitHub account to look for data. Change at your own risk.
4748
<a id='resetGithubUserBut' href='#'>Restore default</a>.
4849
</div>
49-
<input type='text' id='githubUserInput' value=''>
5050
</div>
5151
<div class='row clearfix'>
5252
<button id='saveBut' class='to-right'>Save</button>
5353
</div>
5454
<div class='row'>
5555
<label for='refreshBut'>Refresh data:</label>
5656
<div><button id='refreshBut'>Refresh Data</button></div>
57+
<div class='hint'>
58+
The plugin periodically reloads available looks from GitHub. This button makes it reload now.
59+
</div>
5760
</div>
5861
<div class='row'>
5962
<label for='welcomePageBut'>Welcome page:</label>

src/settings.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ function dirty() {
4343
saveBut.innerText = 'Save*'
4444
}
4545

46-
async function sendMessageOnClick(msg, button) {
46+
async function sendMessageOnClick(msg, button, successCaption) {
4747
hideResultDivs()
4848
const onclick = button.onclick
4949
button.onclick = undefined
@@ -53,20 +53,21 @@ async function sendMessageOnClick(msg, button) {
5353
try {
5454
await browser.runtime.sendMessage(msg)
5555
addResultNode(button.parentNode)
56+
button.innerText = successCaption || caption
5657
} catch (e) {
5758
addResultNode(button.parentNode, '' + e)
59+
button.innerText = caption
5860
} finally {
5961
button.onclick = onclick
6062
button.style.cursor = 'default'
61-
button.innerText = caption
6263
}
6364
}
6465

6566
function onSaveClick() {
6667
const newSettings = {
6768
githubUser: githubUserInput.value
6869
}
69-
sendMessageOnClick({type: 'set_settings', settings: newSettings}, saveBut)
70+
sendMessageOnClick({type: 'set_settings', settings: newSettings}, saveBut, 'Save')
7071
.catch(e => console.log('Failed to save settings', e))
7172
}
7273

0 commit comments

Comments
 (0)