fix(minidump_parser): improve version check

Author: tysmith

src/ffpuppet/minidump_parser.py

@@ -320,16 +320,15 @@ def mdsw_available(cls, min_version: str = "0.15.2") -> bool:
             )
             return False
         # version check
-        for cver, mver in zip(current_version.split("."), min_version.split(".")):
-            if int(cver) > int(mver):
-                break
-            if int(cver) < int(mver):
-                LOG.error(
-                    "minidump-stackwalk '%s' is unsupported (minimum '%s')",
-                    current_version,
-                    min_version,
-                )
-                return False
+        current = tuple(int(x) for x in current_version.split("."))
+        minimum = tuple(int(x) for x in min_version.split("."))
+        if current < minimum:
+            LOG.error(
+                "minidump-stackwalk '%s' is unsupported (minimum '%s')",
+                current_version,
+                min_version,
+            )
+            return False
         LOG.debug("detected minidump-stackwalk version '%s'", current_version)
         return True
 

src/ffpuppet/test_minidump_parser.py

@@ -228,6 +228,12 @@ def test_minidump_parser_04(tmp_path):
             "minidump-stackwalk",
             True,
         ),
+        # minidump-stackwalk major version is higher
+        (
+            (CompletedProcess([], 0, stdout=b"minidump-stackwalk 1.0.0\n"),),
+            "minidump-stackwalk",
+            True,
+        ),
         # minidump-stackwalk is matches minimum version
         (
             (CompletedProcess([], 0, stdout=b"minidump-stackwalk 0.15.2\n"),),