Skip to content

Commit a395329

Browse files
committed
Added notification icon + bugfix
1 parent 598c2b7 commit a395329

10 files changed

Lines changed: 823 additions & 6 deletions

File tree

app/.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
/build
1+
/build
2+
/release/

app/src/main/AndroidManifest.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@
2222
android:name="com.google.firebase.messaging.default_notification_channel_id"
2323
android:value="@string/new_comic_channel_id" />
2424

25+
<meta-data
26+
android:name="com.google.firebase.messaging.default_notification_icon"
27+
android:resource="@drawable/notification_thick"
28+
/>
2529

2630
<activity
2731
android:name="de.mr_pine.xkcdfeed.MainActivity"

app/src/main/java/de/mr_pine/xkcdfeed/SingleComicViewModel.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ class SingleComicViewModel: ViewModel() {
1414
var currentNumber by mutableStateOf(-1)
1515
var imageLoaded by mutableStateOf(true)
1616

17+
fun getNumber(): Int {
18+
return currentComic?.id ?: -1
19+
}
20+
1721
fun setComic(number: Int, context: Context){
1822
currentNumber = number
1923

app/src/main/java/de/mr_pine/xkcdfeed/composables/single/Single.kt

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ fun SingleViewContent(
7171
setFavorite: (XKCDComic) -> Unit,
7272
removeFavorite: (XKCDComic) -> Unit,
7373
colorMatrix: ColorMatrix,
74+
getNumber: () -> Int,
7475
navigateHome: () -> Unit,
7576
startActivity: (Intent) -> Unit
7677
) {
@@ -93,7 +94,9 @@ fun SingleViewContent(
9394
scaffoldState.bottomSheetState.expand()
9495
})
9596

96-
fun getId() = comic.id
97+
fun getId(): Int {
98+
return comic.id
99+
}
97100
var currentNumberString by remember(comic.id) { mutableStateOf(comic.id.toString()) }
98101

99102
var parentSize by remember { mutableStateOf(IntSize(0, 0)) }
@@ -195,10 +198,10 @@ fun SingleViewContent(
195198
coroutineScope = scope,
196199
zoomableState = zoomableState,
197200
onSwipeLeft = {
198-
if (getId() < maxNumber) setNumber(getId() + 1)
201+
if (getNumber() < maxNumber) setNumber(getNumber() + 1)
199202
},
200203
onSwipeRight = {
201-
if (getId() > 0) setNumber(getId() - 1)
204+
if (getNumber() > 0) setNumber(getNumber() - 1)
202205
},
203206
) {
204207
Image(
@@ -478,10 +481,10 @@ fun bottomSheetContent(
478481
verticalAlignment = Alignment.Bottom
479482
) {
480483
Text(
481-
text = comic.title ?: "I am a title :)",
484+
text = comic.title ?: "",
482485
fontWeight = FontWeight.Bold,
483486
fontSize = 24.sp,
484-
modifier = Modifier.placeholder(comic.title == null)
487+
modifier = Modifier.widthIn(min = if(comic.title == null) 200.dp else 0.dp).placeholder(comic.title == null)
485488
)
486489
Text(
487490
text = "(${comic.id})",
@@ -595,6 +598,7 @@ fun SingleViewContentStateful(
595598
setNumber = { singleViewModel.currentComic = mainViewModel.loadComic(it) },
596599
maxNumber = mainViewModel.latestComicNumber,
597600
colorMatrix = ColorMatrix(mainViewModel.matrix.toColorMatrix()),
601+
getNumber = singleViewModel::getNumber,
598602
startActivity = { mainViewModel.startActivity(it) },
599603
navigateHome = navigateHome
600604
)
154 KB
Loading
164 KB
Loading

0 commit comments

Comments
 (0)