оптимизации по рекомендациям

Author: Mr-Rm

src/OneScript.StandardLibrary/Collections/Indexes/CollectionIndex.cs

@@ -42,7 +42,7 @@ public CollectionIndex(IIndexCollectionSource source, IEnumerable<IValue> fields
 
         internal bool CanBeUsedFor(IEnumerable<IValue> searchFields)
         {
-            return _fields.Count>0 && _fields.ToHashSet().IsSubsetOf(searchFields);
+            return _fields.Count > 0 && _fields.All(f => searchFields.Contains(f));
         }
 
         private CollectionIndexKey IndexKey(PropertyNameIndexAccessor source)

src/OneScript.StandardLibrary/Collections/ValueTable/ValueTable.cs

@@ -84,13 +84,14 @@ public ValueTableRow Add()
         [ContextMethod("Вставить", "Insert")]
         public ValueTableRow Insert(int index)
         {
-            var row = new ValueTableRow(this);
             if (index < 0 || index > _rows.Count)
-                _rows.Add(row); // для совместимости с 1С, хотя логичней было бы исключение
-            else
-                _rows.Insert(index, row);
+                return Add(); // для совместимости с 1С, хотя логичней было бы исключение
 
-            Indexes.ElementAdded(row);
+            var row = new ValueTableRow(this);
+            _rows.Insert(index, row);
+
+            if (Indexes.Count() > 0)
+                Indexes.ElementAdded(row);
             return row;
         }
 
@@ -347,7 +348,7 @@ public ArrayImpl FindRows(StructureImpl filter)
 
             var mapped = ColumnsMap(filter);
             var suitableIndex = Indexes.FindSuitableIndex(mapped.Keys());
-            var dataToScan = suitableIndex != null ? suitableIndex.GetData(mapped) : _rows;
+            var dataToScan = suitableIndex?.GetData(mapped) ?? _rows;
 
             foreach (var element in dataToScan)
             {

src/OneScript.StandardLibrary/Collections/ValueTable/ValueTableColumn.cs

@@ -24,7 +24,7 @@ public class ValueTableColumn : AutoContext<ValueTableColumn>
         private readonly TypeDescription _valueType;
         private readonly WeakReference _owner;
 
-        public bool IsIndexable { get; set; }
+        public bool IsIndexable { get; internal set; }
 
         public ValueTableColumn(ValueTableColumnCollection owner, string name, string title, TypeDescription type, int width)
         {

src/OneScript.StandardLibrary/Collections/ValueTable/ValueTableRow.cs

@@ -24,11 +24,8 @@ public ValueTableRow(ValueTable owner)
             _owner = owner;
         }
 
-        public int Count()
-        {
-            return _owner.Columns.Count();
-        }
-        
+        public int Count() => _owner.Columns.Count();
+
         public int Count(IBslProcess process) => Count();
 
         /// <summary>