Fix CI

Author: MrDesjardins

tests/conftest.py

@@ -29,23 +29,47 @@ def mock_config():
     return config
 
 
-@pytest.fixture(autouse=True)
+@pytest.fixture(scope="session", autouse=True)
+def _set_test_db_path():
+    """Set DATABASE_PATH environment variable for all tests.
+
+    This runs once at the start of the test session to ensure no test
+    can accidentally write to the development database.
+    """
+    original_db = os.environ.get("DATABASE_PATH")
+    test_db = os.path.join(tempfile.gettempdir(), "test_audio_history.db")
+    os.environ["DATABASE_PATH"] = test_db
+
+    yield
+
+    # Restore original
+    if original_db:
+        os.environ["DATABASE_PATH"] = original_db
+    else:
+        os.environ.pop("DATABASE_PATH", None)
+
+    # Cleanup test database
+    if os.path.exists(test_db):
+        try:
+            os.unlink(test_db)
+        except Exception:
+            pass
+
+
+@pytest.fixture
 def db_path(monkeypatch):
     """Temporary SQLite database for testing.
 
-    This fixture runs automatically for ALL tests to ensure they never
-    touch the development database.
-
-    Renamed from temp_db to db_path to match existing test expectations.
+    This fixture creates a fresh database for tests that explicitly request it.
+    Most tests will just use the session-level database via _set_test_db_path.
     """
     with tempfile.NamedTemporaryFile(suffix=".db", delete=False) as f:
         temp_path = f.name
 
     # Set environment variable for database using monkeypatch
-    # This ensures proper cleanup even if tests fail
     monkeypatch.setenv("DATABASE_PATH", temp_path)
 
-    # Force reload of database module to pick up new DATABASE_PATH
+    # Reload database module to pick up new DATABASE_PATH
     import services.database
     import importlib
 
@@ -63,7 +87,6 @@ def db_path(monkeypatch):
         try:
             os.unlink(temp_path)
         except Exception:
-            # Ignore cleanup errors
             pass