Skip to content

Commit c2c01d8

Browse files
committed
ci: naming convention
1 parent 3278d19 commit c2c01d8

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

.github/workflows/draft.yml

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
name: "Draft"
2-
32
on:
43
push:
54
branches:
65
- master
76
- main
8-
tags: [ "v[0-9]+.[0-9]+.[0-9]?" ]
9-
7+
tags: ["v[0-9]+.[0-9]+.[0-9]?"]
108
workflow_dispatch:
119
# inputs:
1210

@@ -17,7 +15,6 @@ env:
1715
RUST_BACKTRACE: 1
1816
PROJECT_NAME: csv_parser_rs
1917
NIGHTLY_BODY: ${{ github.event.release.body }}
20-
2118
jobs:
2219
build-unix:
2320
name: "Draft - build-unix"
@@ -60,7 +57,7 @@ jobs:
6057
- name: "Upload artifact"
6158
uses: actions/upload-artifact@v4
6259
with:
63-
name: ${{ env.PROJECT_NAME }}-${{ matrix.target }}-${{ github.ref_name }}.zip
60+
name: ${{ env.PROJECT_NAME }}-${{ matrix.target }}-${{ github.ref_name }} # Adding .zip to the name will cause XYZ.zip.zip (Where the second one is just a naming convention)
6461
path: ${{ env.PROJECT_NAME }}-${{ matrix.target }}-${{ github.ref_name }} # We don't want the zipped archive as upload-artifact already zips it
6562
if-no-files-found: 'error'
6663
compression-level: '9'
@@ -105,7 +102,7 @@ jobs:
105102
- name: "Upload artifact"
106103
uses: actions/upload-artifact@v4
107104
with:
108-
name: ${{ env.PROJECT_NAME }}-${{ matrix.target }}-${{ github.ref_name }}.zip
105+
name: ${{ env.PROJECT_NAME }}-${{ matrix.target }}-${{ github.ref_name }}
109106
path: ${{ env.PROJECT_NAME }}-${{ matrix.target }}-${{ github.ref_name }} # We don't want the zipped archive as upload-artifact already zips it
110107
if-no-files-found: 'error'
111108
compression-level: '9'
@@ -117,7 +114,7 @@ jobs:
117114
permissions:
118115
contents: write
119116
runs-on: ubuntu-latest
120-
needs: [ build-unix, build-windows ]
117+
needs: [build-unix, build-windows]
121118
steps:
122119
- uses: actions/download-artifact@v4
123120
id: artifact-download-step
@@ -129,12 +126,11 @@ jobs:
129126
repository: ${{ github.repository }}
130127
# TODO: and when done - remove this
131128
prerelease: true
132-
133129
fail_on_unmatched_files: true
134130
draft: true
135131
# make_latest: true ## Drafts & prereleases cannot be set as `make_latest:`
136132
files: |
137-
${{ env.PROJECT_NAME }}-*.zip
133+
${{ env.PROJECT_NAME }}-${{ matrix.target }}-${{ github.ref_name }}.*
138134
generate_release_notes: true
139135
# body_path: ${{ github.workspace }}-CHANGELOG.txt ## For adding changelog content
140136

@@ -143,7 +139,7 @@ jobs:
143139
permissions:
144140
contents: write
145141
runs-on: ubuntu-latest
146-
needs: [ build-unix, build-windows ]
142+
needs: [build-unix, build-windows]
147143
steps:
148144
- run: |
149145
echo 'NIGHTLY_BODY<<EOF' >> $GITHUB_ENV
@@ -166,9 +162,7 @@ jobs:
166162
prerelease: true
167163
fail_on_unmatched_files: true
168164
files: |
169-
${{ env.PROJECT_NAME }}-*.zip
165+
${{ env.PROJECT_NAME }}-${{ matrix.target }}-${{ github.ref_name }}.*
170166
name: Nightly Build
171167
body: ${{ env.NIGHTLY_BODY }}
172168
target_commitish: ${{ github.sha }}
173-
174-

0 commit comments

Comments
 (0)