Merge branch 'hiero-ledger:main' into main

Author: MrMadHatt

…ub/scripts/check_advanced_requirement.sh .github/scripts/bot-advanced-check.sh.github/scripts/check_advanced_requirement.sh renamed to .github/scripts/bot-advanced-check.sh .github/scripts/check_advanced_requirement.sh renamed to .github/scripts/bot-advanced-check.sh

@@ -0,0 +1,88 @@
+// Script to notify the team when a Good First Issue Candidate is created.
+
+const marker = '<!-- GFI Candidate Notification -->';
+const TEAM_ALIAS = '@hiero-ledger/hiero-sdk-good-first-issue-support';
+
+
+async function notifyTeam(github, owner, repo, issue, message) {
+  const dryRun = process.env.DRY_RUN === 'true';
+   if (dryRun) {
+    console.log('Notified team about GFI candidate');
+    console.log(`Repo: ${owner}/${repo}`);
+    console.log(`Issue: #${issue.number} - ${issue.title}`);
+    console.log(`Message:\n${message}`);
+    return true;
+  }
+  const comment = `${marker} :wave: Hello Team :wave:
+${TEAM_ALIAS}
+
+${message}
+
+Repository: ${owner}/${repo}
+Issue: #${issue.number} - ${issue.title || '(no title)'}
+
+Best Regards,
+Hiero Python SDK team`;
+
+  try {
+    await github.rest.issues.createComment({
+      owner,
+      repo,
+      issue_number: issue.number,
+      body: comment,
+    });
+    console.log(`Notified team about #${issue.number}`);
+    return true;
+  } catch (err) {
+    console.log(
+      `Failed to notify team about GFI candidate #${issue.number}:`,
+      err.message || err
+    );
+    return false;
+  }
+}
+
+module.exports = async ({ github, context }) => {
+  try {
+    const { owner, repo } = context.repo;
+    const { issue, label } = context.payload;
+    const dryRun = process.env.DRY_RUN === 'true';
+
+    if (!issue?.number || !label?.name) {
+      return console.log('Missing issue or label in payload');
+    }
+
+    //  Only handle Good First Issue Candidate
+    if (label.name.toLowerCase() !== 'good first issue candidate') {
+      return;
+    }
+
+    // Checking dry run
+    dryRun && console.log('DRY-RUN active');
+
+    // Prevent duplicate notifications
+    const comments = await github.paginate(
+      github.rest.issues.listComments,
+      { owner, repo, issue_number: issue.number, per_page: 100 }
+    );
+
+    if (comments.some(c => c.body?.includes(marker))) {
+      return console.log(`Notification already exists for #${issue.number}`);
+    }
+
+    const message =
+      'A new Good First Issue Candidate has been created. Please review it and confirm whether it should be labeled as a Good First Issue.';
+
+    const success = await notifyTeam(github, owner, repo, issue, message);
+
+    if (success) {
+      console.log('=== Summary ===');
+      console.log(`Repository: ${owner}/${repo}`);
+      console.log(`Issue Number: ${issue.number}`);
+      console.log(`Label: ${label.name}`);
+    }
+  } catch (err) {
+    console.log('❌ Error:', err.message);
+    throw err;
+  }
+};

.github/scripts/bot-gfi-candidate-notification.js

@@ -10,6 +10,7 @@ set -euo pipefail
 REPO="${REPO:-${GITHUB_REPOSITORY:-}}"
 DAYS="${DAYS:-7}"
 DRY_RUN="${DRY_RUN:-false}"
+MARKER='<!-- issue-reminder-bot -->'
 
 # Normalize DRY_RUN to "true" or "false"
 if [[ "$DRY_RUN" == "true" || "$DRY_RUN" == "yes" || "$DRY_RUN" == "1" ]]; then
@@ -72,7 +73,7 @@ echo "$ALL_ISSUES_JSON" | jq -c '.' | while read -r ISSUE_JSON; do
 
   # Check if this issue already has a reminder comment from ReminderBot
   EXISTING_COMMENT=$(gh api "repos/$REPO/issues/$ISSUE/comments" \
-    --jq ".[] | select(.user.login == \"github-actions[bot]\") | select(.body | contains(\"ReminderBot\")) | .id" \
+    --jq ".[] | select(.user.login == \"github-actions[bot]\") | select(.body | contains(\"<!-- issue-reminder-bot -->\")) | .id" \
     | head -n1)
 
   if [ -n "$EXISTING_COMMENT" ]; then
@@ -136,10 +137,12 @@ echo "$ALL_ISSUES_JSON" | jq -c '.' | while read -r ISSUE_JSON; do
 
   ASSIGNEE_MENTIONS=$(echo "$ISSUE_JSON" | jq -r '.assignees[].login | "@" + .' | xargs)
 
-  MESSAGE="Hi ${ASSIGNEE_MENTIONS} 👋
+  MESSAGE="${MARKER}
+Hi ${ASSIGNEE_MENTIONS} 👋
 
 This issue has been assigned but no pull request has been created yet.
 Are you still planning on working on it?
+If you are, please create a draft PR linked to this issue so we know you are working on it.
 
 From the Python SDK Team"
 
@@ -155,4 +158,4 @@ done
 
 echo "------------------------------------------------------------"
 echo " Issue Reminder Bot (No PR) complete."
-echo "------------------------------------------------------------"
+echo "------------------------------------------------------------"

.github/scripts/bot-issue-reminder-no-pr.sh

@@ -20,6 +20,14 @@ module.exports = async ({ github, context }) => {
       prData = prResponse.data;
     }
 
+    const authorType = prData.user?.type;
+    const authorLogin = prData.user?.login;
+
+    if (authorType === "Bot" || authorLogin?.endsWith('[bot]')){
+      console.log(`Skipping comment: PR created by bot (${authorLogin})`);
+      return;
+    }
+
     const body = prData.body || "";
     const regex = /\bFixes\s*:?\s*(#\d+)(\s*,\s*#\d+)*/i;
 
@@ -81,5 +89,4 @@ module.exports = async ({ github, context }) => {
     console.error('Repository:', `${context.repo.owner}/${context.repo.repo}`);
     throw error;
   }
-};
-
+};

.github/scripts/bot-pr-missing-linked-issue.js

@@ -34,5 +34,5 @@ jobs:
           ISSUE_NUMBER: ${{ github.event.issue.number }}
           REPO: ${{ github.repository }}
         run: |
-          chmod +x .github/scripts/check_advanced_requirement.sh
-          ./.github/scripts/check_advanced_requirement.sh
+          chmod +x .github/scripts/bot-advanced-check.sh
+          ./.github/scripts/bot-advanced-check.sh

.github/workflows/bot-advanced-check.yml

@@ -0,0 +1,39 @@
+# This workflow notifies the GFI support team when an issue is labeled as GFI Candidate.
+
+name: Good First Issue Candidate Notification
+
+on:
+  issues:
+    types:
+      - labeled
+
+permissions:
+  issues: write
+  contents: read
+
+jobs:
+  gfi_candidate_notify_team:
+    runs-on: ubuntu-latest
+    if: contains(github.event.issue.labels.*.name, 'good first issue candidate')
+    concurrency:
+      group: gfi-candidate-${{ github.event.issue.number }}
+      cancel-in-progress: false
+
+    steps:
+      - name: Harden the runner
+        uses: step-security/harden-runner@20cf305ff2072d973412fa9b1e3a4f227bda3c76
+        with:
+          egress-policy: audit
+
+      - name: Checkout repository
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 #v6.0.1
+
+      - name: Notify team of GFI candidate
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          DRY_RUN: ${{ github.repository_owner != 'hiero-ledger' }}
+        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd  #v8.0.0
+        with:
+          script: |
+            const script = require('./.github/scripts/bot-gfi-candidate-notification.js');
+            await script({ github, context });

.github/workflows/bot-gfi-candidate-notification.yaml

@@ -24,7 +24,7 @@ jobs:
                   python-version: "3.11"
 
             - name: Install uv
-              uses: astral-sh/setup-uv@681c641aba71e4a1c380be3ab5e12ad51f415867 # v7.1.6
+              uses: astral-sh/setup-uv@61cb8a9741eeb8a550a1b8544337180c0fc8476b # v7.2.0
 
             - name: Install dependencies
               run: |

.github/workflows/pr-check-codecov.yml

@@ -24,7 +24,7 @@ jobs:
           fetch-depth: 0
 
       - name: Install uv
-        uses: astral-sh/setup-uv@681c641aba71e4a1c380be3ab5e12ad51f415867
+        uses: astral-sh/setup-uv@61cb8a9741eeb8a550a1b8544337180c0fc8476b
 
       - name: Install dependencies
         run: uv sync

.github/workflows/pr-check-examples.yml

@@ -36,7 +36,7 @@ jobs:
           cache: "pip"
 
       - name: Install uv
-        uses: astral-sh/setup-uv@681c641aba71e4a1c380be3ab5e12ad51f415867 # v7.1.6
+        uses: astral-sh/setup-uv@61cb8a9741eeb8a550a1b8544337180c0fc8476b # v7.2.0
 
       - name: Install setuptools wheel
         run: pip install --upgrade pip setuptools wheel

.github/workflows/pr-check-test.yml

@@ -7,17 +7,20 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 ## [Unreleased]
 
 ### Added
+- Added comprehensive docstring to `FeeAssessmentMethod` enum explaining inclusive vs exclusive fee assessment methods with usage examples. (#1391)
+- Added comprehensive docstring to `TokenType` enum explaining fungible vs non-fungible tokens with practical use cases. (#1392)
+
+- Added a notification workflow that alerts the support team when an issue is labeled as a Good First Issue Candidate.[(#1296)]
 - Added comprehensive training documentation for the `Query` class, covering execution flow, payments, retries, and building child queries. (#1238)
 - Beginner issue documentation and updated GFI and GFIC templates and documentation
 - Enable auto assignment to good first issues (#1312), archived good first issue support team notification. Changed templates with new assign instruction.
 - Intermediate issue documentation
 - Added unit test for 'endpoint.py' to increase coverage.
 - Automated assignment guard for `advanced` issues; requires completion of at least one `good first issue` and one `intermediate` issue before assignment (exempts maintainers, committers, and triage members). (#1142)
 - Added Hbar object support for TransferTransaction HBAR transfers:
-  - Methods now accept `Union[int, Hbar]` for amount parameters with immediate normalization to tinybars
-  - Includes comprehensive unit tests covering various Hbar units (HBAR, MICROBAR, NANOBAR, TINYBAR) and accumulation behavior with mixed `int` and `Hbar` inputs
-- Added a module-level docstring to the HBAR allowance approval example to clarify
-  delegated spending behavior and key concepts. [#1202](https://github.com/hiero-ledger/hiero-sdk-python/issues/1202)
+- Methods now accept `Union[int, Hbar]` for amount parameters with immediate normalization to tinybars
+- Includes comprehensive unit tests covering various Hbar units (HBAR, MICROBAR, NANOBAR, TINYBAR) and accumulation behavior with mixed `int` and `Hbar` inputs
+- Added a module-level docstring to the HBAR allowance approval example to clarify delegated spending behavior and key concepts. [#1202](https://github.com/hiero-ledger/hiero-sdk-python/issues/1202)
 - Added a GitHub Actions workflow to validate broken Markdown links in pull requests.
 - Added method chaining examples to the developer training guide (`docs/sdk_developers/training/coding_token_transactions.md`) (#1194)
 - Added documentation explaining how to pin GitHub Actions to specific commit SHAs (`docs/sdk_developers/how-to-pin-github-actions.md`)(#1211)
@@ -92,6 +95,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 - Added technical docstrings and hardening (set -euo pipefail) to the pr-check-test-files.sh script (#1336)
 
 ### Changed
+- Renamed `.github/scripts/check_advanced_requirement.sh` to `bot-advanced-check.sh` for workflow consistency (#1341)
 - Added global review instructions to CodeRabbit configuration to limit reviews to issue/PR scope and prevent scope creep [#1373]
 - Archived unused auto draft GitHub workflow to prevent it from running (#1371)
 - Added comprehensive documentation to the PR changelog check script (`.github/scripts/pr-check-changelog.sh`) to clarify behavior, inputs, permissions, and dependencies [(#1337)]
@@ -148,6 +152,8 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 - Enhance assignment bot to guard against users with spam PRs `.github/scripts/bot-assignment-check.sh`
 - Add CodeRabbit documentation review prompts for docs, sdk_users, and sdk_developers with priorities, philosophy, and edge case checks. ([#1236](https://github.com/hiero-ledger/hiero-sdk-python/issues/1236))
 - Enhance NodeAddress tests with additional coverage for proto conversion `tests/unit/node_address_test.py`
+- Replaced deprecated `AccountCreateTransaction.set_key()` usage with `set_key_without_alias()` and `set_key_with_alias()` across examples and tests
+
 - Updated `pyproject.toml` to enforce stricter Ruff linting rules, including Google-style docstrings (`D`), import sorting (`I`), and modern Python syntax (`UP`).
 - Modified and renamed hasIntermediateOrAdvancedLabel() to check if issue label is beginner or higher (#1385)
 
@@ -167,6 +173,8 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 - Fixed `cron-check-broken-links.yml` string parsing issue in context input `dry_run` (#1235)
 - Flaky tests by disabling TLS in mock Hedera nodes in `mock_server.py`
 - Fixed LinkBot permission issue for fork PRs by changing trigger to pull_request_target and adding proper permissions.
+- Fixed duplicate comment prevention in issue reminder bot by adding hidden HTML marker for reliable comment detection (.github/scripts/bot-issue-reminder-no-pr.sh) (#1372)
+- Fixed bot-pr-missing-linked-issue to skip commenting on pull requests created by automated bots. (#1382)
 
 ### Breaking Change