1.7.1

Author: MrRefactoring

README.md

@@ -147,7 +147,7 @@ const client = new Client({
 
  ```ts
  import { Client } from "jira.js";
- 
+
  const client = new Client({
    host: "https://jira.somehost.com",
    middlewares: {
@@ -174,6 +174,10 @@ Can't find what you need in the readme? Check out our documentation here: https:
 
 ## Latest version changelog
 
+### 1.7.1
+
+- FIX: Headers fixes
+
 ### 1.7.0
 
 - IMPROVEMENT: Readme examples updated

package.json

@@ -1,6 +1,6 @@
 {
   "name": "jira.js",
-  "version": "1.7.0",
+  "version": "1.7.1",
   "main": "out/index.js",
   "types": "out/index.d.ts",
   "repository": "https://github.com/MrRefactoring/jira.js.git",

src/helpers/index.ts

@@ -3,6 +3,19 @@ import * as jwt from 'atlassian-jwt';
 import * as url from 'url';
 import { Config } from '../config';
 
+export const removeEmptyValues = (obj: { [key: string]: unknown }) => Object.entries(obj)
+  .forEach(([key, val]) => {
+    if (val && typeof val === 'object') {
+      // @ts-ignore
+      removeEmptyValues(val);
+    } else if (val == null) {
+      // eslint-disable-next-line no-param-reassign
+      delete obj[key];
+    } else {
+      console.log(obj);
+    }
+  });
+
 export const getAuthentication = (
   config: Config,
   request: AxiosRequestConfig,

src/index.ts

@@ -3,7 +3,7 @@
 import axios, { AxiosInstance, AxiosRequestConfig } from 'axios';
 import { Callback } from './callback';
 import { Config } from './config';
-import { getAuthentication } from './helpers';
+import { getAuthentication, removeEmptyValues } from './helpers';
 import {
   ApplicationRoles,
   AppProperties,
@@ -188,14 +188,18 @@ export class Client {
   private requestInstance: AxiosInstance;
 
   constructor(private readonly config: Config) {
+    const headers = {
+      ...config.baseRequestConfig?.headers,
+      'x-atlassian-force-account-id': config.strictGDPR,
+    };
+
+    removeEmptyValues(headers);
+
     this.requestInstance = axios.create({
       timeout: config.timeout,
       ...config.baseRequestConfig,
       baseURL: config.host,
-      headers: {
-        ...config.baseRequestConfig?.headers,
-        'x-atlassian-force-account-id': config.strictGDPR,
-      },
+      headers,
     });
 
     this.applicationRoles = new ApplicationRoles(this);
@@ -294,6 +298,8 @@ export class Client {
         ...request.headers,
       };
 
+      removeEmptyValues(request.headers);
+
       const response = await this.requestInstance.request(request);
 
       const callbackResponseHandler = callback && ((data: any): void => callback(null, data));