Table headers with sort/reverse sort, configurable fields for create row data

[peaklo]

I'd like to be able to show additional fields from the index in the creature data row.
It would also be nice to have headers to label all that additional data.
And as long as there are headers, it would be neat if clicking on those headers sorted/reverse sorted the creature table.

So, I've already created changes in my fork to do all these things. If the implementation isn't up to standards or you just don't feel like pulling it in, no worries. I won't create a PR for it yet, but if you want to review the changes, I've linked the diff below. Thanks!

main...peaklo:foundry-summons:main

[MrVauxs]

Nice idea. However, I don't like certain things about this implementation:

1, The existence of "dnd5e-" and "pf2eColumns". There should be only one column array, in a separate file that exports the appropriate defaults, as all other system-dependent variables do.
2. Pre-existing sorting code not being applied to the new format. There shouldn't be two places where you can sort things by. Only one place. This also includes the existence of getRowTemplate and etc.
3. Using inline styles instead of Tailwind classes, but I can fix that on my own to make the looks serviceable.

Overall looks promising, I'll likely add my own implementation with inspiration from the features you added later.

[peaklo]

Thanks, I'll take a look and see if I can clean it up. If you don't mind clearing some things up...

1. I think I understand... since the system is known, automatically use the correct column definitions? Similar to question below... would you just always apply the default columns and get rid of existing sort?

2. I didn't want to change the sort worked for existing users, and wasn't sure how existing sort methods could be mapped to columns - would you just get rid of the sort drop down and force users to adjust their macros?

3. Oops, I usually develop styles inline and move them to custom later...

Thanks again.

[MrVauxs]

The existing sorting arguments can be easily converted to the new ones by simply assuming the width of the column.

[peaklo]

If you're curious, I revised my fork from your suggestions and a few other things that were bothering me...

• got rid of sort drop down, only column sort now
• define column data per system as suggested
• switch to table display, this causes cell width to adjust automatically, no longer has to be specified in the column def.
• moved styles to classes where possible - still not sure if I've tailwinded them properly though. I'm not familiar with it and just didn't have time to dig into it.

[MrVauxs]

You haven't used Tailwind at all 😅
But I like the other changes. As said, the styling can be left to me as I will likely change it anyway, including using tables, I don't like them and I don't think its appropriate for such a list. There's grid for that.

[peaklo]

You haven't used Tailwind at all 😅
Lol I am not surprised :D ... I assumed tailwind was related to the style blocks at the "tail" end of the svelte files until I started reading about it more. Doesn't look like tailwind is installed in this project?

including using tables, I don't like them and I don't think its appropriate for such a list. There's grid for that.
It seems like tables have been out of style since they were introduced, poor tables, haha. I did try some css grid solutions but they didn't work cleanly, if at all. Tables was clean and solved the requirement, mine at least. I spent maybe 30 minutes messing with installing tailwind and switching to grid, but that's about all I've got. Winter break is coming to an end and I'll need these changes for a game soon, so with apologies I will probably end up forking completely so I can use these features in a game soon.

Thanks again, the module is brilliant, it's been a great first foray into FVTT development.

[MrVauxs]

Ah, after working so much on another module of mine I thought that Foundry Summons also used tailwind... then yeah, this is the only way, or I install it. Apologies for that one!

I will look into implementing this in a weeks time or so. I have my own deadlines to have to deal with, but I'll certainly try getting this in a timely manner.