Change the behavior to throw exception if credentials/token are invalid or there are some issues connecting to vault. (#48)

Author: MrZoidberg

Source/VaultSharp.Extensions.Configuration/VaultConfigurationProvider.cs

@@ -112,6 +112,7 @@ public override void Load()
             catch (Exception e) when (e is VaultApiException || e is System.Net.Http.HttpRequestException)
             {
                 this.logger?.Log(LogLevel.Error, e, "Cannot load configuration from Vault");
+                throw;
             }
         }
 

Tests/VaultSharp.Extensions.Configuration.Test/IntegrationTests.cs

@@ -5,7 +5,6 @@ namespace VaultSharp.Extensions.Configuration.Test
     using System.IO;
     using System.Net;
     using System.Net.Http;
-    using System.Text.Json;
     using System.Threading;
     using System.Threading.Tasks;
     using DotNet.Testcontainers.Builders;
@@ -14,7 +13,6 @@ namespace VaultSharp.Extensions.Configuration.Test
     using Microsoft.Extensions.Configuration;
     using Microsoft.Extensions.Logging;
     using Moq;
-    using Newtonsoft.Json.Linq;
     using Serilog;
     using Serilog.Extensions.Logging;
     using VaultSharp.Core;
@@ -598,22 +596,25 @@ public async Task Failure_PermissionDenied()
                     "myservice-config",
                     "secret",
                     loggerMock.Object);
-                var configurationRoot = builder.Build();
+                Action act = () => builder.Build();
+                act.Should().Throw<VaultApiException>().And.HttpStatusCode.Should().Be(HttpStatusCode.Forbidden);
 
-                // assert
-                loggerMock.Verify(
-                    x => x.Log(
-                        It.Is<LogLevel>(l => l == LogLevel.Error),
-                        It.IsAny<EventId>(),
-                        It.Is<It.IsAnyType>((v, t) => v.ToString() == "Cannot load configuration from Vault"),
-                        It.Is<VaultApiException>(exception => exception.HttpStatusCode == HttpStatusCode.Forbidden),
-                        It.Is<Func<It.IsAnyType, Exception?, string>>((v, t) => true)), Times.Once);
-            }
+            }           
             finally
             {
                 cts.Cancel();
                 await container.DisposeAsync().ConfigureAwait(false);
             }
+
+            // assert
+            loggerMock.Verify(
+                x => x.Log(
+                    It.Is<LogLevel>(l => l == LogLevel.Error),
+                    It.IsAny<EventId>(),
+                    It.Is<It.IsAnyType>((v, t) => v.ToString() == "Cannot load configuration from Vault"),
+                    It.Is<VaultApiException>(exception => exception.HttpStatusCode == HttpStatusCode.Forbidden),
+                    It.Is<Func<It.IsAnyType, Exception?, string>>((v, t) => true)), Times.Once);
+
         }
     }
 

Tests/VaultSharp.Extensions.Configuration.Test/IntegrationTests_SSL.cs

@@ -82,10 +82,11 @@ public async Task SSL_Enabled_CannotVerifyCert()
                 "test",
                 "secret",
                 this._logger);
-            var configurationRoot = builder.Build();
+            Action act = () => builder.Build();
+
 
             // assert
-            configurationRoot.GetValue<string>("option1").Should().BeNull();
+            act.Should().Throw<System.Net.Http.HttpRequestException>("The SSL connection could not be established, see inner exception.");
         }
         finally
         {