Skip to content

Commit fc2885c

Browse files
committed
refactor(BasicFormatter): improve trace ID handling in BasicFormatter
1 parent f385066 commit fc2885c

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/chromatrace/logging_settings.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ def _format_process_id(self, process_id: int) -> str:
9999
def format(self, record):
100100
record_copy = copy(record)
101101
record_copy.__dict__["process"] = f'PID:{getattr(record_copy, "process", 0)}'
102+
trace_id = getattr(record_copy, "trace_id", "NAN")
102103
if self.colored:
103104
record_copy.__dict__["levelname"] = self._color_level_name(
104105
level_name=record_copy.levelname, level_no=record_copy.levelno
@@ -108,10 +109,8 @@ def format(self, record):
108109
record_copy.__dict__["process"] = self._format_process_id(
109110
record_copy.process
110111
)
111-
if not (record_copy.trace_id == "NAN" and self.remove_nan_trace):
112-
record_copy.__dict__["trace_id"] = self._format_trace_id(
113-
record_copy.trace_id
114-
)
112+
if not (trace_id == "NAN" and self.remove_nan_trace):
113+
record_copy.__dict__["trace_id"] = self._format_trace_id(trace_id)
115114

116115
record_copy.__dict__["msg"] = (
117116
self.message_splitter + record_copy.__dict__["msg"]

0 commit comments

Comments
 (0)