Update entity.php to safely handle null and boolean values in key details like in fce4d8b

Msprg · Msprg · commit 9044f6e9e458 · 2025-12-03T11:03:40.000Z
diff --git a/model/entity.php b/model/entity.php
@@ -89,7 +89,8 @@ public function log($details, $level = LOG_INFO, User $actor = null) {
 
 		$text = "KeysScope=\"{$scope}\" KeysRequester=\"{$actor->uid}\"";
 		foreach($details as $key => $value) {
-			$text .= ' Keys'.ucfirst($key).'="'.str_replace('"', '', $value).'"';
+			$safe_value = ($value === null) ? '' : (is_bool($value) ? ($value ? 'true' : 'false') : (string)$value);
+			$text .= ' Keys'.ucfirst($key).'="'.str_replace('"', '', $safe_value).'"';
 		}
 		openlog('keys', LOG_ODELAY, LOG_AUTH);
 		syslog($level, $text);

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,8 @@ public function log($details, $level = LOG_INFO, User $actor = null) {`
`89`	`89`
`90`	`90`	`$text = "KeysScope=\"{$scope}\" KeysRequester=\"{$actor->uid}\"";`
`91`	`91`	`foreach($details as $key => $value) {`
`92`		`- $text .= ' Keys'.ucfirst($key).'="'.str_replace('"', '', $value).'"';`
	`92`	`+ $safe_value = ($value === null) ? '' : (is_bool($value) ? ($value ? 'true' : 'false') : (string)$value);`
	`93`	`+ $text .= ' Keys'.ucfirst($key).'="'.str_replace('"', '', $safe_value).'"';`
`93`	`94`	`}`
`94`	`95`	`openlog('keys', LOG_ODELAY, LOG_AUTH);`
`95`	`96`	`syslog($level, $text);`