Skip to content

Remove instances of "bubble" #1257

@eyeseast

Description

@eyeseast

In some components, we pass through native events to parent components. In Svelte 4, this looked like this:

<button on:click>...</button>

However, the on: directive is deprecated and events handlers are now props, which we can check for and require. Svelte's automatic migration sometimes runs into cases where it can't tell if a handler prop is required, and so it adds a bubbler for backwards compatibility. These don't break anything, but we should get rid of them.

These will show up as we migrate components, so this should happen as part of the migration, or after.

Components:

  • src/lib/components/forms/Search.svelte
  • src/lib/components/inputs/KeyValue.svelte

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions