Skip to content

Commit 4ee08c8

Browse files
ewelsclaude
andcommitted
Refactor SAV module to follow MultiQC best practices
Apply improvements based on MultiQC module development guidelines: Critical fixes: - Add ModuleNoSamplesFound exception when no data found - Add add_data_source() and add_software_version() calls - Add write_data_file() call at end of module init - Export SAVModule class from __init__.py High priority fixes: - Change anchor from "SAV" to "sav" (lowercase) - Add href to Illumina InterOp GitHub repository - Improve info string (remove leading " - ") Medium priority improvements: - Add comprehensive class docstring documenting supported sequencers - Add scale attributes to all HEADERS entries for semantic coloring - Add general stats columns (% >= Q30, Yield, % PF, Error Rate) Low priority improvements: - Support multiple sequencing runs (removed single-run limitation) - Add defensive checks with .get() defaults in _clusters_lane_plot() - Update function type hints to use SAVModule type Also add multiqc_data* and multiqc_report* to .gitignore. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 82433e5 commit 4ee08c8

File tree

3 files changed

+211
-35
lines changed

3 files changed

+211
-35
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
multiqc_data*
2+
multiqc_report*
3+
14
# Byte-compiled / optimized / DLL files
25
__pycache__/
36
*.py[cod]
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
from .sav import SAVModule
2+
3+
__all__ = ["SAVModule"]

0 commit comments

Comments
 (0)